All of lore.kernel.org
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	Arnd Bergmann <arnd@arndb.de>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: Linux-next: Build failed
Date: Tue, 4 Dec 2018 12:52:34 +0000	[thread overview]
Message-ID: <20181204125233.GA1519@arm.com> (raw)
In-Reply-To: <CA+G9fYsvJkW5_hruVYzLX3g9_5scj9nnL240rOMQ+DSz70dqqQ@mail.gmail.com>

Hi Naresh,

On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
> FYI,
> 
> The Linux -next build failed due to below warnings/errors.
> 
> include/asm-generic/bitops/atomic.h: In function 'set_bit':
> include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
> of function 'atomic_long_or'; did you mean '__atomic_load_n'?
> [-Werror=implicit-function-declaration]
>   atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
>   ^~~~~~~~~~~~~~
>   __atomic_load_n

Ha, I like that the compiler is trying to get us to use its __atomic
builtins here :)

Anyway, you're seeing this because of this previous error in Mark's script:

.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found

even though fold is part of coreutils :/

Do you have grep? Maybe the diff below helps.

Will

--->8

diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
index 9d6be538a987..81d5c32039dd 100755
--- a/scripts/atomic/atomic-tbl.sh
+++ b/scripts/atomic/atomic-tbl.sh
@@ -180,7 +180,7 @@ gen_proto_variants()
 #gen_proto(meta, ...)
 gen_proto() {
        local meta="$1"; shift
-       for m in $(echo "${meta}" | fold -w1); do
+       for m in $(echo "${meta}" | grep -o .); do
                gen_proto_variants "${m}" "$@"
        done
 }


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
	linux-arm-kernel@lists.infradead.org,
	Peter Zijlstra <peterz@infradead.org>,
	Mark Rutland <mark.rutland@arm.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: Linux-next: Build failed
Date: Tue, 4 Dec 2018 12:52:34 +0000	[thread overview]
Message-ID: <20181204125233.GA1519@arm.com> (raw)
In-Reply-To: <CA+G9fYsvJkW5_hruVYzLX3g9_5scj9nnL240rOMQ+DSz70dqqQ@mail.gmail.com>

Hi Naresh,

On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
> FYI,
> 
> The Linux -next build failed due to below warnings/errors.
> 
> include/asm-generic/bitops/atomic.h: In function 'set_bit':
> include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
> of function 'atomic_long_or'; did you mean '__atomic_load_n'?
> [-Werror=implicit-function-declaration]
>   atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
>   ^~~~~~~~~~~~~~
>   __atomic_load_n

Ha, I like that the compiler is trying to get us to use its __atomic
builtins here :)

Anyway, you're seeing this because of this previous error in Mark's script:

.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found

even though fold is part of coreutils :/

Do you have grep? Maybe the diff below helps.

Will

--->8

diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
index 9d6be538a987..81d5c32039dd 100755
--- a/scripts/atomic/atomic-tbl.sh
+++ b/scripts/atomic/atomic-tbl.sh
@@ -180,7 +180,7 @@ gen_proto_variants()
 #gen_proto(meta, ...)
 gen_proto() {
        local meta="$1"; shift
-       for m in $(echo "${meta}" | fold -w1); do
+       for m in $(echo "${meta}" | grep -o .); do
                gen_proto_variants "${m}" "$@"
        done
 }


  reply	other threads:[~2018-12-04 12:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 12:26 Linux-next: Build failed Naresh Kamboju
2018-12-04 12:26 ` Naresh Kamboju
2018-12-04 12:52 ` Will Deacon [this message]
2018-12-04 12:52   ` Will Deacon
2018-12-04 14:46   ` Naresh Kamboju
2018-12-04 14:46     ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204125233.GA1519@arm.com \
    --to=will.deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=naresh.kamboju@linaro.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.