* [PATCH] drm/amdgpu/si: fix SI after doorbell rework
@ 2018-12-03 2:49 Alex Deucher
[not found] ` <20181203024958.28896-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2018-12-03 2:49 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
SI does not use doorbells, move asic doorbell init later
asic check.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108920
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index c75badfa5c4c..5a72906fdc6b 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -515,7 +515,6 @@ void amdgpu_device_pci_config_reset(struct amdgpu_device *adev)
*/
static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
{
- amdgpu_asic_init_doorbell_index(adev);
/* No doorbell on SI hardware generation */
if (adev->asic_type < CHIP_BONAIRE) {
@@ -529,6 +528,8 @@ static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
if (pci_resource_flags(adev->pdev, 2) & IORESOURCE_UNSET)
return -EINVAL;
+ amdgpu_asic_init_doorbell_index(adev);
+
/* doorbell bar mapping */
adev->doorbell.base = pci_resource_start(adev->pdev, 2);
adev->doorbell.size = pci_resource_len(adev->pdev, 2);
--
2.13.6
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/si: fix SI after doorbell rework
[not found] ` <20181203024958.28896-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
@ 2018-12-04 19:00 ` Alex Deucher
[not found] ` <CADnq5_Mfcpi8if_id1TtpZgdca59hbLTWag1AqaTFXJM4k9-XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Alex Deucher @ 2018-12-04 19:00 UTC (permalink / raw)
To: amd-gfx list, Oak Zeng; +Cc: Deucher, Alexander
Ping?
On Sun, Dec 2, 2018 at 9:50 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> SI does not use doorbells, move asic doorbell init later
> asic check.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108920
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c75badfa5c4c..5a72906fdc6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -515,7 +515,6 @@ void amdgpu_device_pci_config_reset(struct amdgpu_device *adev)
> */
> static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
> {
> - amdgpu_asic_init_doorbell_index(adev);
>
> /* No doorbell on SI hardware generation */
> if (adev->asic_type < CHIP_BONAIRE) {
> @@ -529,6 +528,8 @@ static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
> if (pci_resource_flags(adev->pdev, 2) & IORESOURCE_UNSET)
> return -EINVAL;
>
> + amdgpu_asic_init_doorbell_index(adev);
> +
> /* doorbell bar mapping */
> adev->doorbell.base = pci_resource_start(adev->pdev, 2);
> adev->doorbell.size = pci_resource_len(adev->pdev, 2);
> --
> 2.13.6
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amdgpu/si: fix SI after doorbell rework
[not found] ` <CADnq5_Mfcpi8if_id1TtpZgdca59hbLTWag1AqaTFXJM4k9-XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-12-04 19:12 ` sylvain.bertrand-Re5JQEeQqe8AvxtiuMwx3w
2018-12-04 19:26 ` Zeng, Oak
1 sibling, 0 replies; 4+ messages in thread
From: sylvain.bertrand-Re5JQEeQqe8AvxtiuMwx3w @ 2018-12-04 19:12 UTC (permalink / raw)
To: Alex Deucher; +Cc: Deucher, Alexander, Oak Zeng, amd-gfx list
On Tue, Dec 04, 2018 at 02:00:54PM -0500, Alex Deucher wrote:
> Ping?
Does fix the SI issue (done in bugzilla).
--
Sylvain
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] drm/amdgpu/si: fix SI after doorbell rework
[not found] ` <CADnq5_Mfcpi8if_id1TtpZgdca59hbLTWag1AqaTFXJM4k9-XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-04 19:12 ` sylvain.bertrand-Re5JQEeQqe8AvxtiuMwx3w
@ 2018-12-04 19:26 ` Zeng, Oak
1 sibling, 0 replies; 4+ messages in thread
From: Zeng, Oak @ 2018-12-04 19:26 UTC (permalink / raw)
To: Alex Deucher, amd-gfx list; +Cc: Deucher, Alexander
Reviewed-by: Oak Zeng <Oak.Zeng@amd.com>
Regards,
Oak
-----Original Message-----
From: Alex Deucher <alexdeucher@gmail.com>
Sent: Tuesday, December 4, 2018 2:01 PM
To: amd-gfx list <amd-gfx@lists.freedesktop.org>; Zeng, Oak <Oak.Zeng@amd.com>
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>
Subject: Re: [PATCH] drm/amdgpu/si: fix SI after doorbell rework
Ping?
On Sun, Dec 2, 2018 at 9:50 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> SI does not use doorbells, move asic doorbell init later asic check.
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=108920
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index c75badfa5c4c..5a72906fdc6b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -515,7 +515,6 @@ void amdgpu_device_pci_config_reset(struct amdgpu_device *adev)
> */
> static int amdgpu_device_doorbell_init(struct amdgpu_device *adev) {
> - amdgpu_asic_init_doorbell_index(adev);
>
> /* No doorbell on SI hardware generation */
> if (adev->asic_type < CHIP_BONAIRE) { @@ -529,6 +528,8 @@
> static int amdgpu_device_doorbell_init(struct amdgpu_device *adev)
> if (pci_resource_flags(adev->pdev, 2) & IORESOURCE_UNSET)
> return -EINVAL;
>
> + amdgpu_asic_init_doorbell_index(adev);
> +
> /* doorbell bar mapping */
> adev->doorbell.base = pci_resource_start(adev->pdev, 2);
> adev->doorbell.size = pci_resource_len(adev->pdev, 2);
> --
> 2.13.6
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-04 19:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-03 2:49 [PATCH] drm/amdgpu/si: fix SI after doorbell rework Alex Deucher
[not found] ` <20181203024958.28896-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-12-04 19:00 ` Alex Deucher
[not found] ` <CADnq5_Mfcpi8if_id1TtpZgdca59hbLTWag1AqaTFXJM4k9-XA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-04 19:12 ` sylvain.bertrand-Re5JQEeQqe8AvxtiuMwx3w
2018-12-04 19:26 ` Zeng, Oak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.