All of lore.kernel.org
 help / color / mirror / Atom feed
* [rocko/master] [PATCH] matrix-gui: update matrix-gui-2.0.service
@ 2018-12-04 19:35 Hongmei Gou
  2018-12-04 19:50 ` Denys Dmytriyenko
  0 siblings, 1 reply; 3+ messages in thread
From: Hongmei Gou @ 2018-12-04 19:35 UTC (permalink / raw)
  To: meta-arago; +Cc: Hongmei Gou

* Add "Requires=weston.service" to make matrix-gui start only after
  weston has successfully started

* Match matrix-gui-2.0.service with SysVinit auto-generated service
  to ensure reliable matrxi-gui startup from booting

Signed-off-by: Hongmei Gou <a0271529@ti.com>
---
 .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service        | 9 +++++++++
 meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb          | 2 +-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
index 3ce1024..cd87d8b 100644
--- a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
@@ -1,9 +1,18 @@
 [Unit]
 Description=Matrix GUI
 After=weston.service
+Requires=weston.service
+Before=graphical.target
+Before=thermal-zone-init.service
 
 [Service]
 Type=forking
+Restart=no
+TimeoutSec=5min
+IgnoreSIGPIPE=no
+KillMode=process
+GuessMainPID=no
+RemainAfterExit=yes
 ExecStart=/etc/init.d/matrix-gui-2.0 start
 
 [Install]
diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
index c79f13e..064e27d 100644
--- a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
+++ b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
@@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=a886c9ef769b2d8271115d2502512e5d"
 
 SECTION = "multimedia"
 
-PR = "r36"
+PR = "r37"
 
 SYSTEMD_SERVICE_${PN} = "matrix-gui-2.0.service"
 
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [rocko/master] [PATCH] matrix-gui: update matrix-gui-2.0.service
  2018-12-04 19:35 [rocko/master] [PATCH] matrix-gui: update matrix-gui-2.0.service Hongmei Gou
@ 2018-12-04 19:50 ` Denys Dmytriyenko
  2018-12-04 20:22   ` Gou, Hongmei
  0 siblings, 1 reply; 3+ messages in thread
From: Denys Dmytriyenko @ 2018-12-04 19:50 UTC (permalink / raw)
  To: Hongmei Gou; +Cc: meta-arago

On Tue, Dec 04, 2018 at 02:35:38PM -0500, Hongmei Gou wrote:
> * Add "Requires=weston.service" to make matrix-gui start only after
>   weston has successfully started
> 
> * Match matrix-gui-2.0.service with SysVinit auto-generated service
>   to ensure reliable matrxi-gui startup from booting
> 
> Signed-off-by: Hongmei Gou <a0271529@ti.com>
> ---
>  .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service        | 9 +++++++++
>  meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb          | 2 +-
>  2 files changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> index 3ce1024..cd87d8b 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-2.0.service
> @@ -1,9 +1,18 @@
>  [Unit]
>  Description=Matrix GUI
>  After=weston.service
> +Requires=weston.service
> +Before=graphical.target

> +Before=thermal-zone-init.service

I don't believe this one should be added - there's no dependency between the 
two and thermal-zone-init may be gone in the future or on some platforms.


>  [Service]
>  Type=forking
> +Restart=no
> +TimeoutSec=5min
> +IgnoreSIGPIPE=no
> +KillMode=process
> +GuessMainPID=no
> +RemainAfterExit=yes
>  ExecStart=/etc/init.d/matrix-gui-2.0 start
>  
>  [Install]
> diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> index c79f13e..064e27d 100644
> --- a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=a886c9ef769b2d8271115d2502512e5d"
>  
>  SECTION = "multimedia"
>  
> -PR = "r36"
> +PR = "r37"
>  
>  SYSTEMD_SERVICE_${PN} = "matrix-gui-2.0.service"
>  
> -- 
> 1.9.1
> 
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [rocko/master] [PATCH] matrix-gui: update matrix-gui-2.0.service
  2018-12-04 19:50 ` Denys Dmytriyenko
@ 2018-12-04 20:22   ` Gou, Hongmei
  0 siblings, 0 replies; 3+ messages in thread
From: Gou, Hongmei @ 2018-12-04 20:22 UTC (permalink / raw)
  To: Dmytriyenko, Denys; +Cc: meta-arago@arago-project.org

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Tuesday, December 04, 2018 2:51 PM
> To: Gou, Hongmei
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [rocko/master] [PATCH] matrix-gui: update matrix-
> gui-2.0.service
> 
> On Tue, Dec 04, 2018 at 02:35:38PM -0500, Hongmei Gou wrote:
> > * Add "Requires=weston.service" to make matrix-gui start only after
> >   weston has successfully started
> >
> > * Match matrix-gui-2.0.service with SysVinit auto-generated service
> >   to ensure reliable matrxi-gui startup from booting
> >
> > Signed-off-by: Hongmei Gou <a0271529@ti.com>
> > ---
> >  .../recipes-core/matrix/matrix-gui/matrix-gui-2.0.service        | 9
> +++++++++
> >  meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb          | 2 +-
> >  2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-
> 2.0.service b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-
> 2.0.service
> > index 3ce1024..cd87d8b 100644
> > --- a/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-
> 2.0.service
> > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui/matrix-gui-
> 2.0.service
> > @@ -1,9 +1,18 @@
> >  [Unit]
> >  Description=Matrix GUI
> >  After=weston.service
> > +Requires=weston.service
> > +Before=graphical.target
> 
> > +Before=thermal-zone-init.service
> 
> I don't believe this one should be added - there's no dependency between
> the
> two and thermal-zone-init may be gone in the future or on some platforms.

Yes, you are right. Will submit a V2 patch to remove this. 

> 
> 
> >  [Service]
> >  Type=forking
> > +Restart=no
> > +TimeoutSec=5min
> > +IgnoreSIGPIPE=no
> > +KillMode=process
> > +GuessMainPID=no
> > +RemainAfterExit=yes
> >  ExecStart=/etc/init.d/matrix-gui-2.0 start
> >
> >  [Install]
> > diff --git a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> > index c79f13e..064e27d 100644
> > --- a/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> > +++ b/meta-arago-extras/recipes-core/matrix/matrix-gui_2.0.bb
> > @@ -6,7 +6,7 @@ LIC_FILES_CHKSUM =
> "file://LICENSE;md5=a886c9ef769b2d8271115d2502512e5d"
> >
> >  SECTION = "multimedia"
> >
> > -PR = "r36"
> > +PR = "r37"
> >
> >  SYSTEMD_SERVICE_${PN} = "matrix-gui-2.0.service"
> >
> > --
> > 1.9.1
> >
> > _______________________________________________
> > meta-arago mailing list
> > meta-arago@arago-project.org
> > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-12-04 20:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-04 19:35 [rocko/master] [PATCH] matrix-gui: update matrix-gui-2.0.service Hongmei Gou
2018-12-04 19:50 ` Denys Dmytriyenko
2018-12-04 20:22   ` Gou, Hongmei

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.