All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH v6 15/20] rtc: s3c: Switch to use %ptR
Date: Tue,  4 Dec 2018 23:23:25 +0200	[thread overview]
Message-ID: <20181204212330.69515-16-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>

Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/rtc/rtc-s3c.c | 20 ++++----------------
 1 file changed, 4 insertions(+), 16 deletions(-)

diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c
index 58e03ac3578b..04c68178c42d 100644
--- a/drivers/rtc/rtc-s3c.c
+++ b/drivers/rtc/rtc-s3c.c
@@ -225,13 +225,9 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm)
 	s3c_rtc_disable_clk(info);
 
 	rtc_tm->tm_year += 100;
-
-	dev_dbg(dev, "read time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday,
-		rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec);
-
 	rtc_tm->tm_mon -= 1;
 
+	dev_dbg(dev, "read time %ptR\n", rtc_tm);
 	return 0;
 }
 
@@ -241,9 +237,7 @@ static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm)
 	int year = tm->tm_year - 100;
 	int ret;
 
-	dev_dbg(dev, "set time %04d.%02d.%02d %02d:%02d:%02d\n",
-		1900 + tm->tm_year, tm->tm_mon, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "set time %ptR\n", tm);
 
 	/* we get around y2k by simply not supporting it */
 
@@ -292,10 +286,7 @@ static int s3c_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm)
 
 	alrm->enabled = (alm_en & S3C2410_RTCALM_ALMEN) ? 1 : 0;
 
-	dev_dbg(dev, "read alarm %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alm_en,
-		1900 + alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday,
-		alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec);
+	dev_dbg(dev, "read alarm %d, %ptR\n", alm_en, alm_tm);
 
 	/* decode the alarm enable field */
 	if (alm_en & S3C2410_RTCALM_SECEN)
@@ -328,10 +319,7 @@ static int s3c_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm)
 	unsigned int alrm_en;
 	int ret;
 
-	dev_dbg(dev, "s3c_rtc_setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n",
-		alrm->enabled,
-		1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday,
-		tm->tm_hour, tm->tm_min, tm->tm_sec);
+	dev_dbg(dev, "s3c_rtc_setalarm: %d, %ptR\n", alrm->enabled, tm);
 
 	ret = s3c_rtc_enable_clk(info);
 	if (ret)
-- 
2.19.2


  parent reply	other threads:[~2018-12-04 21:24 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 21:23 [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 01/20] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-10  9:09   ` Andy Shevchenko
2018-12-10 14:51   ` Petr Mladek
2018-12-04 21:23 ` [PATCH v6 02/20] rtc: Switch to use %ptR Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 03/20] rtc: at91rm9200: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 04/20] rtc: at91sam9: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 05/20] rtc: m41t80: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 06/20] rtc: m48t59: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 07/20] rtc: mcp795: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 08/20] rtc: pcf50633: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 09/20] rtc: pic32: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 10/20] rtc: pm8xxx: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 11/20] rtc: puv3: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 12/20] rtc: rk808: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 13/20] rtc: rx6110: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 14/20] rtc: rx8025: " Andy Shevchenko
2018-12-04 21:23 ` Andy Shevchenko [this message]
2018-12-04 21:23 ` [PATCH v6 16/20] rtc: s5m: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 17/20] rtc: tegra: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 18/20] Input: hp_sdc_rtc - " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 19/20] m68k/mac: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 20/20] PM: " Andy Shevchenko
2018-12-11 11:53   ` Rafael J. Wysocki
2018-12-11 12:29     ` Andy Shevchenko
2018-12-11 10:53 ` [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204212330.69515-16-andriy.shevchenko@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=a.zummo@towertech.it \
    --cc=alexandre.belloni@bootlin.com \
    --cc=arnd@arndb.de \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rtc@vger.kernel.org \
    --cc=rasmus.villemoes@prevas.dk \
    --cc=salyzyn@android.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.