From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
linux-rtc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Joe Perches <joe@perches.com>, Mark Salyzyn <salyzyn@android.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: [PATCH v6 16/20] rtc: s5m: Switch to use %ptR
Date: Tue, 4 Dec 2018 23:23:26 +0200 [thread overview]
Message-ID: <20181204212330.69515-17-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20181204212330.69515-1-andriy.shevchenko@linux.intel.com>
Use %ptR instead of open coded variant to print content of
struct rtc_time in human readable format.
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/rtc/rtc-s5m.c | 27 ++++++---------------------
1 file changed, 6 insertions(+), 21 deletions(-)
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index 6495f84f7428..c7f1bf823ea0 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -406,9 +406,7 @@ static int s5m_rtc_read_time(struct device *dev, struct rtc_time *tm)
return -EINVAL;
}
- dev_dbg(dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + tm->tm_year, 1 + tm->tm_mon, tm->tm_mday,
- tm->tm_hour, tm->tm_min, tm->tm_sec, tm->tm_wday);
+ dev_dbg(dev, "%s: %ptR(%d)\n", __func__, tm, tm->tm_wday);
return 0;
}
@@ -436,9 +434,7 @@ static int s5m_rtc_set_time(struct device *dev, struct rtc_time *tm)
if (ret < 0)
return ret;
- dev_dbg(dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + tm->tm_year, 1 + tm->tm_mon, tm->tm_mday,
- tm->tm_hour, tm->tm_min, tm->tm_sec, tm->tm_wday);
+ dev_dbg(dev, "%s: %ptR(%d)\n", __func__, tm, tm->tm_wday);
ret = regmap_raw_write(info->regmap, info->regs->time, data,
info->regs->regs_count);
@@ -490,11 +486,7 @@ static int s5m_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *alrm)
return -EINVAL;
}
- dev_dbg(dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + alrm->time.tm_year, 1 + alrm->time.tm_mon,
- alrm->time.tm_mday, alrm->time.tm_hour,
- alrm->time.tm_min, alrm->time.tm_sec,
- alrm->time.tm_wday);
+ dev_dbg(dev, "%s: %ptR(%d)\n", __func__, &alrm->time, alrm->time.tm_wday);
ret = s5m_check_peding_alarm_interrupt(info, alrm);
@@ -513,9 +505,7 @@ static int s5m_rtc_stop_alarm(struct s5m_rtc_info *info)
return ret;
s5m8767_data_to_tm(data, &tm, info->rtc_24hr_mode);
- dev_dbg(info->dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + tm.tm_year, 1 + tm.tm_mon, tm.tm_mday,
- tm.tm_hour, tm.tm_min, tm.tm_sec, tm.tm_wday);
+ dev_dbg(info->dev, "%s: %ptR(%d)\n", __func__, &tm, tm.tm_wday);
switch (info->device_type) {
case S5M8763X:
@@ -558,9 +548,7 @@ static int s5m_rtc_start_alarm(struct s5m_rtc_info *info)
return ret;
s5m8767_data_to_tm(data, &tm, info->rtc_24hr_mode);
- dev_dbg(info->dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + tm.tm_year, 1 + tm.tm_mon, tm.tm_mday,
- tm.tm_hour, tm.tm_min, tm.tm_sec, tm.tm_wday);
+ dev_dbg(info->dev, "%s: %ptR(%d)\n", __func__, &tm, tm.tm_wday);
switch (info->device_type) {
case S5M8763X:
@@ -620,10 +608,7 @@ static int s5m_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
return -EINVAL;
}
- dev_dbg(dev, "%s: %d/%d/%d %d:%d:%d(%d)\n", __func__,
- 1900 + alrm->time.tm_year, 1 + alrm->time.tm_mon,
- alrm->time.tm_mday, alrm->time.tm_hour, alrm->time.tm_min,
- alrm->time.tm_sec, alrm->time.tm_wday);
+ dev_dbg(dev, "%s: %ptR(%d)\n", __func__, &alrm->time, alrm->time.tm_wday);
ret = s5m_rtc_stop_alarm(info);
if (ret < 0)
--
2.19.2
next prev parent reply other threads:[~2018-12-04 21:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 21:23 [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 01/20] lib/vsprintf: Print time and date in human readable format via %pt Andy Shevchenko
2018-12-10 9:09 ` Andy Shevchenko
2018-12-10 14:51 ` Petr Mladek
2018-12-04 21:23 ` [PATCH v6 02/20] rtc: Switch to use %ptR Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 03/20] rtc: at91rm9200: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 04/20] rtc: at91sam9: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 05/20] rtc: m41t80: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 06/20] rtc: m48t59: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 07/20] rtc: mcp795: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 08/20] rtc: pcf50633: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 09/20] rtc: pic32: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 10/20] rtc: pm8xxx: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 11/20] rtc: puv3: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 12/20] rtc: rk808: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 13/20] rtc: rx6110: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 14/20] rtc: rx8025: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 15/20] rtc: s3c: " Andy Shevchenko
2018-12-04 21:23 ` Andy Shevchenko [this message]
2018-12-04 21:23 ` [PATCH v6 17/20] rtc: tegra: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 18/20] Input: hp_sdc_rtc - " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 19/20] m68k/mac: " Andy Shevchenko
2018-12-04 21:23 ` [PATCH v6 20/20] PM: " Andy Shevchenko
2018-12-11 11:53 ` Rafael J. Wysocki
2018-12-11 12:29 ` Andy Shevchenko
2018-12-11 10:53 ` [PATCH v6 00/20] lib, rtc: Print rtc_time via %ptR[dt][r] Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204212330.69515-17-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=b.zolnierkie@samsung.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=rasmus.villemoes@prevas.dk \
--cc=salyzyn@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.