[Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk

[Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk

[Yann E. MORIN]

Commit c2ea056a1b (package/qt5/qt5base: use ccache for building host
code) introduced a tweak to qt5's mkspec file, to define the compilers
(C and C++) to use to build qmake.

In doing so, it changed the variables in that file, from this layout:
    VAR = value

to this:
    VAR=value

During its configuration phase, qt5 will parse that file using the
system awk.

However, the system awk is not necessarily GNU awk; some systems,
especially Debian ones, use mawk as the default awk implementation.

mawk does not behave the same as GNU awk, and this causes qt5 to extract
empty values, and thus leads to build failures.

Fix that by replacing the variables with similar layout, keeping the
spaces around the equal signs.

Fixes:
    http://autobuild.buildroot.org/results/cb5/cb555a124bb3bdb9c5a3465673c21022d94cf2ca/

Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/qt5/qt5base/qt5base.mk | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/qt5/qt5base/qt5base.mk b/package/qt5/qt5base/qt5base.mk
index ec3d7042f1..98297d87db 100644
--- a/package/qt5/qt5base/qt5base.mk
+++ b/package/qt5/qt5base/qt5base.mk
@@ -273,9 +273,9 @@ endif
 
 # This allows to use ccache when available
 define QT5BASE_CONFIGURE_HOSTCC
-	$(SED) 's,^QMAKE_COMPILER\s*=.*,QMAKE_COMPILER=$(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
-	$(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC=$(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
-	$(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX=$(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
+	$(SED) 's,^QMAKE_COMPILER\s*=.*,QMAKE_COMPILER = $(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
+	$(SED) 's,^QMAKE_CC\s*=.*,QMAKE_CC = $(HOSTCC),' $(@D)/mkspecs/common/g++-base.conf
+	$(SED) 's,^QMAKE_CXX\s*=.*,QMAKE_CXX = $(HOSTCXX),' $(@D)/mkspecs/common/g++-base.conf
 endef
 
 define QT5BASE_CONFIGURE_CMDS
-- 
2.14.1

[Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk

[Thomas Petazzoni]

Hello,

On Wed,  5 Dec 2018 12:02:23 +0100, Yann E. MORIN wrote:
> Commit c2ea056a1b (package/qt5/qt5base: use ccache for building host
> code) introduced a tweak to qt5's mkspec file, to define the compilers
> (C and C++) to use to build qmake.
> 
> In doing so, it changed the variables in that file, from this layout:
>     VAR = value
> 
> to this:
>     VAR=value
> 
> During its configuration phase, qt5 will parse that file using the
> system awk.
> 
> However, the system awk is not necessarily GNU awk; some systems,
> especially Debian ones, use mawk as the default awk implementation.
> 
> mawk does not behave the same as GNU awk, and this causes qt5 to extract
> empty values, and thus leads to build failures.
> 
> Fix that by replacing the variables with similar layout, keeping the
> spaces around the equal signs.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/cb5/cb555a124bb3bdb9c5a3465673c21022d94cf2ca/
> 
> Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Thanks a lot Yann for the research/investigation!

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk

[Alexey Brodkin]

Hi Yann, all,

On Wed, 2018-12-05 at 14:00 +0100, Thomas Petazzoni wrote:
> Hello,
> 
> On Wed,  5 Dec 2018 12:02:23 +0100, Yann E. MORIN wrote:
> > Commit c2ea056a1b (package/qt5/qt5base: use ccache for building host
> > code) introduced a tweak to qt5's mkspec file, to define the compilers
> > (C and C++) to use to build qmake.
> > 
> > In doing so, it changed the variables in that file, from this layout:
> >     VAR = value
> > 
> > to this:
> >     VAR=value
> > 
> > During its configuration phase, qt5 will parse that file using the
> > system awk.
> > 
> > However, the system awk is not necessarily GNU awk; some systems,
> > especially Debian ones, use mawk as the default awk implementation.
> > 
> > mawk does not behave the same as GNU awk, and this causes qt5 to extract
> > empty values, and thus leads to build failures.
> > 
> > Fix that by replacing the variables with similar layout, keeping the
> > spaces around the equal signs.
> > 
> > Fixes:
> >     
> > https://urldefense.proofpoint.com/v2/url?u=http-3A__autobuild.buildroot.org_results_cb5_cb555a124bb3bdb9c5a3465673c21022d94cf2ca_&d=DwICAg&c=DPL6_X_6JkXFx7AXWqB0tg&r=lqdeeSSEes0GFDDl656eViXO7breS55ytWkhpk5R81I&m=S86BonA9k4UF7AG3ANLOEQcjguj5mvG5hEL4MrugAKw&s=vGDbSOkH-rPmnukIWusRAMfV7JGOSP3N68M7J9Q1FnM&e=
> > 
> > Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>

In fact "reported by BR autobuilder" :)

> > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> > Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> Acked-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> 
> Thanks a lot Yann for the research/investigation!

Indeed thanks a lot for this super fast investigation and the fix!

-Alexey

[Buildroot] [PATCH] package/qt5base: fix build when system awk is mawk, not gawk

[Thomas Petazzoni]

Hello,

On Wed,  5 Dec 2018 12:02:23 +0100, Yann E. MORIN wrote:
> Commit c2ea056a1b (package/qt5/qt5base: use ccache for building host
> code) introduced a tweak to qt5's mkspec file, to define the compilers
> (C and C++) to use to build qmake.
> 
> In doing so, it changed the variables in that file, from this layout:
>     VAR = value
> 
> to this:
>     VAR=value
> 
> During its configuration phase, qt5 will parse that file using the
> system awk.
> 
> However, the system awk is not necessarily GNU awk; some systems,
> especially Debian ones, use mawk as the default awk implementation.
> 
> mawk does not behave the same as GNU awk, and this causes qt5 to extract
> empty values, and thus leads to build failures.
> 
> Fix that by replacing the variables with similar layout, keeping the
> spaces around the equal signs.
> 
> Fixes:
>     http://autobuild.buildroot.org/results/cb5/cb555a124bb3bdb9c5a3465673c21022d94cf2ca/
> 
> Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/qt5/qt5base/qt5base.mk | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com