All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
	linux-edac <linux-edac@vger.kernel.org>
Subject: x86/mce: Streamline MCE subsystem's naming
Date: Wed, 5 Dec 2018 17:30:37 +0100	[thread overview]
Message-ID: <20181205163037.GC109259@gmail.com> (raw)

* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> Rename the containing folder to "mce" which is the most widespread name.
> Drop the "mce[-_]" filename prefix of some compilation units (while
> others don't have it).
> 
> This unifies the file naming in the MCE subsystem:
> 
> mce/
> |-- amd.c
> |-- apei.c
> |-- core.c
> |-- dev-mcelog.c
> |-- genpool.c
> |-- inject.c
> |-- intel.c
> |-- internal.h
> |-- Makefile
> |-- p5.c
> |-- severity.c
> |-- therm_throt.c
> |-- threshold.c
> `-- winchip.c
> 
> No functional changes.

Cool!

Would it make sense to organize it a bit more and separate out vendor 
specific functionality:

  mce/cpu/intel.c
  mce/cpu/intel-p5.c
  mce/cpu/amd.c
  mce/cpu/winchip.c

  mce/internal.h
  mce/core.c

  mce/genpool.c
  mce/threshold.c
  mce/severity.c
  mce/inject.c
  mce/therm_throt.c
  mce/dev-mcelog.c
  mce/apei.c

?

This way there's a clear separation between low level, vendor specific 
MCE logic and higher level MCE logic.

mce/apei.c, if this is an Intel-only feature, could perhaps become 
mce/cpu/intel-apei.c?

Anyway, your patch is fine too, so whichever subset you decide to use:

  Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Tony Luck <tony.luck@intel.com>, X86 ML <x86@kernel.org>,
	linux-edac <linux-edac@vger.kernel.org>
Subject: Re: [PATCH] x86/mce: Streamline MCE subsystem's naming
Date: Wed, 5 Dec 2018 17:30:37 +0100	[thread overview]
Message-ID: <20181205163037.GC109259@gmail.com> (raw)
In-Reply-To: <20181205141323.14995-1-bp@alien8.de>


* Borislav Petkov <bp@alien8.de> wrote:

> From: Borislav Petkov <bp@suse.de>
> 
> Rename the containing folder to "mce" which is the most widespread name.
> Drop the "mce[-_]" filename prefix of some compilation units (while
> others don't have it).
> 
> This unifies the file naming in the MCE subsystem:
> 
> mce/
> |-- amd.c
> |-- apei.c
> |-- core.c
> |-- dev-mcelog.c
> |-- genpool.c
> |-- inject.c
> |-- intel.c
> |-- internal.h
> |-- Makefile
> |-- p5.c
> |-- severity.c
> |-- therm_throt.c
> |-- threshold.c
> `-- winchip.c
> 
> No functional changes.

Cool!

Would it make sense to organize it a bit more and separate out vendor 
specific functionality:

  mce/cpu/intel.c
  mce/cpu/intel-p5.c
  mce/cpu/amd.c
  mce/cpu/winchip.c

  mce/internal.h
  mce/core.c

  mce/genpool.c
  mce/threshold.c
  mce/severity.c
  mce/inject.c
  mce/therm_throt.c
  mce/dev-mcelog.c
  mce/apei.c

?

This way there's a clear separation between low level, vendor specific 
MCE logic and higher level MCE logic.

mce/apei.c, if this is an Intel-only feature, could perhaps become 
mce/cpu/intel-apei.c?

Anyway, your patch is fine too, so whichever subset you decide to use:

  Reviewed-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

             reply	other threads:[~2018-12-05 16:30 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05 16:30 Ingo Molnar [this message]
2018-12-05 16:30 ` [PATCH] x86/mce: Streamline MCE subsystem's naming Ingo Molnar
  -- strict thread matches above, loose matches on Subject: below --
2018-12-18 23:09 [tip:ras/core] x86/mce: Restore MCE injector's module name tip-bot for Borislav Petkov
2018-12-18 23:09 ` tip-bot for Borislav Petkov
2018-12-18 18:25 Borislav Petkov
2018-12-18 18:25 ` [PATCH] " Borislav Petkov
2018-12-06 18:05 x86/mce: Streamline MCE subsystem's naming Borislav Petkov
2018-12-06 18:05 ` [PATCH] " Borislav Petkov
2018-12-06 17:36 Luck, Tony
2018-12-06 17:36 ` [PATCH] " Luck, Tony
2018-12-06 16:27 Ingo Molnar
2018-12-06 16:27 ` [PATCH] " Ingo Molnar
2018-12-05 20:09 x86/mce: Unify pr_* prefix Borislav Petkov
2018-12-05 20:09 ` [PATCH] " Borislav Petkov
2018-12-11 13:31 ` [tip:ras/core] " tip-bot for Borislav Petkov
2018-12-05 19:03 x86/mce: Streamline MCE subsystem's naming Borislav Petkov
2018-12-05 19:03 ` [PATCH] " Borislav Petkov
2018-12-05 18:01 Ingo Molnar
2018-12-05 18:01 ` [PATCH] " Ingo Molnar
2018-12-05 17:00 Borislav Petkov
2018-12-05 17:00 ` [PATCH] " Borislav Petkov
2018-12-05 16:57 Luck, Tony
2018-12-05 16:57 ` [PATCH] " Luck, Tony
2018-12-05 14:13 Borislav Petkov
2018-12-05 14:13 ` [PATCH] " Borislav Petkov
2018-12-11 13:30 ` [tip:ras/core] " tip-bot for Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205163037.GC109259@gmail.com \
    --to=mingo@kernel.org \
    --cc=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.