All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Stephen Boyd <sboyd@kernel.org>
Cc: matti.vaittinen@fi.rohmeurope.com, mazziesaccount@gmail.com,
	mturquette@baylibre.com, cw00.choi@samsung.com, krzk@kernel.org,
	b.zolnierkie@samsung.com, linux@armlinux.org.uk,
	andy.gross@linaro.org, david.brown@linaro.org,
	andrew.smirnov@gmail.com, pombredanne@nexb.com,
	sjhuang@iluvatar.ai, akshu.agrawal@amd.com, djkurtz@chromium.org,
	rafael.j.wysocki@intel.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 10/10] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock
Date: Wed, 5 Dec 2018 21:17:59 +0100	[thread overview]
Message-ID: <20181205201759.GA28800@amd> (raw)
In-Reply-To: <154403090130.88331.18352581261422337586@swboyd.mtv.corp.google.com>

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

On Wed 2018-12-05 09:28:21, Stephen Boyd wrote:
> Quoting Matti Vaittinen (2018-12-04 03:39:38)
> > diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c
> > new file mode 100644
> > index 000000000000..d486859526ed
> > --- /dev/null
> > +++ b/drivers/clk/clk-bd718x7.c
> > @@ -0,0 +1,131 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Copyright (C) 2018 ROHM Semiconductors
> > +// bd71837.c  -- ROHM BD71837MWV clock driver
> 
> This isn't even the name of the file. Please remove. Also, only the SPDX
> tag is supposed to have // on it and the other things should be normal
> /* */ comment style.

Actually whole block commented by // is now considered ok.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Stephen Boyd <sboyd@kernel.org>
Cc: david.brown@linaro.org, rafael.j.wysocki@intel.com,
	linux-doc@vger.kernel.org, linux-clk@vger.kernel.org,
	b.zolnierkie@samsung.com, andrew.smirnov@gmail.com,
	linux-kernel@vger.kernel.org, mturquette@baylibre.com,
	mazziesaccount@gmail.com, matti.vaittinen@fi.rohmeurope.com,
	linux@armlinux.org.uk, krzk@kernel.org, akshu.agrawal@amd.com,
	cw00.choi@samsung.com, djkurtz@chromium.org,
	pombredanne@nexb.com, andy.gross@linaro.org, sjhuang@iluvatar.ai,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 10/10] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock
Date: Wed, 5 Dec 2018 21:17:59 +0100	[thread overview]
Message-ID: <20181205201759.GA28800@amd> (raw)
In-Reply-To: <154403090130.88331.18352581261422337586@swboyd.mtv.corp.google.com>


[-- Attachment #1.1: Type: text/plain, Size: 852 bytes --]

On Wed 2018-12-05 09:28:21, Stephen Boyd wrote:
> Quoting Matti Vaittinen (2018-12-04 03:39:38)
> > diff --git a/drivers/clk/clk-bd718x7.c b/drivers/clk/clk-bd718x7.c
> > new file mode 100644
> > index 000000000000..d486859526ed
> > --- /dev/null
> > +++ b/drivers/clk/clk-bd718x7.c
> > @@ -0,0 +1,131 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +// Copyright (C) 2018 ROHM Semiconductors
> > +// bd71837.c  -- ROHM BD71837MWV clock driver
> 
> This isn't even the name of the file. Please remove. Also, only the SPDX
> tag is supposed to have // on it and the other things should be normal
> /* */ comment style.

Actually whole block commented by // is now considered ok.
									Pavel

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-12-05 20:18 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04 11:31 [PATCH v6 00/10] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
2018-12-04 11:31 ` Matti Vaittinen
2018-12-04 11:33 ` [PATCH v6 01/10] clkdev: add managed clkdev lookup registration Matti Vaittinen
2018-12-04 11:33   ` Matti Vaittinen
2018-12-04 11:33 ` [PATCH v6 02/10] clk: Add kerneldoc to managed of-provider interfaces Matti Vaittinen
2018-12-04 11:33   ` Matti Vaittinen
2018-12-04 19:39   ` Stephen Boyd
2018-12-04 19:39     ` Stephen Boyd
2018-12-04 11:34 ` [PATCH v6 03/10] clk: of-provider: look at parent if registered device has no provider info Matti Vaittinen
2018-12-04 11:34   ` Matti Vaittinen
2018-12-04 19:38   ` Stephen Boyd
2018-12-04 19:38     ` Stephen Boyd
2018-12-05  7:00     ` Matti Vaittinen
2018-12-05  7:00       ` Matti Vaittinen
2018-12-05 17:19       ` Stephen Boyd
2018-12-05 17:19         ` Stephen Boyd
2018-12-05 18:20         ` Matti Vaittinen
2018-12-05 18:20           ` Matti Vaittinen
2018-12-05 18:28           ` Matti Vaittinen
2018-12-05 18:28             ` Matti Vaittinen
2018-12-05 19:35           ` Stephen Boyd
2018-12-05 19:35             ` Stephen Boyd
2018-12-04 11:35 ` [PATCH v6 04/10] clk: clk-max77686: Clean clkdev lookup leak and use devm Matti Vaittinen
2018-12-04 11:35   ` Matti Vaittinen
2018-12-04 11:37 ` [PATCH v6 05/10] clk: clk-st: avoid clkdev lookup leak at remove Matti Vaittinen
2018-12-04 11:37   ` Matti Vaittinen
2018-12-04 11:37 ` [PATCH v6 06/10] clk: clk-hi655x: Free of_provider " Matti Vaittinen
2018-12-04 11:37   ` Matti Vaittinen
2018-12-05 17:25   ` Stephen Boyd
2018-12-05 17:25     ` Stephen Boyd
2018-12-04 11:38 ` [PATCH v6 07/10] clk: rk808: use managed version of of_provider registration Matti Vaittinen
2018-12-04 11:38   ` Matti Vaittinen
2018-12-05 17:25   ` Stephen Boyd
2018-12-05 17:25     ` Stephen Boyd
2018-12-04 11:38 ` [PATCH v6 08/10] clk: clk-twl6040: Free of_provider at remove Matti Vaittinen
2018-12-04 11:38   ` Matti Vaittinen
2018-12-05 17:25   ` Stephen Boyd
2018-12-05 17:25     ` Stephen Boyd
2018-12-04 11:39 ` [PATCH v6 09/10] clk: apcs-msm8916: simplify probe cleanup by using devm Matti Vaittinen
2018-12-04 11:39   ` Matti Vaittinen
2018-12-05 17:25   ` Stephen Boyd
2018-12-05 17:25     ` Stephen Boyd
2018-12-04 11:39 ` [PATCH v6 10/10] clk: bd718x7: Initial support for ROHM bd71837/bd71847 PMIC clock Matti Vaittinen
2018-12-04 11:39   ` Matti Vaittinen
2018-12-05 17:28   ` Stephen Boyd
2018-12-05 17:28     ` Stephen Boyd
2018-12-05 18:24     ` Matti Vaittinen
2018-12-05 18:24       ` Matti Vaittinen
2018-12-05 20:17     ` Pavel Machek [this message]
2018-12-05 20:17       ` Pavel Machek
2018-12-04 11:45 ` [PATCH v6 00/10] clk: clkdev/of_clk - add managed lookup and provider registrations Matti Vaittinen
2018-12-04 11:45   ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205201759.GA28800@amd \
    --to=pavel@ucw.cz \
    --cc=akshu.agrawal@amd.com \
    --cc=andrew.smirnov@gmail.com \
    --cc=andy.gross@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=david.brown@linaro.org \
    --cc=djkurtz@chromium.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=matti.vaittinen@fi.rohmeurope.com \
    --cc=mazziesaccount@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=pombredanne@nexb.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=sboyd@kernel.org \
    --cc=sjhuang@iluvatar.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.