From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-snps-arc@lists.infradead.org
Subject: [PATCH] ARC: introduce basic 'perf annotate' support for ARC
Date: Thu, 6 Dec 2018 14:14:40 -0300 [thread overview]
Message-ID: <20181206171440.GA32567@kernel.org> (raw)
In-Reply-To: <20181204175118.25232-1-Eugeniy.Paltsev@synopsys.com>
Em Tue, Dec 04, 2018 at 08:51:18PM +0300, Eugeniy Paltsev escreveu:
> Introduce basic 'perf annotate' support for ARC to be able
> to use anotation via stdio interface.
Would be nice to show the output of a 'perf annotate --stdio2' for a
perf.data file recorded on ARC :-)
- Arnaldo
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
> ---
> tools/perf/arch/arc/annotate/instructions.c | 9 +++++++++
> tools/perf/arch/common.c | 11 ++++++++++-
> tools/perf/util/annotate.c | 5 +++++
> 3 files changed, 24 insertions(+), 1 deletion(-)
> create mode 100644 tools/perf/arch/arc/annotate/instructions.c
>
> diff --git a/tools/perf/arch/arc/annotate/instructions.c b/tools/perf/arch/arc/annotate/instructions.c
> new file mode 100644
> index 000000000000..2f00e995c7e3
> --- /dev/null
> +++ b/tools/perf/arch/arc/annotate/instructions.c
> @@ -0,0 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <linux/compiler.h>
> +
> +static int arc__annotate_init(struct arch *arch, char *cpuid __maybe_unused)
> +{
> + arch->initialized = true;
> + arch->objdump.comment_char = ';';
> + return 0;
> +}
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 82657c01a3b8..f7cb57c424d1 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -5,6 +5,13 @@
> #include "../util/util.h"
> #include "../util/debug.h"
>
> +const char *const arc_triplets[] = {
> + "arc-linux-",
> + "arc-snps-linux-uclibc-",
> + "arc-snps-linux-gnu-",
> + NULL
> +};
> +
> const char *const arm_triplets[] = {
> "arm-eabi-",
> "arm-linux-androideabi-",
> @@ -147,7 +154,9 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
> zfree(&buf);
> }
>
> - if (!strcmp(arch, "arm"))
> + if (!strcmp(arch, "arc"))
> + path_list = arc_triplets;
> + else if (!strcmp(arch, "arm"))
> path_list = arm_triplets;
> else if (!strcmp(arch, "arm64"))
> path_list = arm64_triplets;
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 6936daf89ddd..66066fb4d644 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -134,6 +134,7 @@ static int arch__associate_ins_ops(struct arch* arch, const char *name, struct i
> return 0;
> }
>
> +#include "arch/arc/annotate/instructions.c"
> #include "arch/arm/annotate/instructions.c"
> #include "arch/arm64/annotate/instructions.c"
> #include "arch/x86/annotate/instructions.c"
> @@ -142,6 +143,10 @@ static int arch__associate_ins_ops(struct arch* arch, const char *name, struct i
> #include "arch/sparc/annotate/instructions.c"
>
> static struct arch architectures[] = {
> + {
> + .name = "arc",
> + .init = arc__annotate_init,
> + },
> {
> .name = "arm",
> .init = arm__annotate_init,
> --
> 2.14.5
--
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Cc: linux-snps-arc@lists.infradead.org,
Vineet Gupta <vineet.gupta1@synopsys.com>,
linux-kernel@vger.kernel.org,
Alexey Brodkin <alexey.brodkin@synopsys.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH] ARC: introduce basic 'perf annotate' support for ARC
Date: Thu, 6 Dec 2018 14:14:40 -0300 [thread overview]
Message-ID: <20181206171440.GA32567@kernel.org> (raw)
In-Reply-To: <20181204175118.25232-1-Eugeniy.Paltsev@synopsys.com>
Em Tue, Dec 04, 2018 at 08:51:18PM +0300, Eugeniy Paltsev escreveu:
> Introduce basic 'perf annotate' support for ARC to be able
> to use anotation via stdio interface.
Would be nice to show the output of a 'perf annotate --stdio2' for a
perf.data file recorded on ARC :-)
- Arnaldo
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
> ---
> tools/perf/arch/arc/annotate/instructions.c | 9 +++++++++
> tools/perf/arch/common.c | 11 ++++++++++-
> tools/perf/util/annotate.c | 5 +++++
> 3 files changed, 24 insertions(+), 1 deletion(-)
> create mode 100644 tools/perf/arch/arc/annotate/instructions.c
>
> diff --git a/tools/perf/arch/arc/annotate/instructions.c b/tools/perf/arch/arc/annotate/instructions.c
> new file mode 100644
> index 000000000000..2f00e995c7e3
> --- /dev/null
> +++ b/tools/perf/arch/arc/annotate/instructions.c
> @@ -0,0 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> +#include <linux/compiler.h>
> +
> +static int arc__annotate_init(struct arch *arch, char *cpuid __maybe_unused)
> +{
> + arch->initialized = true;
> + arch->objdump.comment_char = ';';
> + return 0;
> +}
> diff --git a/tools/perf/arch/common.c b/tools/perf/arch/common.c
> index 82657c01a3b8..f7cb57c424d1 100644
> --- a/tools/perf/arch/common.c
> +++ b/tools/perf/arch/common.c
> @@ -5,6 +5,13 @@
> #include "../util/util.h"
> #include "../util/debug.h"
>
> +const char *const arc_triplets[] = {
> + "arc-linux-",
> + "arc-snps-linux-uclibc-",
> + "arc-snps-linux-gnu-",
> + NULL
> +};
> +
> const char *const arm_triplets[] = {
> "arm-eabi-",
> "arm-linux-androideabi-",
> @@ -147,7 +154,9 @@ static int perf_env__lookup_binutils_path(struct perf_env *env,
> zfree(&buf);
> }
>
> - if (!strcmp(arch, "arm"))
> + if (!strcmp(arch, "arc"))
> + path_list = arc_triplets;
> + else if (!strcmp(arch, "arm"))
> path_list = arm_triplets;
> else if (!strcmp(arch, "arm64"))
> path_list = arm64_triplets;
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index 6936daf89ddd..66066fb4d644 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -134,6 +134,7 @@ static int arch__associate_ins_ops(struct arch* arch, const char *name, struct i
> return 0;
> }
>
> +#include "arch/arc/annotate/instructions.c"
> #include "arch/arm/annotate/instructions.c"
> #include "arch/arm64/annotate/instructions.c"
> #include "arch/x86/annotate/instructions.c"
> @@ -142,6 +143,10 @@ static int arch__associate_ins_ops(struct arch* arch, const char *name, struct i
> #include "arch/sparc/annotate/instructions.c"
>
> static struct arch architectures[] = {
> + {
> + .name = "arc",
> + .init = arc__annotate_init,
> + },
> {
> .name = "arm",
> .init = arm__annotate_init,
> --
> 2.14.5
--
- Arnaldo
next prev parent reply other threads:[~2018-12-06 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 17:51 [PATCH] ARC: introduce basic 'perf annotate' support for ARC Eugeniy Paltsev
2018-12-04 17:51 ` Eugeniy Paltsev
2018-12-06 17:14 ` Arnaldo Carvalho de Melo [this message]
2018-12-06 17:14 ` Arnaldo Carvalho de Melo
2018-12-14 20:59 ` [tip:perf/core] perf annotate: Introduce basic " tip-bot for Eugeniy Paltsev
2018-12-18 14:26 ` tip-bot for Eugeniy Paltsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206171440.GA32567@kernel.org \
--to=acme@kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.