All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: "Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com>
Cc: Sean Young <sean@mess.org>,
	Masami Hiramatsu <masami.hiramatsu@linaro.org>,
	Brad Love <brad@nextdimension.cc>,
	linux-kernel@vger.kernel.org,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Michael Ira Krufky <mkrufky@linuxtv.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-media@vger.kernel.org
Subject: Re: [PATCH v2 0/7] add UniPhier DVB Frontend system support
Date: Fri, 7 Dec 2018 12:17:16 -0200	[thread overview]
Message-ID: <20181207121716.17521ac2@coco.lan> (raw)
In-Reply-To: <000301d43ffe$9e6e9f80$db4bde80$@socionext.com>

Hi Katsuhiro-san,

Em Thu, 30 Aug 2018 10:13:11 +0900
"Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com> escreveu:

> Hello Mauro,
> 
> This is ping...

Sorry for taking a long time to look into it.

Reviewing new drivers take some time, and need to be done right.

I usually let the sub-maintainers to do a first look, but they
probably missed this one. So, let me copy them. Hopefully they
can do review on it soon.

I'll try to do a review myself, but I won't be able to do it
until mid next week.

Regards,
Mauro

> 
> > -----Original Message-----
> > From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > Sent: Wednesday, August 8, 2018 2:25 PM
> > To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
> > linux-media@vger.kernel.org
> > Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi Brar
> > <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; Suzuki, Katsuhiro 
> > <suzuki.katsuhiro@socionext.com>
> > Subject: [PATCH v2 0/7] add UniPhier DVB Frontend system support
> > 
> > This series adds support for DVB Frontend system named HSC support
> > for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
> > signal input from external demodulator and DMA MPEG2-TS stream data
> > onto memory.
> > 
> > UniPhier HSC driver provides many ports of TS input. Since the HSC
> > has mixed register map for those ports. It hard to split each register
> > areas.
> > 
> > ---
> > 
> > Changes from v1:
> >   DT bindings
> >     - Fix mistakes of spelling
> >     - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
> >   Kconfig, Makefile
> >     - Add COMPILE_TEST, REGMAP_MMIO
> >     - Add $(srctree) to include path option
> >   Headers
> >     - Split large patch
> >     - Remove more unused definitions
> >     - Remove unneeded const
> >     - Replace enum that has special value into #define
> >     - Remove weird macro from register definitions
> >     - Remove field_get/prop inline functions
> >   Modules
> >     - Split register definitions, function prototypes
> >     - Fix include lines
> >     - Fix depended config
> >     - Remove redundant conditions
> >     - Drop adapter patches, and need no patches to build
> >     - Merge uniphier-adapter.o into each adapter drivers
> >     - Split 3 modules (core, ld11, ld20) to build adapter drivers as
> >       module
> >     - Fix compile error if build as module
> >     - Use hardware spec table to remove weird macro from register
> >       definitions
> >     - Use usleep_range instead of msleep
> >     - Use shift and mask instead of field_get/prop inline functions
> > 
> > Katsuhiro Suzuki (7):
> >   media: uniphier: add DT bindings documentation for UniPhier HSC
> >   media: uniphier: add DMA common file of HSC
> >   media: uniphier: add CSS common file of HSC
> >   media: uniphier: add TS common file of HSC
> >   media: uniphier: add ucode load common file of HSC
> >   media: uniphier: add platform driver module of HSC
> >   media: uniphier: add LD11/LD20 HSC support
> > 
> >  .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
> >  drivers/media/platform/Kconfig                |   1 +
> >  drivers/media/platform/Makefile               |   2 +
> >  drivers/media/platform/uniphier/Kconfig       |  19 +
> >  drivers/media/platform/uniphier/Makefile      |   5 +
> >  drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
> >  drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
> >  drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
> >  drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
> >  drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
> >  drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
> >  drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
> >  drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
> >  13 files changed, 2519 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
> >  create mode 100644 drivers/media/platform/uniphier/Kconfig
> >  create mode 100644 drivers/media/platform/uniphier/Makefile
> >  create mode 100644 drivers/media/platform/uniphier/hsc-core.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-css.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc.h
> > 
> > --
> > 2.18.0  
> 
> 
> 



Thanks,
Mauro

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
To: "Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com>
Cc: <linux-media@vger.kernel.org>,
	"Masami Hiramatsu" <masami.hiramatsu@linaro.org>,
	"Jassi Brar" <jaswinder.singh@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>,
	Michael Ira Krufky <mkrufky@linuxtv.org>,
	Sean Young <sean@mess.org>, Brad Love <brad@nextdimension.cc>
Subject: Re: [PATCH v2 0/7] add UniPhier DVB Frontend system support
Date: Fri, 7 Dec 2018 12:17:16 -0200	[thread overview]
Message-ID: <20181207121716.17521ac2@coco.lan> (raw)
In-Reply-To: <000301d43ffe$9e6e9f80$db4bde80$@socionext.com>

Hi Katsuhiro-san,

Em Thu, 30 Aug 2018 10:13:11 +0900
"Katsuhiro Suzuki" <suzuki.katsuhiro@socionext.com> escreveu:

> Hello Mauro,
> 
> This is ping...

Sorry for taking a long time to look into it.

Reviewing new drivers take some time, and need to be done right.

I usually let the sub-maintainers to do a first look, but they
probably missed this one. So, let me copy them. Hopefully they
can do review on it soon.

I'll try to do a review myself, but I won't be able to do it
until mid next week.

Regards,
Mauro

> 
> > -----Original Message-----
> > From: Katsuhiro Suzuki <suzuki.katsuhiro@socionext.com>
> > Sent: Wednesday, August 8, 2018 2:25 PM
> > To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>;
> > linux-media@vger.kernel.org
> > Cc: Masami Hiramatsu <masami.hiramatsu@linaro.org>; Jassi Brar
> > <jaswinder.singh@linaro.org>; linux-arm-kernel@lists.infradead.org;
> > linux-kernel@vger.kernel.org; Suzuki, Katsuhiro 
> > <suzuki.katsuhiro@socionext.com>
> > Subject: [PATCH v2 0/7] add UniPhier DVB Frontend system support
> > 
> > This series adds support for DVB Frontend system named HSC support
> > for UniPhier LD11/LD20 SoCs. This driver supports MPEG2-TS serial
> > signal input from external demodulator and DMA MPEG2-TS stream data
> > onto memory.
> > 
> > UniPhier HSC driver provides many ports of TS input. Since the HSC
> > has mixed register map for those ports. It hard to split each register
> > areas.
> > 
> > ---
> > 
> > Changes from v1:
> >   DT bindings
> >     - Fix mistakes of spelling
> >     - Rename uniphier,hsc.txt -> socionext,uniphier-hsc.txt
> >   Kconfig, Makefile
> >     - Add COMPILE_TEST, REGMAP_MMIO
> >     - Add $(srctree) to include path option
> >   Headers
> >     - Split large patch
> >     - Remove more unused definitions
> >     - Remove unneeded const
> >     - Replace enum that has special value into #define
> >     - Remove weird macro from register definitions
> >     - Remove field_get/prop inline functions
> >   Modules
> >     - Split register definitions, function prototypes
> >     - Fix include lines
> >     - Fix depended config
> >     - Remove redundant conditions
> >     - Drop adapter patches, and need no patches to build
> >     - Merge uniphier-adapter.o into each adapter drivers
> >     - Split 3 modules (core, ld11, ld20) to build adapter drivers as
> >       module
> >     - Fix compile error if build as module
> >     - Use hardware spec table to remove weird macro from register
> >       definitions
> >     - Use usleep_range instead of msleep
> >     - Use shift and mask instead of field_get/prop inline functions
> > 
> > Katsuhiro Suzuki (7):
> >   media: uniphier: add DT bindings documentation for UniPhier HSC
> >   media: uniphier: add DMA common file of HSC
> >   media: uniphier: add CSS common file of HSC
> >   media: uniphier: add TS common file of HSC
> >   media: uniphier: add ucode load common file of HSC
> >   media: uniphier: add platform driver module of HSC
> >   media: uniphier: add LD11/LD20 HSC support
> > 
> >  .../bindings/media/socionext,uniphier-hsc.txt |  38 ++
> >  drivers/media/platform/Kconfig                |   1 +
> >  drivers/media/platform/Makefile               |   2 +
> >  drivers/media/platform/uniphier/Kconfig       |  19 +
> >  drivers/media/platform/uniphier/Makefile      |   5 +
> >  drivers/media/platform/uniphier/hsc-core.c    | 515 ++++++++++++++++++
> >  drivers/media/platform/uniphier/hsc-css.c     | 250 +++++++++
> >  drivers/media/platform/uniphier/hsc-dma.c     | 212 +++++++
> >  drivers/media/platform/uniphier/hsc-ld11.c    | 273 ++++++++++
> >  drivers/media/platform/uniphier/hsc-reg.h     | 272 +++++++++
> >  drivers/media/platform/uniphier/hsc-ts.c      | 127 +++++
> >  drivers/media/platform/uniphier/hsc-ucode.c   | 416 ++++++++++++++
> >  drivers/media/platform/uniphier/hsc.h         | 389 +++++++++++++
> >  13 files changed, 2519 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/media/socionext,uniphier-hsc.txt
> >  create mode 100644 drivers/media/platform/uniphier/Kconfig
> >  create mode 100644 drivers/media/platform/uniphier/Makefile
> >  create mode 100644 drivers/media/platform/uniphier/hsc-core.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-css.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-dma.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ld11.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-reg.h
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ts.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc-ucode.c
> >  create mode 100644 drivers/media/platform/uniphier/hsc.h
> > 
> > --
> > 2.18.0  
> 
> 
> 



Thanks,
Mauro

  reply	other threads:[~2018-12-07 14:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-08  5:25 [PATCH v2 0/7] add UniPhier DVB Frontend system support Katsuhiro Suzuki
2018-08-08  5:25 ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 1/7] media: uniphier: add DT bindings documentation for UniPhier HSC Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 2/7] media: uniphier: add DMA common file of HSC Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 3/7] media: uniphier: add CSS " Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 4/7] media: uniphier: add TS " Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 5/7] media: uniphier: add ucode load " Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 6/7] media: uniphier: add platform driver module " Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-08  5:25 ` [PATCH v2 7/7] media: uniphier: add LD11/LD20 HSC support Katsuhiro Suzuki
2018-08-08  5:25   ` Katsuhiro Suzuki
2018-08-30  1:13 ` [PATCH v2 0/7] add UniPhier DVB Frontend system support Katsuhiro Suzuki
2018-08-30  1:13   ` Katsuhiro Suzuki
2018-12-07 14:17   ` Mauro Carvalho Chehab [this message]
2018-12-07 14:17     ` Mauro Carvalho Chehab
2018-12-10  3:55     ` Katsuhiro Suzuki
2018-12-10  3:55       ` Katsuhiro Suzuki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181207121716.17521ac2@coco.lan \
    --to=mchehab+samsung@kernel.org \
    --cc=brad@nextdimension.cc \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=masami.hiramatsu@linaro.org \
    --cc=mkrufky@linuxtv.org \
    --cc=sean@mess.org \
    --cc=suzuki.katsuhiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.