From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtio-dev@lists.oasis-open.org, wexu@redhat.com,
jfreimann@redhat.com, maxime.coquelin@redhat.com
Subject: [virtio-dev] Re: [RFC 3/3] virtio_ring: use new vring flags
Date: Fri, 7 Dec 2018 13:10:48 -0500 [thread overview]
Message-ID: <20181207130822-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20181207084842.13133-4-tiwei.bie@intel.com>
On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote:
> Switch to using the _SPLIT_ and _PACKED_ variants of vring flags
> in split ring and packed ring respectively.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> @@ -502,7 +505,8 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> }
> }
> /* Last one doesn't continue. */
> - desc[prev].flags &= cpu_to_virtio16(_vq->vdev, ~VRING_DESC_F_NEXT);
> + desc[prev].flags &= cpu_to_virtio16(_vq->vdev,
> + (u16)~BIT(VRING_SPLIT_DESC_F_NEXT));
>
> if (indirect) {
> /* Now that the indirect table is filled in, map it. */
I kind of dislike it that this forces use of a cast here.
Kind of makes it more fragile. Let's use a temporary instead?
> --
> 2.17.1
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>
Cc: jasowang@redhat.com, virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
virtio-dev@lists.oasis-open.org, wexu@redhat.com,
jfreimann@redhat.com, maxime.coquelin@redhat.com
Subject: Re: [RFC 3/3] virtio_ring: use new vring flags
Date: Fri, 7 Dec 2018 13:10:48 -0500 [thread overview]
Message-ID: <20181207130822-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20181207084842.13133-4-tiwei.bie@intel.com>
On Fri, Dec 07, 2018 at 04:48:42PM +0800, Tiwei Bie wrote:
> Switch to using the _SPLIT_ and _PACKED_ variants of vring flags
> in split ring and packed ring respectively.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> @@ -502,7 +505,8 @@ static inline int virtqueue_add_split(struct virtqueue *_vq,
> }
> }
> /* Last one doesn't continue. */
> - desc[prev].flags &= cpu_to_virtio16(_vq->vdev, ~VRING_DESC_F_NEXT);
> + desc[prev].flags &= cpu_to_virtio16(_vq->vdev,
> + (u16)~BIT(VRING_SPLIT_DESC_F_NEXT));
>
> if (indirect) {
> /* Now that the indirect table is filled in, map it. */
I kind of dislike it that this forces use of a cast here.
Kind of makes it more fragile. Let's use a temporary instead?
> --
> 2.17.1
next prev parent reply other threads:[~2018-12-07 18:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 8:48 [virtio-dev] [RFC 0/3] virtio_ring: define flags as shifts consistently Tiwei Bie
2018-12-07 8:48 ` Tiwei Bie
2018-12-07 8:48 ` [RFC 1/3] " Tiwei Bie
2018-12-07 8:48 ` [virtio-dev] " Tiwei Bie
2018-12-07 8:48 ` Tiwei Bie
2018-12-07 8:48 ` [RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY Tiwei Bie
2018-12-07 8:48 ` [virtio-dev] " Tiwei Bie
2018-12-07 8:48 ` Tiwei Bie
2018-12-07 18:05 ` [virtio-dev] " Michael S. Tsirkin
2018-12-07 18:05 ` Michael S. Tsirkin
2018-12-08 13:33 ` Tiwei Bie
2018-12-08 13:33 ` [virtio-dev] " Tiwei Bie
2018-12-08 13:33 ` Tiwei Bie
2018-12-07 18:05 ` Michael S. Tsirkin
2018-12-07 8:48 ` [virtio-dev] [RFC 3/3] virtio_ring: use new vring flags Tiwei Bie
2018-12-07 8:48 ` Tiwei Bie
2018-12-07 18:10 ` Michael S. Tsirkin [this message]
2018-12-07 18:10 ` Michael S. Tsirkin
2018-12-08 13:47 ` [virtio-dev] " Tiwei Bie
2018-12-08 13:47 ` Tiwei Bie
2018-12-08 13:47 ` Tiwei Bie
2018-12-09 14:33 ` Michael S. Tsirkin
2018-12-09 14:33 ` [virtio-dev] " Michael S. Tsirkin
2018-12-09 14:33 ` Michael S. Tsirkin
2018-12-07 18:10 ` Michael S. Tsirkin
2018-12-07 8:48 ` Tiwei Bie
2018-12-07 18:11 ` [RFC 0/3] virtio_ring: define flags as shifts consistently Michael S. Tsirkin
2018-12-07 18:11 ` [virtio-dev] " Michael S. Tsirkin
2018-12-07 18:11 ` Michael S. Tsirkin
2018-12-08 13:26 ` Tiwei Bie
2018-12-08 13:26 ` [virtio-dev] " Tiwei Bie
2018-12-08 13:26 ` Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207130822-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=jasowang@redhat.com \
--cc=jfreimann@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.coquelin@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=tiwei.bie@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.