* [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected
@ 2018-12-07 13:13 Peter Korsgaard
2018-12-07 19:24 ` Peter Seiderer
2018-12-16 15:17 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-12-07 13:13 UTC (permalink / raw)
To: buildroot
The logic to ensure at least one compression backend is selected was not
updated when lz4, xz and zstd were introduced - Fix that.
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
package/squashfs/Config.in | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/package/squashfs/Config.in b/package/squashfs/Config.in
index c16ebbf27f..fdd8833060 100644
--- a/package/squashfs/Config.in
+++ b/package/squashfs/Config.in
@@ -2,7 +2,12 @@ config BR2_PACKAGE_SQUASHFS
bool "squashfs"
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_MMU # fork()
- select BR2_PACKAGE_SQUASHFS_GZIP if !(BR2_PACKAGE_SQUASHFS_LZMA || BR2_PACKAGE_SQUASHFS_LZO)
+ select BR2_PACKAGE_SQUASHFS_GZIP if !( \
+ BR2_PACKAGE_SQUASHFS_LZ4 || \
+ BR2_PACKAGE_SQUASHFS_LZMA || \
+ BR2_PACKAGE_SQUASHFS_LZO || \
+ BR2_PACKAGE_SQUASHFS_XZ || \
+ BR2_PACKAGE_SQUASHFS_ZSTD)
help
Tools to generate SquashFS filesystems.
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected
2018-12-07 13:13 [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected Peter Korsgaard
@ 2018-12-07 19:24 ` Peter Seiderer
2018-12-07 23:12 ` Peter Korsgaard
2018-12-16 15:17 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2018-12-07 19:24 UTC (permalink / raw)
To: buildroot
Hello Peter,
On Fri, 7 Dec 2018 14:13:55 +0100, Peter Korsgaard <peter@korsgaard.com> wrote:
> The logic to ensure at least one compression backend is selected was not
> updated when lz4, xz and zstd were introduced - Fix that.
>
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> ---
> package/squashfs/Config.in | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/squashfs/Config.in b/package/squashfs/Config.in
> index c16ebbf27f..fdd8833060 100644
> --- a/package/squashfs/Config.in
> +++ b/package/squashfs/Config.in
> @@ -2,7 +2,12 @@ config BR2_PACKAGE_SQUASHFS
> bool "squashfs"
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_USE_MMU # fork()
Nitpick: maybe a short comment here is helpful (I missed the line while
adding zstd support)?
# ensure at least on compression backend (defaults to gzip)
> - select BR2_PACKAGE_SQUASHFS_GZIP if !(BR2_PACKAGE_SQUASHFS_LZMA || BR2_PACKAGE_SQUASHFS_LZO)
> + select BR2_PACKAGE_SQUASHFS_GZIP if !( \
> + BR2_PACKAGE_SQUASHFS_LZ4 || \
> + BR2_PACKAGE_SQUASHFS_LZMA || \
> + BR2_PACKAGE_SQUASHFS_LZO || \
> + BR2_PACKAGE_SQUASHFS_XZ || \
> + BR2_PACKAGE_SQUASHFS_ZSTD)
> help
> Tools to generate SquashFS filesystems.
>
Reviewed-by: Peter Seiderer <ps.report@gmx.net>
Regards,
Peter
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected
2018-12-07 19:24 ` Peter Seiderer
@ 2018-12-07 23:12 ` Peter Korsgaard
0 siblings, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-12-07 23:12 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Seiderer <ps.report@gmx.net> writes:
> Hello Peter,
> On Fri, 7 Dec 2018 14:13:55 +0100, Peter Korsgaard <peter@korsgaard.com> wrote:
>> The logic to ensure at least one compression backend is selected was not
>> updated when lz4, xz and zstd were introduced - Fix that.
>>
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
>> ---
>> package/squashfs/Config.in | 7 ++++++-
>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>
>> diff --git a/package/squashfs/Config.in b/package/squashfs/Config.in
>> index c16ebbf27f..fdd8833060 100644
>> --- a/package/squashfs/Config.in
>> +++ b/package/squashfs/Config.in
>> @@ -2,7 +2,12 @@ config BR2_PACKAGE_SQUASHFS
>> bool "squashfs"
>> depends on BR2_TOOLCHAIN_HAS_THREADS
>> depends on BR2_USE_MMU # fork()
> Nitpick: maybe a short comment here is helpful (I missed the line while
> adding zstd support)?
> # ensure at least on compression backend (defaults to gzip)
Committed after adding this comment, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected
2018-12-07 13:13 [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected Peter Korsgaard
2018-12-07 19:24 ` Peter Seiderer
@ 2018-12-16 15:17 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2018-12-16 15:17 UTC (permalink / raw)
To: buildroot
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
> The logic to ensure at least one compression backend is selected was not
> updated when lz4, xz and zstd were introduced - Fix that.
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Committed to 2018.02.x, 2018.08.x and 2018.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-16 15:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-07 13:13 [Buildroot] [PATCH] squashfs: do not force gzip support if lz4/xz/zstd is selected Peter Korsgaard
2018-12-07 19:24 ` Peter Seiderer
2018-12-07 23:12 ` Peter Korsgaard
2018-12-16 15:17 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.