* [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8
@ 2018-12-08 21:52 Peter Korsgaard
2018-12-08 21:59 ` Yann E. MORIN
0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2018-12-08 21:52 UTC (permalink / raw)
To: buildroot
Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
---
configs/minnowboard_max-graphical_defconfig | 4 ++--
configs/minnowboard_max_defconfig | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/configs/minnowboard_max-graphical_defconfig b/configs/minnowboard_max-graphical_defconfig
index f05e791a65..921dae310f 100644
--- a/configs/minnowboard_max-graphical_defconfig
+++ b/configs/minnowboard_max-graphical_defconfig
@@ -3,7 +3,7 @@ BR2_x86_64=y
BR2_x86_silvermont=y
# Toolchain
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
BR2_TOOLCHAIN_BUILDROOT_LOCALE=y
BR2_TOOLCHAIN_BUILDROOT_CXX=y
# needed for TARGET_GRUB2
@@ -23,7 +23,7 @@ BR2_PACKAGE_HOST_MTOOLS=y
# Linux
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8"
BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
diff --git a/configs/minnowboard_max_defconfig b/configs/minnowboard_max_defconfig
index 9495bf3769..523ddffd51 100644
--- a/configs/minnowboard_max_defconfig
+++ b/configs/minnowboard_max_defconfig
@@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0"
BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh"
BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh"
-# Linux headers same as kernel, a 4.14 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
+# Linux headers same as kernel, a 4.19 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
# Needed for grub2
BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -23,7 +23,7 @@ BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169=y
# Linux kernel
BR2_LINUX_KERNEL=y
BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8"
BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8
2018-12-08 21:52 [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8 Peter Korsgaard
@ 2018-12-08 21:59 ` Yann E. MORIN
2018-12-08 22:41 ` Peter Korsgaard
0 siblings, 1 reply; 3+ messages in thread
From: Yann E. MORIN @ 2018-12-08 21:59 UTC (permalink / raw)
To: buildroot
Peter, All,
On 2018-12-08 22:52 +0100, Peter Korsgaard spake thusly:
> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
However, I have a very minor comment, see below...
[--SNIP--]
> diff --git a/configs/minnowboard_max_defconfig b/configs/minnowboard_max_defconfig
> index 9495bf3769..523ddffd51 100644
> --- a/configs/minnowboard_max_defconfig
> +++ b/configs/minnowboard_max_defconfig
> @@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0"
> BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh"
> BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh"
>
> -# Linux headers same as kernel, a 4.14 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
> +# Linux headers same as kernel, a 4.19 series
Do we really need that comment? It is interesting for defconfigs that
use a sha1 from a git tree, for which it is impossible to quickly
identify the kernel version, but here, the kernel version is
human-readable, so we don;t really care about the comment, do we?
Regards,
Yann E. MORIN.
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> # Needed for grub2
> BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
>
> @@ -23,7 +23,7 @@ BR2_PACKAGE_LINUX_FIRMWARE_RTL_8169=y
> # Linux kernel
> BR2_LINUX_KERNEL=y
> BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.14.13"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.8"
> BR2_LINUX_KERNEL_USE_CUSTOM_CONFIG=y
> BR2_LINUX_KERNEL_CUSTOM_CONFIG_FILE="board/minnowboard/linux.config"
>
> --
> 2.11.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8
2018-12-08 21:59 ` Yann E. MORIN
@ 2018-12-08 22:41 ` Peter Korsgaard
0 siblings, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2018-12-08 22:41 UTC (permalink / raw)
To: buildroot
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> Peter, All,
> On 2018-12-08 22:52 +0100, Peter Korsgaard spake thusly:
>> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>
> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> However, I have a very minor comment, see below...
> [--SNIP--]
>> diff --git a/configs/minnowboard_max_defconfig b/configs/minnowboard_max_defconfig
>> index 9495bf3769..523ddffd51 100644
>> --- a/configs/minnowboard_max_defconfig
>> +++ b/configs/minnowboard_max_defconfig
>> @@ -7,8 +7,8 @@ BR2_SYSTEM_DHCP="eth0"
>> BR2_ROOTFS_POST_BUILD_SCRIPT="board/minnowboard/post-build.sh"
>> BR2_ROOTFS_POST_IMAGE_SCRIPT="board/minnowboard/post-image.sh"
>>
>> -# Linux headers same as kernel, a 4.14 series
>> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_14=y
>> +# Linux headers same as kernel, a 4.19 series
> Do we really need that comment? It is interesting for defconfigs that
> use a sha1 from a git tree, for which it is impossible to quickly
> identify the kernel version, but here, the kernel version is
> human-readable, so we don;t really care about the comment, do we?
I have no problem removing it, I just wanted to keep the diff to a
minimum.
We do have a number of other defconfigs with a similar line,
E.G. sheevaplug_defconfig, openblocks_a6_defconfig, .. - It probably
makes sense to remove them all in one go.
In the mean time I have committed this patch, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-08 22:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-08 21:52 [Buildroot] [PATCH] minnowboard-max: defconfigs: bump kernel to 4.19.8 Peter Korsgaard
2018-12-08 21:59 ` Yann E. MORIN
2018-12-08 22:41 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.