From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] linuxptp: fix build with kernel headers >= 4.19
Date: Sun, 9 Dec 2018 22:41:20 +0100 [thread overview]
Message-ID: <20181209224120.54c35b43@windsurf> (raw)
In-Reply-To: <n87bm676vhs.fsf@tkos.co.il>
Hello,
On Fri, 30 Nov 2018 06:26:55 +0200, Baruch Siach wrote:
> [ Resending with the updated address of Richard ]
>
> Adding Richard Cochran who introduced this net_tstamp.h change in kernel
> commit 80b14dee2be.
>
> Fabrice Fontaine writes:
> > clockid_t has been added in net_tstamp.h since kernel 4.19 and
> > https://github.com/torvalds/linux/commit/80b14dee2bea128928537d61c333f24cb8cbb62f
> >
> > As a result, build fails on:
> > In file included from clock.c:20:
> > /home/peko/autobuild/instance-0/output/host/arc-buildroot-linux-uclibc/sysroot/usr/include/linux/net_tstamp.h:158:2: error: unknown type name 'clockid_t'
> > clockid_t clockid; /* reference clockid */
> >
> > To fix this error, add (or move) include on time.h before net_tstamp.h
> > in clock.c, sk.c and timemaster.c
>
> I think this is a bug in the net_tstamp.h header. UAPI headers should
> not reference userspace types. It should use __kernel_clockid_t instead.
>
> Richard, can you comment on that?
Any update on this? I agree with Baruch here, __kernel_clockid_t should
be used.
However, 4.19 is already released with this clockid_t reference, so I
guess we will anyway have to support that ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-12-09 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 21:47 [Buildroot] [PATCH/next 1/1] linuxptp: fix build with kernel headers >= 4.19 Fabrice Fontaine
2018-11-30 4:26 ` Baruch Siach
2018-11-30 4:26 ` Baruch Siach
2018-12-09 21:41 ` Thomas Petazzoni [this message]
2018-12-09 22:05 ` Baruch Siach
[not found] ` <20181210015934.ts3hvqehn2qvnlxj@localhost>
2018-12-10 7:51 ` Thomas Petazzoni
2018-12-31 16:13 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181209224120.54c35b43@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.