All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH/next 1/1] linuxptp: fix build with kernel headers >= 4.19
Date: Mon, 31 Dec 2018 17:13:56 +0100	[thread overview]
Message-ID: <20181231171356.49fb674d@windsurf> (raw)
In-Reply-To: <20181129214730.7225-1-fontaine.fabrice@gmail.com>

Hello,

On Thu, 29 Nov 2018 22:47:30 +0100, Fabrice Fontaine wrote:
> clockid_t has been added in net_tstamp.h since kernel 4.19 and
> https://github.com/torvalds/linux/commit/80b14dee2bea128928537d61c333f24cb8cbb62f
> 
> As a result, build fails on:
> In file included from clock.c:20:
> /home/peko/autobuild/instance-0/output/host/arc-buildroot-linux-uclibc/sysroot/usr/include/linux/net_tstamp.h:158:2: error: unknown type name 'clockid_t'
>   clockid_t clockid; /* reference clockid */
> 
> To fix this error, add (or move) include on time.h before net_tstamp.h
> in clock.c, sk.c and timemaster.c
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/4f53c0b6f3395f4d1ec0aa58f9df36c8145b1066
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

The issue has been fixed in the upstream Linux kernel:

  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/include/uapi/linux/net_tstamp.h?id=e2c4cf7f98a519eb4d95532bfa06bcaf3562fed5

This commit is part of Linux 4.20. It has a "Fixes" tag, so it should
normally be backported to Linux 4.19 at some point, even though this
hasn't happened yet.

So instead of doing a work around in linuxptp, we'll use the upstream
Linux kernel fix.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      parent reply	other threads:[~2018-12-31 16:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-29 21:47 [Buildroot] [PATCH/next 1/1] linuxptp: fix build with kernel headers >= 4.19 Fabrice Fontaine
2018-11-30  4:26 ` Baruch Siach
2018-12-09 21:41   ` Thomas Petazzoni
2018-12-09 22:05     ` Baruch Siach
     [not found]     ` <20181210015934.ts3hvqehn2qvnlxj@localhost>
2018-12-10  7:51       ` Thomas Petazzoni
2018-11-30  4:26 ` Baruch Siach
2018-12-31 16:13 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181231171356.49fb674d@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.