From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com, dev@dpdk.org
Subject: Re: [PATCH] ethdev: support double precision RED queue weight
Date: Mon, 10 Dec 2018 07:57:11 -0800 [thread overview]
Message-ID: <20181210075711.1befe533@xeon-e3> (raw)
In-Reply-To: <1543470882-145287-1-git-send-email-nikhil.rao@intel.com>
On Thu, 29 Nov 2018 11:24:42 +0530
Nikhil Rao <nikhil.rao@intel.com> wrote:
>
> + /** Double precision RED queue weight support. When non-zero, this
> + * this parameter indicates that RED queue weight in double precision
> + * format is supported.
> + * @see struct rte_tm_red_params::wq_is_log2
> + * @see struct rte_tm_red_params::wq_dp
> + */
> + int cman_wred_wq_dp_supported;
> +
> + /** Negated log2 RED queue weight support. When non-zero, this
> + * parameter indicates that RED queue weight in negated log2 format
> + * is supported.
> + * @see struct rte_tm_red_params::wq_is_log2
> + * @see struct rte_tm_red_params::wq_log2
> + */
> + int cman_wred_wq_log2_supported;
> +
One suggestion:
Since these are flag values use u8. Takes less space.
And maybe use pahole utility to find existing hole to put
them in.
next prev parent reply other threads:[~2018-12-10 15:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 5:54 [PATCH] ethdev: support double precision RED queue weight Nikhil Rao
2018-11-29 6:12 ` Stephen Hemminger
2018-12-10 5:43 ` Rao, Nikhil
2018-12-10 16:01 ` Stephen Hemminger
2019-01-10 6:23 ` Rao, Nikhil
2018-12-10 15:57 ` Stephen Hemminger [this message]
2019-01-07 16:39 ` Dumitrescu, Cristian
2019-01-10 16:35 ` [PATCH v2] " Nikhil Rao
2019-03-29 20:16 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210075711.1befe533@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.