From: Stephen Hemminger <stephen@networkplumber.org>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] ethdev: support double precision RED queue weight
Date: Mon, 10 Dec 2018 08:01:09 -0800 [thread overview]
Message-ID: <20181210080109.617902f1@xeon-e3> (raw)
In-Reply-To: <1F668163772FA946975B9466A9DFF729ED3AF9EF@ORSMSX110.amr.corp.intel.com>
On Mon, 10 Dec 2018 05:43:37 +0000
"Rao, Nikhil" <nikhil.rao@intel.com> wrote:
> > -----Original Message-----
> > From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> > Sent: Thursday, November 29, 2018 11:43 AM
> > To: Rao, Nikhil <nikhil.rao@intel.com>
> > Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Singh, Jasvinder
> > <jasvinder.singh@intel.com>; dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH] ethdev: support double precision RED queue
> > weight
> >
> > On Thu, 29 Nov 2018 11:24:42 +0530
> > Nikhil Rao <nikhil.rao@intel.com> wrote:
> >
> > > RED queue weight is currently specified as a negated log of 2.
> > >
> > > Add support for RED queue weight to be specified in double precision
> > > and TM capability flags for double precision and negated log2 RED
> > > queue weight support.
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> >
> > Since this is an ABI break anyway, why not just commit to the new format?
>
> Hi Stephen,
>
> Can you please provide more detail on your comment ? are you suggesting replacing the wq_log2/wq_dp with a double ?
>
> Thanks,
> Nikhil
My comment is that since you are changing a structure layout, which would
break existing users; why not go farther and just fix the API to a better
version. I don't think any projects use this code anyway,
see my talk (https://github.com/shemminger/dpdk-metrics).
Isn't floating point going to be expensive. Or is it only during the setup
process, not enqueue/dequeue.
next prev parent reply other threads:[~2018-12-10 16:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 5:54 [PATCH] ethdev: support double precision RED queue weight Nikhil Rao
2018-11-29 6:12 ` Stephen Hemminger
2018-12-10 5:43 ` Rao, Nikhil
2018-12-10 16:01 ` Stephen Hemminger [this message]
2019-01-10 6:23 ` Rao, Nikhil
2018-12-10 15:57 ` Stephen Hemminger
2019-01-07 16:39 ` Dumitrescu, Cristian
2019-01-10 16:35 ` [PATCH v2] " Nikhil Rao
2019-03-29 20:16 ` Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210080109.617902f1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.