All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [RESEND PATCH v3 1/3] Don't enable CONFIG_SPL_DM_USB for non-DM SPL
@ 2018-12-10 11:05 Martyn Welch
  2018-12-10 11:05 ` [U-Boot] [RESEND PATCH v3 2/3] Enable FEC driver to retrieve PHY address from device tree Martyn Welch
                   ` (3 more replies)
  0 siblings, 4 replies; 9+ messages in thread
From: Martyn Welch @ 2018-12-10 11:05 UTC (permalink / raw)
  To: u-boot

When CONFIG_SPL_DM_USB was added, it was added defaulted on without
protection to ensure it didn't get set for non-DM SPL builds.

This leads to unexpected and confusing failures when building a DM based
U-Boot but with a non-DM SPL, as the defconfig is unlikely to have
CONFIG_SPL_DM_USB actively disabled.

Tweak the Kconfig to not enable this setting unless CONFIG_SPL_DM is set.

Signed-off-by: Martyn Welch <martyn.welch@collabora.com>

---

Changes in v3:
- New in v3

Changes in v2: None

 drivers/usb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig
index d456beb43f..3c978d43aa 100644
--- a/drivers/usb/Kconfig
+++ b/drivers/usb/Kconfig
@@ -49,7 +49,7 @@ config DM_USB
 
 config SPL_DM_USB
 	bool "Enable driver model for USB in SPL"
-	depends on DM_USB
+	depends on SPL_DM && DM_USB
 	default y
 
 source "drivers/usb/host/Kconfig"
-- 
2.19.2

^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-12-10 14:11 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-10 11:05 [U-Boot] [RESEND PATCH v3 1/3] Don't enable CONFIG_SPL_DM_USB for non-DM SPL Martyn Welch
2018-12-10 11:05 ` [U-Boot] [RESEND PATCH v3 2/3] Enable FEC driver to retrieve PHY address from device tree Martyn Welch
2018-12-10 11:05 ` [U-Boot] [RESEND PATCH v3 3/3] imx: Add PHYTEC phyBOARD-i.MX6UL-Segin Martyn Welch
2018-12-10 11:49   ` Lukasz Majewski
2018-12-10 12:18     ` Martyn Welch
2018-12-10 11:52 ` [U-Boot] [RESEND PATCH v3 1/3] Don't enable CONFIG_SPL_DM_USB for non-DM SPL Jean-Jacques Hiblot
2018-12-10 12:07 ` Marek Vasut
2018-12-10 13:53   ` Martyn Welch
2018-12-10 14:11     ` Marek Vasut

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.