From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stefan Wahren <stefan.wahren@i2se.com>,
devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tara Null <tn@fastmail.net>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: vchiq: rework remove_event handling
Date: Tue, 11 Dec 2018 13:07:28 +0300 [thread overview]
Message-ID: <20181211100728.GC3116@kadam> (raw)
In-Reply-To: <20181210211231.4084251-1-arnd@arndb.de>
On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> Note that I'm changing it back to 'killable' after the previous patch
> changed 'killable' to 'interruptible', apparently based on a misunderstanding
> of the subtle down_interruptible() macro override in vchiq_killable.h.
Oh wow... The non standard down_interruptible() macro is ugly.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, Tara Null <tn@fastmail.net>,
linux-kernel@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] staging: vchiq: rework remove_event handling
Date: Tue, 11 Dec 2018 13:07:28 +0300 [thread overview]
Message-ID: <20181211100728.GC3116@kadam> (raw)
In-Reply-To: <20181210211231.4084251-1-arnd@arndb.de>
On Mon, Dec 10, 2018 at 10:11:58PM +0100, Arnd Bergmann wrote:
> Note that I'm changing it back to 'killable' after the previous patch
> changed 'killable' to 'interruptible', apparently based on a misunderstanding
> of the subtle down_interruptible() macro override in vchiq_killable.h.
Oh wow... The non standard down_interruptible() macro is ugly.
regards,
dan carpenter
next prev parent reply other threads:[~2018-12-11 10:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 21:11 [PATCH] staging: vchiq: rework remove_event handling Arnd Bergmann
2018-12-10 21:11 ` Arnd Bergmann
2018-12-11 10:07 ` Dan Carpenter [this message]
2018-12-11 10:07 ` Dan Carpenter
2018-12-11 12:30 ` Nicolas Saenz Julienne
2018-12-11 12:30 ` Nicolas Saenz Julienne
2018-12-11 14:18 ` Arnd Bergmann
2018-12-11 14:18 ` Arnd Bergmann
2018-12-11 12:36 ` Nicolas Saenz Julienne
2018-12-11 12:36 ` Nicolas Saenz Julienne
2018-12-11 14:20 ` Arnd Bergmann
2018-12-11 14:20 ` Arnd Bergmann
2018-12-12 16:24 ` Nicolas Saenz Julienne
2018-12-12 16:24 ` Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211100728.GC3116@kadam \
--to=dan.carpenter@oracle.com \
--cc=arnd@arndb.de \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=stefan.wahren@i2se.com \
--cc=tn@fastmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.