All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: emil.fsw@goode.io, Mikko Perttunen <cyndis@kapsi.fi>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT"
	<linux-tegra@vger.kernel.org>, Dmitry Osipenko <digetx@gmail.com>
Subject: Re: [PATCH] host1x: cdma: use completion instead of semaphore
Date: Tue, 11 Dec 2018 11:27:10 +0100	[thread overview]
Message-ID: <20181211102710.GH14426@ulmo> (raw)
In-Reply-To: <CAK8P3a08VEReXUZ39f3iQS3wUZSwKYObnn-jQrUiMJ4Gyx6hVQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 943 bytes --]

On Tue, Dec 11, 2018 at 11:11:38AM +0100, Arnd Bergmann wrote:
> On Tue, Dec 11, 2018 at 11:08 AM Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > On Mon, Dec 10, 2018 at 10:51:04PM +0100, Arnd Bergmann wrote:
> > > In this usage, the two are completely equivalent, but the
> > > completion documents better what is going on, and we generally
> > > try to avoid semaphores these days.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >  drivers/gpu/host1x/cdma.c | 6 +++---
> > >  drivers/gpu/host1x/cdma.h | 4 ++--
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > My understanding is that potentially many userspace processes could be
> > blocking on this, which I think is the reason for it being a semaphore.
> > Is the completion going to work for those cases as well?
> 
> Yes, it behaves the exact same way here.

Great, I'll queue this for v4.22.

Thanks,
Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mikko Perttunen <cyndis@kapsi.fi>,
	Dmitry Osipenko <digetx@gmail.com>,
	emil.fsw@goode.io, dri-devel <dri-devel@lists.freedesktop.org>,
	"open list:TEGRA ARCHITECTURE SUPPORT"
	<linux-tegra@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] host1x: cdma: use completion instead of semaphore
Date: Tue, 11 Dec 2018 11:27:10 +0100	[thread overview]
Message-ID: <20181211102710.GH14426@ulmo> (raw)
In-Reply-To: <CAK8P3a08VEReXUZ39f3iQS3wUZSwKYObnn-jQrUiMJ4Gyx6hVQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 943 bytes --]

On Tue, Dec 11, 2018 at 11:11:38AM +0100, Arnd Bergmann wrote:
> On Tue, Dec 11, 2018 at 11:08 AM Thierry Reding
> <thierry.reding@gmail.com> wrote:
> >
> > On Mon, Dec 10, 2018 at 10:51:04PM +0100, Arnd Bergmann wrote:
> > > In this usage, the two are completely equivalent, but the
> > > completion documents better what is going on, and we generally
> > > try to avoid semaphores these days.
> > >
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > ---
> > >  drivers/gpu/host1x/cdma.c | 6 +++---
> > >  drivers/gpu/host1x/cdma.h | 4 ++--
> > >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > My understanding is that potentially many userspace processes could be
> > blocking on this, which I think is the reason for it being a semaphore.
> > Is the completion going to work for those cases as well?
> 
> Yes, it behaves the exact same way here.

Great, I'll queue this for v4.22.

Thanks,
Thierry

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2018-12-11 10:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-10 21:51 [PATCH] host1x: cdma: use completion instead of semaphore Arnd Bergmann
2018-12-11 10:08 ` Thierry Reding
2018-12-11 10:11   ` Arnd Bergmann
2018-12-11 10:27     ` Thierry Reding [this message]
2018-12-11 10:27       ` Thierry Reding
2019-02-01 14:16 ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211102710.GH14426@ulmo \
    --to=thierry.reding@gmail.com \
    --cc=arnd@arndb.de \
    --cc=cyndis@kapsi.fi \
    --cc=digetx@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.fsw@goode.io \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.