All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Chandan Rajendra <chandan@linux.vnet.ibm.com>,
	Theodore Ts'o <tytso@mit.edu>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <yuchao0@huawei.com>,
	linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fscrypt@vger.kernel.org
Subject: Re: [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"
Date: Tue, 11 Dec 2018 09:41:17 -0800	[thread overview]
Message-ID: <20181211174116.GB221175@gmail.com> (raw)
In-Reply-To: <CAJKOXPdNS+Qs6t1GwrgYhWT5EbtORJwYMzSrDPf8oAxv7ndNBg@mail.gmail.com>

On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date:   Sat Dec 8 12:21:43 2018 +0530
>     fsverity: Move verity status check to fsverity_file_open
> 
> as a reason of "Operation not supported" when reading any file from
> mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> from /home with ext4fs fails.
> 
> Mounts:
> 192.168.1.10:/srv/nfs/odroidhc1 on / type nfs4
> (rw,relatime,vers=4.0,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.12,local_lock=none,addr=192.168.1.10)
> /dev/mmcblk0p2 on /home type ext4 (rw,relatime)
> 
> Configuration:
> 1. Arch ARM Linux
> 2. exynos_defconfig
>   - All my Odroid boards (ARMv7, Exynos)
>     Systemd: v239, v238
> 3. All boards boot from TFTP with NFS root (NFSv4)
> No specific errors in boot log:
> https://krzk.eu/#/builders/21/builds/1034/steps/12/logs/serial0
> 
> Let me know if you need any more data.
> 
> Best regards,
> Krzysztof

Thanks Krzysztof.  Ted, this is the same bug I pointed out in my review of this
patch yesterday (https://patchwork.kernel.org/patch/10719197/#22371523).  Can
you fix or revert the two broken patches?  Thanks,

- Eric

WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net,
	linux-fscrypt@vger.kernel.org,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	Jaegeuk Kim <jaegeuk@kernel.org>,
	linux-ext4@vger.kernel.org
Subject: Re: [f2fs-dev] [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open"
Date: Tue, 11 Dec 2018 09:41:17 -0800	[thread overview]
Message-ID: <20181211174116.GB221175@gmail.com> (raw)
In-Reply-To: <CAJKOXPdNS+Qs6t1GwrgYhWT5EbtORJwYMzSrDPf8oAxv7ndNBg@mail.gmail.com>

On Tue, Dec 11, 2018 at 03:15:53PM +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> Bisect from today's next pointed me to:
> commit 4de97efb578a094e8fbf279522d41eb9ece1e3e0
> Author: Chandan Rajendra <chandan@linux.vnet.ibm.com>
> Date:   Sat Dec 8 12:21:43 2018 +0530
>     fsverity: Move verity status check to fsverity_file_open
> 
> as a reason of "Operation not supported" when reading any file from
> mounted ext4fs (from SD card). Rootfs from nfsroot works but reading
> from /home with ext4fs fails.
> 
> Mounts:
> 192.168.1.10:/srv/nfs/odroidhc1 on / type nfs4
> (rw,relatime,vers=4.0,rsize=131072,wsize=131072,namlen=255,hard,proto=tcp,timeo=600,retrans=2,sec=sys,clientaddr=192.168.1.12,local_lock=none,addr=192.168.1.10)
> /dev/mmcblk0p2 on /home type ext4 (rw,relatime)
> 
> Configuration:
> 1. Arch ARM Linux
> 2. exynos_defconfig
>   - All my Odroid boards (ARMv7, Exynos)
>     Systemd: v239, v238
> 3. All boards boot from TFTP with NFS root (NFSv4)
> No specific errors in boot log:
> https://krzk.eu/#/builders/21/builds/1034/steps/12/logs/serial0
> 
> Let me know if you need any more data.
> 
> Best regards,
> Krzysztof

Thanks Krzysztof.  Ted, this is the same bug I pointed out in my review of this
patch yesterday (https://patchwork.kernel.org/patch/10719197/#22371523).  Can
you fix or revert the two broken patches?  Thanks,

- Eric


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2018-12-11 17:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 14:15 [BUG BISECT next] Files cannot be opened after "fsverity: Move verity status check to fsverity_file_open" Krzysztof Kozlowski
2018-12-11 17:41 ` Eric Biggers [this message]
2018-12-11 17:41   ` [f2fs-dev] " Eric Biggers
2018-12-12  4:11   ` Chandan Rajendra
2018-12-11 22:27 ` Theodore Y. Ts'o
2018-12-11 22:36   ` Eric Biggers
2018-12-12  2:55   ` Theodore Y. Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181211174116.GB221175@gmail.com \
    --to=ebiggers@kernel.org \
    --cc=adilger.kernel@dilger.ca \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=jaegeuk@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-fscrypt@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=yuchao0@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.