From: David Gibson <david@gibson.dropbear.id.au>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: davem@davemloft.net, saeedm@mellanox.com, ogerlitz@mellanox.com,
tariqt@mellanox.com, leon@kernel.org,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
netdev@vger.kernel.org, alex.williamson@redhat.com,
linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org,
sbest@redhat.com, paulus@samba.org, benh@kernel.crashing.org
Subject: Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]
Date: Wed, 12 Dec 2018 11:22:34 +1100 [thread overview]
Message-ID: <20181212002234.GC2719@umbus.fritz.box> (raw)
In-Reply-To: <20181211140143.GD99796@google.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Tue, Dec 11, 2018 at 08:01:43AM -0600, Bjorn Helgaas wrote:
> Hi David,
>
> I see you're still working on this, but if you do end up going this
> direction eventually, would you mind splitting this into two patches:
> 1) rename the quirk to make it more generic (but not changing any
> behavior), and 2) add the ConnectX devices to the quirk. That way
> the ConnectX change is smaller and more easily
> understood/reverted/etc.
Sure. Would it make sense to send (1) as an independent cleanup,
while I'm still working out exactly what (if anything) we need for
(2)?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: David Gibson <david@gibson.dropbear.id.au>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
sbest@redhat.com, saeedm@mellanox.com,
alex.williamson@redhat.com, paulus@samba.org,
linux-pci@vger.kernel.org, ogerlitz@mellanox.com,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net,
tariqt@mellanox.com
Subject: Re: [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45]
Date: Wed, 12 Dec 2018 11:22:34 +1100 [thread overview]
Message-ID: <20181212002234.GC2719@umbus.fritz.box> (raw)
In-Reply-To: <20181211140143.GD99796@google.com>
[-- Attachment #1: Type: text/plain, Size: 781 bytes --]
On Tue, Dec 11, 2018 at 08:01:43AM -0600, Bjorn Helgaas wrote:
> Hi David,
>
> I see you're still working on this, but if you do end up going this
> direction eventually, would you mind splitting this into two patches:
> 1) rename the quirk to make it more generic (but not changing any
> behavior), and 2) add the ConnectX devices to the quirk. That way
> the ConnectX change is smaller and more easily
> understood/reverted/etc.
Sure. Would it make sense to send (1) as an independent cleanup,
while I'm still working out exactly what (if anything) we need for
(2)?
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-12 0:37 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 4:19 [PATCH] PCI: Add no-D3 quirk for Mellanox ConnectX-[45] David Gibson
2018-12-06 4:19 ` David Gibson
2018-12-06 6:45 ` Leon Romanovsky
2018-12-06 6:45 ` Leon Romanovsky
2018-12-11 2:31 ` David Gibson
2018-12-11 2:31 ` David Gibson
2019-01-04 3:44 ` David Gibson
2019-01-04 3:44 ` David Gibson
2019-01-05 17:51 ` Jason Gunthorpe
2019-01-05 17:51 ` Jason Gunthorpe
2019-01-05 22:43 ` Benjamin Herrenschmidt
2019-01-05 22:43 ` Benjamin Herrenschmidt
2019-01-08 4:01 ` Jason Gunthorpe
2019-01-08 4:01 ` Jason Gunthorpe
2019-01-08 6:07 ` Leon Romanovsky
2019-01-08 6:07 ` Leon Romanovsky
2019-01-09 5:09 ` Benjamin Herrenschmidt
2019-01-09 5:09 ` Benjamin Herrenschmidt
2019-01-09 5:30 ` David Gibson
2019-01-09 5:30 ` David Gibson
2019-01-09 6:32 ` Alexey Kardashevskiy
2019-01-09 6:32 ` Alexey Kardashevskiy
2019-01-09 7:25 ` Benjamin Herrenschmidt
2019-01-09 7:25 ` Benjamin Herrenschmidt
2019-01-09 8:14 ` Alexey Kardashevskiy
2019-01-09 8:14 ` Alexey Kardashevskiy
2019-01-09 15:27 ` Jason Gunthorpe
2019-01-09 15:27 ` Jason Gunthorpe
2019-01-09 15:27 ` Jason Gunthorpe
2019-01-09 4:53 ` Alexey Kardashevskiy
2019-01-09 7:24 ` Benjamin Herrenschmidt
2019-01-09 8:20 ` Alexey Kardashevskiy
2018-12-11 14:01 ` Bjorn Helgaas
2018-12-11 14:01 ` Bjorn Helgaas
2018-12-12 0:22 ` David Gibson [this message]
2018-12-12 0:22 ` David Gibson
2018-12-12 3:04 ` Bjorn Helgaas
2018-12-12 3:04 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212002234.GC2719@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=alex.williamson@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=helgaas@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=paulus@samba.org \
--cc=saeedm@mellanox.com \
--cc=sbest@redhat.com \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.