All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Remove set but not used variable 'upriv'
Date: Wed, 12 Dec 2018 15:10:12 +0000	[thread overview]
Message-ID: <20181212151012.GD3933@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1544603633-170212-1-git-send-email-yuehaibing@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Wed, Dec 12, 2018 at 08:33:53AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_load':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning:
>  variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_unload':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning:
>  variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit ef381359e3a8 ("net/mlx5e: Replace egdev with
> indirect block notifications"). Also remove unused variable 'uplink_rpriv'
> after this change.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ----------
>  1 file changed, 10 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Leon Romanovsky <leon@kernel.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Saeed Mahameed <saeedm@mellanox.com>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net/mlx5e: Remove set but not used variable 'upriv'
Date: Wed, 12 Dec 2018 17:10:12 +0200	[thread overview]
Message-ID: <20181212151012.GD3933@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1544603633-170212-1-git-send-email-yuehaibing@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Wed, Dec 12, 2018 at 08:33:53AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_load':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1490:21: warning:
>  variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c: In function 'mlx5e_vport_rep_unload':
> drivers/net/ethernet/mellanox/mlx5/core/en_rep.c:1557:21: warning:
>  variable 'upriv' set but not used [-Wunused-but-set-variable]
>
> It not used any more since commit ef381359e3a8 ("net/mlx5e: Replace egdev with
> indirect block notifications"). Also remove unused variable 'uplink_rpriv'
> after this change.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_rep.c | 10 ----------
>  1 file changed, 10 deletions(-)
>

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

  reply	other threads:[~2018-12-12 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  8:33 [PATCH net-next] net/mlx5e: Remove set but not used variable 'upriv' YueHaibing
2018-12-12  8:33 ` YueHaibing
2018-12-12 15:10 ` Leon Romanovsky [this message]
2018-12-12 15:10   ` Leon Romanovsky
2018-12-13  1:24   ` Saeed Mahameed
2018-12-13  1:24     ` Saeed Mahameed
2018-12-13  5:39     ` David Miller
2018-12-13  5:39       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212151012.GD3933@mtr-leonro.mtl.com \
    --to=leon@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=saeedm@mellanox.com \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.