All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Coresight ML <coresight@lists.linaro.org>,
	linux-kernel@vger.kernel.org,
	Arnaldo Carvalho de Melo <acme@kernel.org>,
	Namhyung Kim <namhyung@kernel.org>,
	Robert Walker <robert.walker@arm.com>,
	Jiri Olsa <jolsa@redhat.com>,
	linux-arm-kernel@lists.infradead.org,
	Mike Leach <mike.leach@linaro.org>
Subject: Re: [PATCH v3 3/8] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder
Date: Wed, 12 Dec 2018 11:41:05 -0700	[thread overview]
Message-ID: <20181212184105.GA24556@xps15> (raw)
In-Reply-To: <1544513908-16805-4-git-send-email-leo.yan@linaro.org>

On Tue, Dec 11, 2018 at 03:38:23PM +0800, Leo Yan wrote:
> cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC
> element is coming, but it is never used hence it is redundant and can
> be removed.
> 
> So let's remove 'trace_on' field from cs_etm_decoder struct.
> 
> Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Robert Walker <robert.walker@arm.com>
> ---
>  tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> index 0b4c862..97b39b1 100644
> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> @@ -36,7 +36,6 @@
>  struct cs_etm_decoder {
>  	void *data;
>  	void (*packet_printer)(const char *msg);
> -	bool trace_on;
>  	dcd_tree_handle_t dcd_tree;
>  	cs_etm_mem_cb_type mem_access;
>  	ocsd_datapath_resp_t prev_return;
> @@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
>  	case OCSD_GEN_TRC_ELEM_UNKNOWN:
>  		break;
>  	case OCSD_GEN_TRC_ELEM_NO_SYNC:
> -		decoder->trace_on = false;
>  		break;
>  	case OCSD_GEN_TRC_ELEM_TRACE_ON:
>  		resp = cs_etm_decoder__buffer_trace_on(decoder,
>  						       trace_chan_id);
> -		decoder->trace_on = true;
>  		break;
>  	case OCSD_GEN_TRC_ELEM_INSTR_RANGE:
>  		resp = cs_etm_decoder__buffer_range(decoder, elem,

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> -- 
> 2.7.4
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Coresight ML <coresight@lists.linaro.org>,
	Mike Leach <mike.leach@linaro.org>,
	Robert Walker <robert.walker@arm.com>
Subject: Re: [PATCH v3 3/8] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder
Date: Wed, 12 Dec 2018 11:41:05 -0700	[thread overview]
Message-ID: <20181212184105.GA24556@xps15> (raw)
In-Reply-To: <1544513908-16805-4-git-send-email-leo.yan@linaro.org>

On Tue, Dec 11, 2018 at 03:38:23PM +0800, Leo Yan wrote:
> cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC
> element is coming, but it is never used hence it is redundant and can
> be removed.
> 
> So let's remove 'trace_on' field from cs_etm_decoder struct.
> 
> Suggested-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Robert Walker <robert.walker@arm.com>
> ---
>  tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> index 0b4c862..97b39b1 100644
> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c
> @@ -36,7 +36,6 @@
>  struct cs_etm_decoder {
>  	void *data;
>  	void (*packet_printer)(const char *msg);
> -	bool trace_on;
>  	dcd_tree_handle_t dcd_tree;
>  	cs_etm_mem_cb_type mem_access;
>  	ocsd_datapath_resp_t prev_return;
> @@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer(
>  	case OCSD_GEN_TRC_ELEM_UNKNOWN:
>  		break;
>  	case OCSD_GEN_TRC_ELEM_NO_SYNC:
> -		decoder->trace_on = false;
>  		break;
>  	case OCSD_GEN_TRC_ELEM_TRACE_ON:
>  		resp = cs_etm_decoder__buffer_trace_on(decoder,
>  						       trace_chan_id);
> -		decoder->trace_on = true;
>  		break;
>  	case OCSD_GEN_TRC_ELEM_INSTR_RANGE:
>  		resp = cs_etm_decoder__buffer_range(decoder, elem,

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

> -- 
> 2.7.4
> 

  reply	other threads:[~2018-12-12 18:41 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11  7:38 [PATCH v3 0/8] perf cs-etm: Correct packets handling Leo Yan
2018-12-11  7:38 ` Leo Yan
2018-12-11  7:38 ` [PATCH v3 1/8] perf cs-etm: Correct packets swapping in cs_etm__flush() Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-20 18:12   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 2/8] perf cs-etm: Avoid stale branch samples when flush packet Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-20 18:12   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 3/8] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-12 18:41   ` Mathieu Poirier [this message]
2018-12-12 18:41     ` Mathieu Poirier
2018-12-20 18:13   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 4/8] perf cs-etm: Refactor enumeration cs_etm_sample_type Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-12 18:41   ` Mathieu Poirier
2018-12-12 18:41     ` Mathieu Poirier
2018-12-20 18:14   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 5/8] perf cs-etm: Rename CS_ETM_TRACE_ON to CS_ETM_DISCONTINUITY Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-20 18:14   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 6/8] perf cs-etm: Treat NO_SYNC element as trace discontinuity Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-13 12:38   ` Arnaldo Carvalho de Melo
2018-12-13 12:38     ` Arnaldo Carvalho de Melo
2018-12-13 12:41     ` Arnaldo Carvalho de Melo
2018-12-13 12:41       ` Arnaldo Carvalho de Melo
2018-12-13 13:09       ` leo.yan
2018-12-13 13:09         ` leo.yan
2018-12-13 13:21         ` Arnaldo Carvalho de Melo
2018-12-13 13:21           ` Arnaldo Carvalho de Melo
2018-12-13 13:23           ` leo.yan
2018-12-13 13:23             ` leo.yan
2018-12-13 13:26           ` Arnaldo Carvalho de Melo
2018-12-13 13:26             ` Arnaldo Carvalho de Melo
2018-12-13 13:31             ` leo.yan
2018-12-13 13:31               ` leo.yan
2018-12-20 18:15   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 7/8] perf cs-etm: Treat EO_TRACE " Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-20 18:15   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-11  7:38 ` [PATCH v3 8/8] perf cs-etm: Generate branch sample for exception packet Leo Yan
2018-12-11  7:38   ` Leo Yan
2018-12-20 18:16   ` [tip:perf/core] " tip-bot for Leo Yan
2018-12-12 18:45 ` [PATCH v3 0/8] perf cs-etm: Correct packets handling Mathieu Poirier
2018-12-12 18:45   ` Mathieu Poirier
2018-12-13 13:11   ` Arnaldo Carvalho de Melo
2018-12-13 13:11     ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212184105.GA24556@xps15 \
    --to=mathieu.poirier@linaro.org \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=coresight@lists.linaro.org \
    --cc=jolsa@redhat.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.leach@linaro.org \
    --cc=namhyung@kernel.org \
    --cc=robert.walker@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.