All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] ARM: omap2: fix lack of timer interrupts on CPU1 after hotplug
Date: Wed, 12 Dec 2018 10:57:41 -0800	[thread overview]
Message-ID: <20181212185741.GJ6707@atomide.com> (raw)
In-Reply-To: <20181212175332.GI6707@atomide.com>

* Tony Lindgren <tony@atomide.com> [181212 17:53]:
> * Russell King <rmk+kernel@armlinux.org.uk> [181212 11:49]:
> > We call tick_broadcast_enter() in omap_enter_idle_coupled(), which one
> > would expect would take care of the issue, but internally this only
> > deals with one-shot local timers - tick_broadcast_enable() on the other
> > hand only deals with periodic local timers.  So, we need to call both.
> 
> This works just fine for me for NO_HZ and cpuidle:
>
> Tested-by: Tony Lindgren <tony@atomide.com>

And also works for me without NO_HZ too FYI.

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Russell King <rmk+kernel@armlinux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH RFC] ARM: omap2: fix lack of timer interrupts on CPU1 after hotplug
Date: Wed, 12 Dec 2018 10:57:41 -0800	[thread overview]
Message-ID: <20181212185741.GJ6707@atomide.com> (raw)
In-Reply-To: <20181212175332.GI6707@atomide.com>

* Tony Lindgren <tony@atomide.com> [181212 17:53]:
> * Russell King <rmk+kernel@armlinux.org.uk> [181212 11:49]:
> > We call tick_broadcast_enter() in omap_enter_idle_coupled(), which one
> > would expect would take care of the issue, but internally this only
> > deals with one-shot local timers - tick_broadcast_enable() on the other
> > hand only deals with periodic local timers.  So, we need to call both.
> 
> This works just fine for me for NO_HZ and cpuidle:
>
> Tested-by: Tony Lindgren <tony@atomide.com>

And also works for me without NO_HZ too FYI.

Tony

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2018-12-12 18:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 11:49 [PATCH RFC] ARM: omap2: fix lack of timer interrupts on CPU1 after hotplug Russell King
2018-12-12 11:49 ` Russell King
2018-12-12 17:53 ` Tony Lindgren
2018-12-12 17:53   ` Tony Lindgren
2018-12-12 18:57   ` Tony Lindgren [this message]
2018-12-12 18:57     ` Tony Lindgren
2019-02-07 13:45     ` Russell King - ARM Linux admin
2019-02-07 13:45       ` Russell King - ARM Linux admin
2019-02-07 15:51       ` Tony Lindgren
2019-02-07 15:51         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181212185741.GJ6707@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.