[PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mimi Zohar <zohar@linux.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	David Howells <dhowells@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Jessica Yu <jeyu@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: [PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it
Date: Thu, 13 Dec 2018 02:09:00 +0000	[thread overview]
Message-ID: <20181213020907.13601-8-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20181213020907.13601-1-bauerman@linux.ibm.com>

This avoids a dependency cycle in soon-to-be-introduced
CONFIG_IMA_APPRAISE_MODSIG: it will select CONFIG_MODULE_SIG_FORMAT
which in turn selects CONFIG_KEYS. Kconfig then complains that
CONFIG_INTEGRITY_SIGNATURE depends on CONFIG_KEYS.

Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
---
 security/integrity/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 4b4d2aeef539..176905bef20a 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -17,8 +17,8 @@ if INTEGRITY
 
 config INTEGRITY_SIGNATURE
 	bool "Digital signature verification using multiple keyrings"
-	depends on KEYS
 	default n
+	select KEYS
 	select SIGNATURE
 	help
 	  This option enables digital signature verification support

WARNING: multiple messages have this Message-ID (diff)

From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-crypto@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mimi Zohar <zohar@linux.ibm.com>,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	David Howells <dhowells@redhat.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Jessica Yu <jeyu@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: [PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it
Date: Thu, 13 Dec 2018 00:09:00 -0200	[thread overview]
Message-ID: <20181213020907.13601-8-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20181213020907.13601-1-bauerman@linux.ibm.com>

This avoids a dependency cycle in soon-to-be-introduced
CONFIG_IMA_APPRAISE_MODSIG: it will select CONFIG_MODULE_SIG_FORMAT
which in turn selects CONFIG_KEYS. Kconfig then complains that
CONFIG_INTEGRITY_SIGNATURE depends on CONFIG_KEYS.

Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
---
 security/integrity/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 4b4d2aeef539..176905bef20a 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -17,8 +17,8 @@ if INTEGRITY
 
 config INTEGRITY_SIGNATURE
 	bool "Digital signature verification using multiple keyrings"
-	depends on KEYS
 	default n
+	select KEYS
 	select SIGNATURE
 	help
 	  This option enables digital signature verification support

WARNING: multiple messages have this Message-ID (diff)

From: Thiago Jung Bauermann <bauerman@linux.ibm.com>
To: linux-integrity@vger.kernel.org
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	linux-doc@vger.kernel.org,
	Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-kernel@vger.kernel.org, Mimi Zohar <zohar@linux.ibm.com>,
	James Morris <jmorris@namei.org>,
	David Howells <dhowells@redhat.com>,
	"AKASHI, Takahiro" <takahiro.akashi@linaro.org>,
	linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
	linux-crypto@vger.kernel.org, Jessica Yu <jeyu@kernel.org>,
	linuxppc-dev@lists.ozlabs.org,
	David Woodhouse <dwmw2@infradead.org>,
	Thiago Jung Bauermann <bauerman@linux.ibm.com>,
	"Serge E. Hallyn" <serge@hallyn.com>
Subject: [PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it
Date: Thu, 13 Dec 2018 00:09:00 -0200	[thread overview]
Message-ID: <20181213020907.13601-8-bauerman@linux.ibm.com> (raw)
In-Reply-To: <20181213020907.13601-1-bauerman@linux.ibm.com>

This avoids a dependency cycle in soon-to-be-introduced
CONFIG_IMA_APPRAISE_MODSIG: it will select CONFIG_MODULE_SIG_FORMAT
which in turn selects CONFIG_KEYS. Kconfig then complains that
CONFIG_INTEGRITY_SIGNATURE depends on CONFIG_KEYS.

Signed-off-by: Thiago Jung Bauermann <bauerman@linux.ibm.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
---
 security/integrity/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/security/integrity/Kconfig b/security/integrity/Kconfig
index 4b4d2aeef539..176905bef20a 100644
--- a/security/integrity/Kconfig
+++ b/security/integrity/Kconfig
@@ -17,8 +17,8 @@ if INTEGRITY
 
 config INTEGRITY_SIGNATURE
 	bool "Digital signature verification using multiple keyrings"
-	depends on KEYS
 	default n
+	select KEYS
 	select SIGNATURE
 	help
 	  This option enables digital signature verification support

next prev parent reply	other threads:[~2018-12-13  2:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  2:08 [PATCH v9 00/14] Appended signatures support for IMA appraisal Thiago Jung Bauermann
2018-12-13  2:08 ` Thiago Jung Bauermann
2018-12-13  2:08 ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 01/14] MODSIGN: Export module signature definitions Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 02/14] PKCS#7: Refactor verify_pkcs7_signature() and add pkcs7_get_message_sig() Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 03/14] PKCS#7: Introduce pkcs7_get_digest() Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 04/14] integrity: Introduce struct evm_xattr Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 05/14] integrity: Introduce integrity_keyring_from_id() Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08 ` [PATCH v9 06/14] integrity: Introduce asymmetric_sig_has_known_key() Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:08   ` Thiago Jung Bauermann
2018-12-13  2:09 ` Thiago Jung Bauermann [this message]
2018-12-13  2:09   ` [PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 08/14] ima: Introduce is_signed() Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 09/14] ima: Export func_tokens Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 10/14] ima: Add modsig appraise_type option for module-style appended signatures Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 11/14] ima: Implement support " Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 12/14] ima: Add new "d-sig" template field Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 13/14] ima: Write modsig to the measurement list Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09 ` [PATCH v9 14/14] ima: Store the measurement again when appraising a modsig Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann
2018-12-13  2:09   ` Thiago Jung Bauermann

find likely ancestor, descendant, or conflicting patches for this message:
( dfblob:4b4d2aeef53 dfblob:176905bef20 dfblob:4b4d2aeef53
dfblob:176905bef20 dfblob:4b4d2aeef53 dfblob:176905bef20 )
 OR (
bs:"[PATCH v9 07/14] integrity: Select CONFIG_KEYS instead of depending on it" )
	(help)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213020907.13601-8-bauerman@linux.ibm.com \
    --to=bauerman@linux.ibm.com \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jeyu@kernel.org \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=serge@hallyn.com \
    --cc=takahiro.akashi@linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.