All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step
Date: Wed, 12 Dec 2018 19:37:50 -0800	[thread overview]
Message-ID: <20181213033750.GK39861@atomide.com> (raw)
In-Reply-To: <20181213030219.GJ39861@atomide.com>

* Tony Lindgren <tony@atomide.com> [181212 19:02]:
> Getting closer.. The DAI instances get mapped the wrong
> way around for me:

So I added reg properties to the cpcap codec end too and now I get the
mapping set right:

asoc-audio-graph-card soundcard: cpcap-hifi <-> 40124000.mcbsp mapping ok
asoc-audio-graph-card soundcard: cpcap-voice <-> 40126000.mcbsp-dai0 mapping ok
asoc-audio-graph-card soundcard: mdm-call <-> 40126000.mcbsp-dai1 mapping ok

Hmm I wonder if this will now need all the dts files updated for codecs
with multiple DAIs?

Also audio play does not work for me with these changes  it seems.. My
updated codec end snippet below.

Regards,

Tony

8< -----------------
	cpcap_audio: audio-codec {
		#sound-dai-cells = <1>;
		#address-cells = <1>;
		#size-cells = <0>;

		port@0 {
			reg = <0>;
			cpcap_audio_codec0: endpoint {
			};
		};
		port@1 {
			reg = <1>;
			cpcap_audio_codec1: endpoint {
			};
		};
	};
> 8< ---------------
> &mcbsp2 {
> 	...
>         ports {
>                 #address-cells = <1>;
>                 #size-cells = <0>;
> 
>                 mcbsp2_port: port@0 {
>                         reg = <0>;
>                         cpu_dai2: endpoint@0 {
>                                 dai-format = "i2s";
>                                 remote-endpoint = <&cpcap_audio_codec0>;
>                                 frame-master = <&cpcap_audio_codec0>;
>                                 bitclock-master = <&cpcap_audio_codec0>;
>                         };
>                 };
>         };
> };
> 
> &mcbsp3 {
> 	...
> 	ports {
> 		mcbsp3_port: port@0 {
> 			#address-cells = <1>;
> 			#size-cells = <0>;
> 
> 			cpu_dai3: endpoint@0 {
> 				reg = <0>;
> 				dai-format = "dsp_a";
> 				frame-master = <&cpcap_audio_codec1>;
> 				bitclock-master = <&cpcap_audio_codec1>;
> 				remote-endpoint = <&cpcap_audio_codec1>;
> 			};
> 			cpu_dai_mdm: endpoint@1 {
> 				reg = <1>;
> 				dai-format = "dsp_a";
> 				frame-master = <&cpcap_audio_codec1>;
> 				bitclock-master = <&cpcap_audio_codec1>;
> 				remote-endpoint = <&mot_mdm6600_audio_codec0>;
> 			};
> 		};
> 	};
> };

  parent reply	other threads:[~2018-12-13  3:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13  1:35 [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step Kuninori Morimoto
2018-12-13  1:35 ` [PATCH 1/7 v2] ASoC: simple-card-utils: care endpoint reg for asoc_simple_card_get_dai_id() Kuninori Morimoto
2018-12-13 16:06   ` Tony Lindgren
2018-12-13  1:35 ` [PATCH 2/7 v2] ASoC: audio-graph-card: merge audio-graph-scu-card on Doc Kuninori Morimoto
2018-12-13  1:35 ` [PATCH 3/7 v2] ASoC: audio-graph-card: merge audio-graph-scu-card Kuninori Morimoto
2018-12-13 16:06   ` Tony Lindgren
2018-12-13  1:36 ` [PATCH 4/7 v2] ASoC: audio-graph-card: tidyup mclk-fs method Kuninori Morimoto
2018-12-13  1:36 ` [PATCH 5/7 v2] ASoC: audio-graph-card: tidyup convert_rate/channel method Kuninori Morimoto
2018-12-13  1:36 ` [PATCH 6/7 v2] ASoC: audio-graph-scu-card: remove audio-graph-scu-card on Doc Kuninori Morimoto
2018-12-13  1:36 ` [PATCH 7/7 v2] ASoC: audio-graph-scu-card: remove audio-graph-scu-card Kuninori Morimoto
2018-12-13  3:02 ` [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step Tony Lindgren
2018-12-13  3:24   ` Kuninori Morimoto
2018-12-13  3:37   ` Tony Lindgren [this message]
2018-12-13  3:45     ` Kuninori Morimoto
2018-12-13  4:34       ` Tony Lindgren
2018-12-13 15:20         ` Mark Brown
2018-12-13 16:05         ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181213033750.GK39861@atomide.com \
    --to=tony@atomide.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.