From: Tony Lindgren <tony@atomide.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step
Date: Wed, 12 Dec 2018 20:34:45 -0800 [thread overview]
Message-ID: <20181213043445.GL39861@atomide.com> (raw)
In-Reply-To: <87zhta14la.wl-kuninori.morimoto.gx@renesas.com>
* Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> [181213 03:45]:
> But.. Hmm...
> to keep compatibility, use previous style, make sense ?
>
> if (endpoint had reg)
> use it
> else if (port had reg)
> use it
> else
> use endpoint count
I guess it that works and is easy to add :) Maybe warn about needing to
add a reg property too?
> > Also audio play does not work for me with these changes it seems.. My
> > updated codec end snippet below.
>
> Hmm...
No idea why audio no longer works.. It's like clocks suddenly don't work
or as if something was still mapped to a wrong codec.
Regards,
Tony
next prev parent reply other threads:[~2018-12-13 4:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 1:35 [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step Kuninori Morimoto
2018-12-13 1:35 ` [PATCH 1/7 v2] ASoC: simple-card-utils: care endpoint reg for asoc_simple_card_get_dai_id() Kuninori Morimoto
2018-12-13 16:06 ` Tony Lindgren
2018-12-13 1:35 ` [PATCH 2/7 v2] ASoC: audio-graph-card: merge audio-graph-scu-card on Doc Kuninori Morimoto
2018-12-13 1:35 ` [PATCH 3/7 v2] ASoC: audio-graph-card: merge audio-graph-scu-card Kuninori Morimoto
2018-12-13 16:06 ` Tony Lindgren
2018-12-13 1:36 ` [PATCH 4/7 v2] ASoC: audio-graph-card: tidyup mclk-fs method Kuninori Morimoto
2018-12-13 1:36 ` [PATCH 5/7 v2] ASoC: audio-graph-card: tidyup convert_rate/channel method Kuninori Morimoto
2018-12-13 1:36 ` [PATCH 6/7 v2] ASoC: audio-graph-scu-card: remove audio-graph-scu-card on Doc Kuninori Morimoto
2018-12-13 1:36 ` [PATCH 7/7 v2] ASoC: audio-graph-scu-card: remove audio-graph-scu-card Kuninori Morimoto
2018-12-13 3:02 ` [PATCH 0/7 v2] ASoC: merge audio-graph-scu into audio-graph - final step Tony Lindgren
2018-12-13 3:24 ` Kuninori Morimoto
2018-12-13 3:37 ` Tony Lindgren
2018-12-13 3:45 ` Kuninori Morimoto
2018-12-13 4:34 ` Tony Lindgren [this message]
2018-12-13 15:20 ` Mark Brown
2018-12-13 16:05 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213043445.GL39861@atomide.com \
--to=tony@atomide.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.