From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 0/1] Fix regression in t9902 with NO_PERL
Date: Thu, 13 Dec 2018 14:27:07 +0100 [thread overview]
Message-ID: <20181213132707.GX30222@szeder.dev> (raw)
In-Reply-To: <pull.99.git.gitgitgadget@gmail.com>
On Thu, Dec 13, 2018 at 05:01:11AM -0800, Johannes Schindelin via GitGitGadget wrote:
> The oneline notwithstanding,13374987dd (completion: use _gitcompbuiltin for
> format-patch, 2018-11-03) changed also the way send-email options are
> completed, by asking the git send-email command itself what options it
> offers.
>
> Necessarily, this must fail when built with NO_PERL because send-email
> itself is a Perl script. Which means that we need the PERL prerequisite for
> the send-email test case in t9902.
I find this text in the cover letter to be a better commit message
than the text in the patch itself, because mentions when it broke and
clearly mentions why it broke.
> Johannes Schindelin (1):
> t9902: 'send-email' test case requires PERL
>
> t/t9902-completion.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
> Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/99
> --
> gitgitgadget
next prev parent reply other threads:[~2018-12-13 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:27 ` SZEDER Gábor [this message]
2018-12-13 13:52 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin
2018-12-13 14:04 ` [PATCH v2 " Johannes Schindelin via GitGitGadget
2018-12-13 14:04 ` [PATCH v2 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213132707.GX30222@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.