All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>
Subject: [PATCH v2 0/1] Fix regression in t9902 with NO_PERL
Date: Thu, 13 Dec 2018 06:04:18 -0800 (PST)	[thread overview]
Message-ID: <pull.99.v2.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.99.git.gitgitgadget@gmail.com>

The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin for
format-patch, 2018-11-03) changed also the way send-email options are
completed, by asking the git send-email command itself what options it
offers.

Necessarily, this must fail when built with NO_PERL because send-email 
itself is a Perl script. Which means that we need the PERL prerequisite for
the send-email test case in t9902.

Changes since v1:

 * replaced the commit message by the cover letter, as it was deemed to be
   more informative.

Johannes Schindelin (1):
  t9902: 'send-email' test case requires PERL

 t/t9902-completion.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 5d826e972970a784bd7a7bdf587512510097b8c7
Published-As: https://github.com/gitgitgadget/git/releases/tags/pr-99%2Fdscho%2Ft9902-no-perl-fix-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-99/dscho/t9902-no-perl-fix-v2
Pull-Request: https://github.com/gitgitgadget/git/pull/99

Range-diff vs v1:

 1:  32e6bf2dd3 ! 1:  8e3ddff2c7 t9902: 'send-email' test case requires PERL
     @@ -2,14 +2,14 @@
      
          t9902: 'send-email' test case requires PERL
      
     -    With NO_PERL, the `git send-email` script errors out with code 128,
     -    mentioning that Git was built without Perl support.
     +    The oneline notwithstanding, 13374987dd (completion: use _gitcompbuiltin
     +    for format-patch, 2018-11-03) changed also the way send-email options
     +    are completed, by asking the git send-email command itself what options
     +    it offers.
      
     -    Therefore, when the completion tries to ask for possible completions via
     -    `git send-email --git-completion-helper`, it won't provide what is
     -    necessary for that test case to pass.
     -
     -    So let's mark it with the PERL prerequisite.
     +    Necessarily, this must fail when built with NO_PERL because send-email
     +    itself is a Perl script. Which means that we need the PERL prerequisite
     +    for the send-email test case in t9902.
      
          Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
      

-- 
gitgitgadget

  parent reply	other threads:[~2018-12-13 14:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 13:01 [PATCH 0/1] Fix regression in t9902 with NO_PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:01 ` [PATCH 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget
2018-12-13 13:27 ` [PATCH 0/1] Fix regression in t9902 with NO_PERL SZEDER Gábor
2018-12-13 13:52   ` Johannes Schindelin
2018-12-13 14:04 ` Johannes Schindelin via GitGitGadget [this message]
2018-12-13 14:04   ` [PATCH v2 1/1] t9902: 'send-email' test case requires PERL Johannes Schindelin via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.99.v2.git.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.