From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Priit Laes <plaes@plaes.org>, Kees Cook <keescook@chromium.org>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2'
Date: Thu, 13 Dec 2018 15:02:39 +0000 [thread overview]
Message-ID: <20181213150239.BE5E8607BA@smtp.codeaurora.org> (raw)
In-Reply-To: <1543994766-7057-1-git-send-email-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
> variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
>
> drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
> variable 'tmp2' set but not used [-Wunused-but-set-variable]
>
> 'tx_pwr_state' never used since introduction in commit
> 8615eb2870f1 ("b43: N-PHY: support setting custom TX power")
>
> 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
> for checking IPA")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2'
--
https://patchwork.kernel.org/patch/10713095/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Priit Laes <plaes@plaes.org>, Kees Cook <keescook@chromium.org>,
Jia-Ju Bai <baijiaju1990@gmail.com>,
YueHaibing <yuehaibing@huawei.com>,
<linux-wireless@vger.kernel.org>, <b43-dev@lists.infradead.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2'
Date: Thu, 13 Dec 2018 15:02:39 +0000 (UTC) [thread overview]
Message-ID: <20181213150239.BE5E8607BA@smtp.codeaurora.org> (raw)
In-Reply-To: <1543994766-7057-1-git-send-email-yuehaibing@huawei.com>
YueHaibing <yuehaibing@huawei.com> wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_op_recalc_txpower':
> drivers/net/wireless/broadcom/b43/phy_n.c:5898:7: warning:
> variable 'tx_pwr_state' set but not used [-Wunused-but-set-variable]
>
> drivers/net/wireless/broadcom/b43/phy_n.c:6047:20: warning:
> variable 'tmp2' set but not used [-Wunused-but-set-variable]
>
> 'tx_pwr_state' never used since introduction in commit
> 8615eb2870f1 ("b43: N-PHY: support setting custom TX power")
>
> 'tmp2' not used any more since commit c002831a07dd ("b43: N-PHY: use helper
> for checking IPA")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Patch applied to wireless-drivers-next.git, thanks.
662a7b078cff b43: remove set but not used variables 'tx_pwr_state,tmp2'
--
https://patchwork.kernel.org/patch/10713095/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-12-13 15:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 4:15 [PATCH] b43: remove set but not used variable 'wl' YueHaibing
2018-10-05 4:15 ` YueHaibing
2018-10-05 8:38 ` Kalle Valo
2018-10-05 8:38 ` Kalle Valo
2018-12-05 7:26 ` [PATCH] b43: remove set but not used variables 'tx_pwr_state,tmp2' YueHaibing
2018-12-05 7:26 ` YueHaibing
[not found] ` <1543994766-7057-1-git-send-email-yuehaibing-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2018-12-13 15:02 ` [PATCH] b43: remove set but not used variables 'tx_pwr_state, tmp2' Kalle Valo
2018-12-13 15:02 ` Kalle Valo [this message]
2018-12-13 15:02 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213150239.BE5E8607BA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=baijiaju1990@gmail.com \
--cc=keescook@chromium.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=plaes@plaes.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.