From: "Dmitry V. Levin" <ldv@altlinux.org>
To: linux-kernel@vger.kernel.org
Cc: Max Filippov <jcmvbkbc@gmail.com>,
Oleg Nesterov <oleg@redhat.com>,
Andy Lutomirski <luto@kernel.org>,
Elvira Khabirova <lineprinter@altlinux.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
Chris Zankel <chris@zankel.net>, Paul Moore <paul@paul-moore.com>,
Eric Paris <eparis@redhat.com>,
linux-xtensa@linux-xtensa.org, linux-audit@redhat.com
Subject: [PATCH v6 21/27] xtensa: define syscall_get_* functions
Date: Thu, 13 Dec 2018 20:23:35 +0300 [thread overview]
Message-ID: <20181213172335.GU6024@altlinux.org> (raw)
In-Reply-To: 20181213171833.GA5240@altlinux.org
syscall_get_* functions are required to be implemented on all
architectures in order to extend the generic ptrace API with
PTRACE_GET_SYSCALL_INFO request.
This adds all 5 syscall_get_* functions on xtensa as documented
in asm-generic/syscall.h: syscall_get_nr, syscall_get_arguments,
syscall_get_error, syscall_get_return_value, and syscall_get_arch.
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Elvira Khabirova <lineprinter@altlinux.org>
Cc: Eugene Syromyatnikov <esyr@redhat.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Paul Moore <paul@paul-moore.com>
Cc: Eric Paris <eparis@redhat.com>
Cc: linux-xtensa@linux-xtensa.org
Cc: linux-audit@redhat.com
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
Notes:
v6: there is a tracehook support in xtensa tree where all syscall_get_*
functions are implemented already, no need to pay attention at this patch
v5: added syscall_get_nr, syscall_get_arguments, syscall_get_error,
and syscall_get_return_value
v2: added Acked-by
v1: added syscall_get_arch
arch/xtensa/include/asm/syscall.h | 65 +++++++++++++++++++++++++++++++
include/uapi/linux/audit.h | 1 +
2 files changed, 66 insertions(+)
diff --git a/arch/xtensa/include/asm/syscall.h b/arch/xtensa/include/asm/syscall.h
index 3673ff1f1bc5..40c6de062ac8 100644
--- a/arch/xtensa/include/asm/syscall.h
+++ b/arch/xtensa/include/asm/syscall.h
@@ -8,6 +8,71 @@
* Copyright (C) 2001 - 2007 Tensilica Inc.
*/
+#include <linux/err.h>
+#include <uapi/linux/audit.h>
+#include <asm/ptrace.h>
+#include <asm-generic/syscall.h>
+
+static inline int
+syscall_get_nr(struct task_struct *task, struct pt_regs *regs)
+{
+ return regs->syscall;
+}
+
+static inline void
+__syscall_get_arguments(struct task_struct *task, struct pt_regs *regs,
+ unsigned int i, unsigned int n, unsigned long *args)
+{
+ switch (i) {
+ case 0:
+ if (!n--)
+ break;
+ *args++ = regs->areg[6];
+ /* fall through */
+ case 1:
+ if (!n--)
+ break;
+ *args++ = regs->areg[3];
+ /* fall through */
+ case 2:
+ if (!n--)
+ break;
+ *args++ = regs->areg[4];
+ /* fall through */
+ case 3:
+ if (!n--)
+ break;
+ *args++ = regs->areg[5];
+ /* fall through */
+ case 4:
+ if (!n--)
+ break;
+ *args++ = regs->areg[8];
+ /* fall through */
+ case 5:
+ if (!n--)
+ break;
+ *args++ = regs->areg[9];
+ }
+}
+
+static inline long
+syscall_get_error(struct task_struct *task, struct pt_regs *regs)
+{
+ return IS_ERR_VALUE(regs->areg[2]) ? regs->areg[2] : 0;
+
+static inline long
+syscall_get_return_value(struct task_struct *task, struct pt_regs *regs)
+{
+ return regs->areg[2];
+}
+
+static inline int
+syscall_get_arch(void)
+{
+ return AUDIT_ARCH_XTENSA;
+}
+
struct pt_regs;
asmlinkage long xtensa_ptrace(long, long, long, long);
asmlinkage long xtensa_sigreturn(struct pt_regs*);
diff --git a/include/uapi/linux/audit.h b/include/uapi/linux/audit.h
index 1e9808f3a240..bcc0619b046f 100644
--- a/include/uapi/linux/audit.h
+++ b/include/uapi/linux/audit.h
@@ -425,6 +425,7 @@ enum {
#define AUDIT_ARCH_TILEGX32 (EM_TILEGX|__AUDIT_ARCH_LE)
#define AUDIT_ARCH_TILEPRO (EM_TILEPRO|__AUDIT_ARCH_LE)
#define AUDIT_ARCH_X86_64 (EM_X86_64|__AUDIT_ARCH_64BIT|__AUDIT_ARCH_LE)
+#define AUDIT_ARCH_XTENSA (EM_XTENSA)
#define AUDIT_PERM_EXEC 1
#define AUDIT_PERM_WRITE 2
--
ldv
next prev parent reply other threads:[~2018-12-13 17:23 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 17:18 [PATCH v6 00/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` [OpenRISC] " Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 01/27] asm-generic/syscall.h: prepare for inclusion by other files Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 02/27] asm-generic/syscall.h: turn syscall_[gs]et_arguments into wrappers Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 03/27] alpha: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 04/27] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-21 1:19 ` Dmitry V. Levin
2018-12-21 1:19 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 05/27] arc: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-21 1:21 ` Dmitry V. Levin
2018-12-21 1:21 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 06/27] c6x: " Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 07/27] elf-em.h: add EM_CSKY Dmitry V. Levin
2018-12-14 4:43 ` Guo Ren
2018-12-21 2:35 ` Dmitry V. Levin
2018-12-21 14:49 ` Guo Ren
2018-12-13 17:22 ` [PATCH v6 08/27] csky: define syscall_get_arch() Dmitry V. Levin
2018-12-14 4:44 ` Guo Ren
2018-12-21 2:36 ` Dmitry V. Levin
2018-12-21 14:48 ` Guo Ren
2018-12-13 17:22 ` [PATCH v6 09/27] h8300: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 10/27] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 11/27] hexagon: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 12/27] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 13/27] nds32: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 14/27] nios2: " Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 15/27] m68k: add asm/syscall.h Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 16/27] mips: define syscall_get_error() Dmitry V. Levin
2018-12-13 19:00 ` Paul Burton
2018-12-21 1:31 ` Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 17/27] parisc: " Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 18/27] powerpc: " Dmitry V. Levin
2018-12-13 17:23 ` Dmitry V. Levin
2018-12-18 12:36 ` powerpc syscall_set_return_value() is confused (was Re: [PATCH v6 18/27] powerpc: define syscall_get_error()) Michael Ellerman
2018-12-18 12:36 ` Michael Ellerman
2018-12-13 17:23 ` [PATCH v6 19/27] riscv: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:23 ` Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 20/27] Move EM_XTENSA to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:23 ` Dmitry V. Levin [this message]
2018-12-13 17:24 ` [PATCH v6 22/27] Move EM_UNICORE " Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 23/27] unicore32: add asm/syscall.h Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 24/27] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` [OpenRISC] " Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 25/27] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 26/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 27/27] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO ldv
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-14 20:15 ` [PATCH v6 00/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` [OpenRISC] " Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213172335.GU6024@altlinux.org \
--to=ldv@altlinux.org \
--cc=chris@zankel.net \
--cc=eparis@redhat.com \
--cc=esyr@redhat.com \
--cc=jcmvbkbc@gmail.com \
--cc=lineprinter@altlinux.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=luto@kernel.org \
--cc=oleg@redhat.com \
--cc=paul@paul-moore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.