From: "Dmitry V. Levin" <ldv@altlinux.org>
To: linux-kernel@vger.kernel.org
Cc: Elvira Khabirova <lineprinter@altlinux.org>,
linuxppc-dev@lists.ozlabs.org, Oleg Nesterov <oleg@redhat.com>,
Eugene Syromyatnikov <esyr@redhat.com>
Subject: [PATCH v6 25/27] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
Date: Thu, 13 Dec 2018 20:24:30 +0300 [thread overview]
Message-ID: <20181213172430.GY6024@altlinux.org> (raw)
In-Reply-To: 20181213171833.GA5240@altlinux.org
From: Elvira Khabirova <lineprinter@altlinux.org>
Arch code should use tracehook_*() helpers, as documented in
include/linux/tracehook.h, ptrace_report_syscall() is not expected to
be used outside that file.
The patch does not look very nice, but at least it is correct
and opens the way for PTRACE_GET_SYSCALL_INFO API.
Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")
Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
[mpe: Take this as a minimal fix for 4.20, we'll rework it later]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
Notes:
v6: this is the fix that was taken into powerpc tree
v5: reverted to a simple approach, compile- and run-tested
v4: rewritten to call tracehook_report_syscall_entry() once, compile-tested
v3: add a descriptive comment
v2: explicitly ignore tracehook_report_syscall_entry() return code
arch/powerpc/kernel/ptrace.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index afb819f4ca68..714c3480c52d 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -3266,12 +3266,17 @@ long do_syscall_trace_enter(struct pt_regs *regs)
user_exit();
if (test_thread_flag(TIF_SYSCALL_EMU)) {
- ptrace_report_syscall(regs);
/*
+ * A nonzero return code from tracehook_report_syscall_entry()
+ * tells us to prevent the syscall execution, but we are not
+ * going to execute it anyway.
+ *
* Returning -1 will skip the syscall execution. We want to
* avoid clobbering any register also, thus, not 'gotoing'
* skip label.
*/
+ if (tracehook_report_syscall_entry(regs))
+ ;
return -1;
}
--
ldv
WARNING: multiple messages have this Message-ID (diff)
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: linux-kernel@vger.kernel.org
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Oleg Nesterov <oleg@redhat.com>,
Elvira Khabirova <lineprinter@altlinux.org>,
Eugene Syromyatnikov <esyr@redhat.com>,
linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v6 25/27] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call
Date: Thu, 13 Dec 2018 20:24:30 +0300 [thread overview]
Message-ID: <20181213172430.GY6024@altlinux.org> (raw)
In-Reply-To: 20181213171833.GA5240@altlinux.org
From: Elvira Khabirova <lineprinter@altlinux.org>
Arch code should use tracehook_*() helpers, as documented in
include/linux/tracehook.h, ptrace_report_syscall() is not expected to
be used outside that file.
The patch does not look very nice, but at least it is correct
and opens the way for PTRACE_GET_SYSCALL_INFO API.
Co-authored-by: Dmitry V. Levin <ldv@altlinux.org>
Fixes: 5521eb4bca2d ("powerpc/ptrace: Add support for PTRACE_SYSEMU")
Signed-off-by: Elvira Khabirova <lineprinter@altlinux.org>
Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
[mpe: Take this as a minimal fix for 4.20, we'll rework it later]
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
Notes:
v6: this is the fix that was taken into powerpc tree
v5: reverted to a simple approach, compile- and run-tested
v4: rewritten to call tracehook_report_syscall_entry() once, compile-tested
v3: add a descriptive comment
v2: explicitly ignore tracehook_report_syscall_entry() return code
arch/powerpc/kernel/ptrace.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/powerpc/kernel/ptrace.c b/arch/powerpc/kernel/ptrace.c
index afb819f4ca68..714c3480c52d 100644
--- a/arch/powerpc/kernel/ptrace.c
+++ b/arch/powerpc/kernel/ptrace.c
@@ -3266,12 +3266,17 @@ long do_syscall_trace_enter(struct pt_regs *regs)
user_exit();
if (test_thread_flag(TIF_SYSCALL_EMU)) {
- ptrace_report_syscall(regs);
/*
+ * A nonzero return code from tracehook_report_syscall_entry()
+ * tells us to prevent the syscall execution, but we are not
+ * going to execute it anyway.
+ *
* Returning -1 will skip the syscall execution. We want to
* avoid clobbering any register also, thus, not 'gotoing'
* skip label.
*/
+ if (tracehook_report_syscall_entry(regs))
+ ;
return -1;
}
--
ldv
next prev parent reply other threads:[~2018-12-13 17:27 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 17:18 [PATCH v6 00/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` [OpenRISC] " Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:18 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 01/27] asm-generic/syscall.h: prepare for inclusion by other files Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 02/27] asm-generic/syscall.h: turn syscall_[gs]et_arguments into wrappers Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 03/27] alpha: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 04/27] Move EM_ARCOMPACT and EM_ARCV2 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-21 1:19 ` Dmitry V. Levin
2018-12-21 1:19 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 05/27] arc: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:21 ` Dmitry V. Levin
2018-12-21 1:21 ` Dmitry V. Levin
2018-12-21 1:21 ` Dmitry V. Levin
2018-12-13 17:21 ` [PATCH v6 06/27] c6x: " Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 07/27] elf-em.h: add EM_CSKY Dmitry V. Levin
2018-12-14 4:43 ` Guo Ren
2018-12-21 2:35 ` Dmitry V. Levin
2018-12-21 14:49 ` Guo Ren
2018-12-13 17:22 ` [PATCH v6 08/27] csky: define syscall_get_arch() Dmitry V. Levin
2018-12-14 4:44 ` Guo Ren
2018-12-21 2:36 ` Dmitry V. Levin
2018-12-21 14:48 ` Guo Ren
2018-12-13 17:22 ` [PATCH v6 09/27] h8300: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 10/27] Move EM_HEXAGON to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 11/27] hexagon: define remaining syscall_get_* functions Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 12/27] Move EM_NDS32 to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 13/27] nds32: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 14/27] nios2: " Dmitry V. Levin
2018-12-13 17:22 ` [PATCH v6 15/27] m68k: add asm/syscall.h Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 16/27] mips: define syscall_get_error() Dmitry V. Levin
2018-12-13 19:00 ` Paul Burton
2018-12-21 1:31 ` Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 17/27] parisc: " Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 18/27] powerpc: " Dmitry V. Levin
2018-12-13 17:23 ` Dmitry V. Levin
2018-12-18 12:36 ` powerpc syscall_set_return_value() is confused (was Re: [PATCH v6 18/27] powerpc: define syscall_get_error()) Michael Ellerman
2018-12-18 12:36 ` Michael Ellerman
2018-12-13 17:23 ` [PATCH v6 19/27] riscv: define syscall_get_arch() Dmitry V. Levin
2018-12-13 17:23 ` Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 20/27] Move EM_XTENSA to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:23 ` [PATCH v6 21/27] xtensa: define syscall_get_* functions Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 22/27] Move EM_UNICORE to uapi/linux/elf-em.h Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 23/27] unicore32: add asm/syscall.h Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 24/27] syscall_get_arch: add "struct task_struct *" argument Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` [OpenRISC] " Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin [this message]
2018-12-13 17:24 ` [PATCH v6 25/27] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 26/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Dmitry V. Levin
2018-12-13 17:24 ` [PATCH v6 27/27] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO ldv
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-13 17:24 ` Dmitry V. Levin
2018-12-14 20:15 ` [PATCH v6 00/27] ptrace: add PTRACE_GET_SYSCALL_INFO request Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` [OpenRISC] " Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` Paul Moore
2018-12-14 20:15 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213172430.GY6024@altlinux.org \
--to=ldv@altlinux.org \
--cc=esyr@redhat.com \
--cc=lineprinter@altlinux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.