* [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions
@ 2018-12-12 2:20 james.hilliard1 at gmail.com
2018-12-12 8:55 ` Arnout Vandecappelle
2018-12-13 20:59 ` Thomas Petazzoni
0 siblings, 2 replies; 4+ messages in thread
From: james.hilliard1 at gmail.com @ 2018-12-12 2:20 UTC (permalink / raw)
To: buildroot
From: James Hilliard <james.hilliard1@gmail.com>
Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
package/acpid/acpid.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk
index 514fd31..adcc175 100644
--- a/package/acpid/acpid.mk
+++ b/package/acpid/acpid.mk
@@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
ACPID_LICENSE_FILES = COPYING
define ACPID_INSTALL_INIT_SYSTEMD
- $(INSTALL) -D -m 0755 package/acpid/acpid.service \
+ $(INSTALL) -D -m 0644 package/acpid/acpid.service \
$(TARGET_DIR)/usr/lib/systemd/system/acpid.service
mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
ln -sf ../../../../usr/lib/systemd/system/acpid.service \
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions
2018-12-12 2:20 [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions james.hilliard1 at gmail.com
@ 2018-12-12 8:55 ` Arnout Vandecappelle
2018-12-12 9:00 ` James Hilliard
2018-12-13 20:59 ` Thomas Petazzoni
1 sibling, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2018-12-12 8:55 UTC (permalink / raw)
To: buildroot
Hi James,
On 12/12/2018 03:20, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
Could you give a little more detail here? In particular: is it just because
it's not supposed to be executed, or does it in fact give some runtime problems
if it is executable? That information is important to decide if the patch should
be backported to the stable branches or not.
Regards,
Arnout
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/acpid/acpid.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk
> index 514fd31..adcc175 100644
> --- a/package/acpid/acpid.mk
> +++ b/package/acpid/acpid.mk
> @@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
> ACPID_LICENSE_FILES = COPYING
>
> define ACPID_INSTALL_INIT_SYSTEMD
> - $(INSTALL) -D -m 0755 package/acpid/acpid.service \
> + $(INSTALL) -D -m 0644 package/acpid/acpid.service \
> $(TARGET_DIR)/usr/lib/systemd/system/acpid.service
> mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> ln -sf ../../../../usr/lib/systemd/system/acpid.service \
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions
2018-12-12 8:55 ` Arnout Vandecappelle
@ 2018-12-12 9:00 ` James Hilliard
0 siblings, 0 replies; 4+ messages in thread
From: James Hilliard @ 2018-12-12 9:00 UTC (permalink / raw)
To: buildroot
On Wed, Dec 12, 2018 at 1:55 AM Arnout Vandecappelle <arnout@mind.be> wrote:
>
> Hi James,
>
> On 12/12/2018 03:20, james.hilliard1 at gmail.com wrote:
> > From: James Hilliard <james.hilliard1@gmail.com>
>
> Could you give a little more detail here? In particular: is it just because
> it's not supposed to be executed, or does it in fact give some runtime problems
> if it is executable? That information is important to decide if the patch should
> be backported to the stable branches or not.
It causes systemd to throw runtime warnings since systemd service
files are essentially a type of configuration file and are not
designed to be executed like init scripts. You should probably
backport it to get rid of the noise in the logs it causes.
>
> Regards,
> Arnout
>
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/acpid/acpid.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/acpid/acpid.mk b/package/acpid/acpid.mk
> > index 514fd31..adcc175 100644
> > --- a/package/acpid/acpid.mk
> > +++ b/package/acpid/acpid.mk
> > @@ -11,7 +11,7 @@ ACPID_LICENSE = GPL-2.0+
> > ACPID_LICENSE_FILES = COPYING
> >
> > define ACPID_INSTALL_INIT_SYSTEMD
> > - $(INSTALL) -D -m 0755 package/acpid/acpid.service \
> > + $(INSTALL) -D -m 0644 package/acpid/acpid.service \
> > $(TARGET_DIR)/usr/lib/systemd/system/acpid.service
> > mkdir -p $(TARGET_DIR)/etc/systemd/system/multi-user.target.wants
> > ln -sf ../../../../usr/lib/systemd/system/acpid.service \
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions
2018-12-12 2:20 [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions james.hilliard1 at gmail.com
2018-12-12 8:55 ` Arnout Vandecappelle
@ 2018-12-13 20:59 ` Thomas Petazzoni
1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-12-13 20:59 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 12 Dec 2018 10:20:04 +0800, james.hilliard1 at gmail.com wrote:
> From: James Hilliard <james.hilliard1@gmail.com>
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/acpid/acpid.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master with an extended commit log. Thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-12-13 20:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-12 2:20 [Buildroot] [PATCH 1/1] package/acpid: fix acpid.service permissions james.hilliard1 at gmail.com
2018-12-12 8:55 ` Arnout Vandecappelle
2018-12-12 9:00 ` James Hilliard
2018-12-13 20:59 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.