From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Ulrich Hecht <uli+renesas@fpond.eu>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 3/4] serial: sh-sci: Resume PIO in sci_rx_interrupt() on DMA failure
Date: Fri, 14 Dec 2018 17:14:22 +0100 [thread overview]
Message-ID: <20181214161422.GB4236@kunai> (raw)
In-Reply-To: <20181213184444.21904-4-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Thu, Dec 13, 2018 at 07:44:43PM +0100, Geert Uytterhoeven wrote:
> On (H)SCIF, sci_submit_rx() is called in the receive interrupt handler.
> Hence if DMA submission fails, the interrupt handler should resume
> handling reception using PIO, else no more data is received.
>
> Make sci_submit_rx() return an error indicator, so the receive interrupt
> handler can act appropriately.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>, Ulrich Hecht <uli+renesas@fpond.eu>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-renesas-soc@vger.kernel.org, linux-sh@vger.kernel.org,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v4 3/4] serial: sh-sci: Resume PIO in sci_rx_interrupt() on DMA failure
Date: Fri, 14 Dec 2018 16:14:22 +0000 [thread overview]
Message-ID: <20181214161422.GB4236@kunai> (raw)
In-Reply-To: <20181213184444.21904-4-geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Thu, Dec 13, 2018 at 07:44:43PM +0100, Geert Uytterhoeven wrote:
> On (H)SCIF, sci_submit_rx() is called in the receive interrupt handler.
> Hence if DMA submission fails, the interrupt handler should resume
> handling reception using PIO, else no more data is received.
>
> Make sci_submit_rx() return an error indicator, so the receive interrupt
> handler can act appropriately.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-14 16:14 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 18:44 [PATCH v4 0/4] serial: sh-sci: Fix fallback to PIO on DMA failure Geert Uytterhoeven
2018-12-13 18:44 ` Geert Uytterhoeven
2018-12-13 18:44 ` [PATCH v4 1/4] serial: sh-sci: Fix locking in sci_submit_rx() Geert Uytterhoeven
2018-12-13 18:44 ` Geert Uytterhoeven
2018-12-17 13:17 ` Simon Horman
2018-12-17 13:17 ` Simon Horman
2018-12-13 18:44 ` [PATCH v4 2/4] serial: sh-sci: Fix crash in rx_timer_fn() on PIO fallback Geert Uytterhoeven
2018-12-13 18:44 ` Geert Uytterhoeven
2018-12-17 13:22 ` Simon Horman
2018-12-17 13:22 ` Simon Horman
2018-12-17 13:27 ` Geert Uytterhoeven
2018-12-17 13:27 ` Geert Uytterhoeven
2018-12-17 14:50 ` Simon Horman
2018-12-17 14:50 ` Simon Horman
2018-12-13 18:44 ` [PATCH v4 3/4] serial: sh-sci: Resume PIO in sci_rx_interrupt() on DMA failure Geert Uytterhoeven
2018-12-13 18:44 ` Geert Uytterhoeven
2018-12-14 16:14 ` Wolfram Sang [this message]
2018-12-14 16:14 ` Wolfram Sang
2018-12-17 13:25 ` Simon Horman
2018-12-17 13:25 ` Simon Horman
2018-12-13 18:44 ` [PATCH v4 4/4] serial: sh-sci: Fix fallback to PIO in sci_dma_rx_complete() Geert Uytterhoeven
2018-12-13 18:44 ` Geert Uytterhoeven
2018-12-17 13:29 ` Simon Horman
2018-12-17 13:29 ` Simon Horman
2018-12-16 2:22 ` [PATCH v4 0/4] serial: sh-sci: Fix fallback to PIO on DMA failure Rob Landley
2018-12-16 2:22 ` Rob Landley
2018-12-16 8:27 ` Geert Uytterhoeven
2018-12-16 8:27 ` Geert Uytterhoeven
2018-12-17 14:05 ` Greg Kroah-Hartman
2018-12-17 14:05 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214161422.GB4236@kunai \
--to=wsa@the-dreams.de \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=uli+renesas@fpond.eu \
--cc=wsa+renesas@sang-engineering.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.