From: Ming Lei <ming.lei@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 2/2] nvme-pci: don't share queue maps
Date: Mon, 17 Dec 2018 19:24:42 +0800 [thread overview]
Message-ID: <20181217112441.GF1329@ming.t460p> (raw)
In-Reply-To: <20181217111627.22635-2-hch@lst.de>
On Mon, Dec 17, 2018 at 12:16:27PM +0100, Christoph Hellwig wrote:
> Now that the block layer checks if a queue map has any queues inside
> it there is no more reason to duplicate the maps for the non-default
> types.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/nvme/host/pci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index fb9d8270f32c..698b350b38cf 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -496,11 +496,7 @@ static int nvme_pci_map_queues(struct blk_mq_tag_set *set)
> map->nr_queues = dev->io_queues[i];
> if (!map->nr_queues) {
> BUG_ON(i == HCTX_TYPE_DEFAULT);
> -
> - /* shared set, resuse read set parameters */
> - map->nr_queues = dev->io_queues[HCTX_TYPE_DEFAULT];
> - qoff = 0;
> - offset = queue_irq_offset(dev);
> + continue;
> }
>
> /*
> --
> 2.19.2
>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
WARNING: multiple messages have this Message-ID (diff)
From: ming.lei@redhat.com (Ming Lei)
Subject: [PATCH 2/2] nvme-pci: don't share queue maps
Date: Mon, 17 Dec 2018 19:24:42 +0800 [thread overview]
Message-ID: <20181217112441.GF1329@ming.t460p> (raw)
In-Reply-To: <20181217111627.22635-2-hch@lst.de>
On Mon, Dec 17, 2018@12:16:27PM +0100, Christoph Hellwig wrote:
> Now that the block layer checks if a queue map has any queues inside
> it there is no more reason to duplicate the maps for the non-default
> types.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
> ---
> drivers/nvme/host/pci.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index fb9d8270f32c..698b350b38cf 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -496,11 +496,7 @@ static int nvme_pci_map_queues(struct blk_mq_tag_set *set)
> map->nr_queues = dev->io_queues[i];
> if (!map->nr_queues) {
> BUG_ON(i == HCTX_TYPE_DEFAULT);
> -
> - /* shared set, resuse read set parameters */
> - map->nr_queues = dev->io_queues[HCTX_TYPE_DEFAULT];
> - qoff = 0;
> - offset = queue_irq_offset(dev);
> + continue;
> }
>
> /*
> --
> 2.19.2
>
Reviewed-by: Ming Lei <ming.lei at redhat.com>
Thanks,
Ming
next prev parent reply other threads:[~2018-12-17 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-17 11:16 [PATCH 1/2] blk-mq: only dispatch to non-defauly queue maps if they have queues Christoph Hellwig
2018-12-17 11:16 ` Christoph Hellwig
2018-12-17 11:16 ` [PATCH 2/2] nvme-pci: don't share queue maps Christoph Hellwig
2018-12-17 11:16 ` Christoph Hellwig
2018-12-17 11:24 ` Ming Lei [this message]
2018-12-17 11:24 ` Ming Lei
2018-12-17 12:56 ` Jens Axboe
2018-12-17 12:56 ` Jens Axboe
2018-12-17 11:23 ` [PATCH 1/2] blk-mq: only dispatch to non-defauly queue maps if they have queues Ming Lei
2018-12-17 11:23 ` Ming Lei
2018-12-17 12:56 ` Jens Axboe
2018-12-17 12:56 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217112441.GF1329@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.