[PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Hans de Goede]

Hi All,

As discussed a while ago, I would like to see us enable fastboot by
default, starting with Skylake / GEN9 and newer hardware, so that we can
avoid an unnecessary modeset at boot and move to a truely flickerfree boot.

During our previous discussion about this Maarten mentioned that a first
step would be to get this patch from him upstream. So I'm hereby
resubmitting it, with a small fix. Hopefully the CI will like it better
this time (if not we will need to investigate) and once this passes CI
I hope this can be reviewed quickly and we can get this upstream.

I will also be sending out a follow-up patch which actually makes fastboot
the default on GEN9 and newer, I will mark that as RFC for now since based
on our previous discussion this patch should be landed first.

Regards,

Hans


_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH] drm/i915: Enable fastset by default, except on initial modeset

[Hans de Goede]

From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

We may not be perfect at reading out the initial mode, but when the mode
is sanitized by our first modeset we know for sure the state is compatible,
so we can compare with intel_pipe_config_compare.

Changes in v2 (Hans de Goede):
-When checking if we need to reset the mode (initial modeset), check
 I915_MODE_FLAG_INHERITED is set in private_flags instead of
 private_flags != 0

Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
 drivers/gpu/drm/i915/intel_display.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index c2980643a1a5..071954d255c6 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -12501,6 +12501,22 @@ static int calc_watermark_data(struct drm_atomic_state *state)
 	return 0;
 }
 
+static bool can_fastset(struct drm_i915_private *dev_priv,
+			struct intel_crtc_state *old_crtc_state,
+			struct intel_crtc_state *new_crtc_state)
+{
+	bool reset_mode =
+		(old_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
+		!(new_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
+
+	/* Without fastboot, we always want to modeset the initial mode. */
+	if (reset_mode && !i915_modparams.fastboot)
+		return false;
+
+	return intel_pipe_config_compare(dev_priv, old_crtc_state,
+					 new_crtc_state, true);
+}
+
 /**
  * intel_atomic_check - validate state object
  * @dev: drm device
@@ -12531,6 +12547,8 @@ static int intel_atomic_check(struct drm_device *dev,
 	for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, crtc_state, i) {
 		struct intel_crtc_state *pipe_config =
 			to_intel_crtc_state(crtc_state);
+		struct intel_crtc_state *old_intel_crtc_state =
+			to_intel_crtc_state(old_crtc_state);
 
 		if (!needs_modeset(crtc_state))
 			continue;
@@ -12547,10 +12565,7 @@ static int intel_atomic_check(struct drm_device *dev,
 			return ret;
 		}
 
-		if (i915_modparams.fastboot &&
-		    intel_pipe_config_compare(dev_priv,
-					to_intel_crtc_state(old_crtc_state),
-					pipe_config, true)) {
+		if (can_fastset(dev_priv, old_intel_crtc_state, pipe_config)) {
 			crtc_state->mode_changed = false;
 			pipe_config->update_pipe = true;
 		}
-- 
2.20.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/i915: Enable fastset by default, except on initial modeset

[Daniel Vetter]

On Mon, Dec 17, 2018 at 3:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> We may not be perfect at reading out the initial mode, but when the mode
> is sanitized by our first modeset we know for sure the state is compatible,
> so we can compare with intel_pipe_config_compare.
>
> Changes in v2 (Hans de Goede):
> -When checking if we need to reset the mode (initial modeset), check
>  I915_MODE_FLAG_INHERITED is set in private_flags instead of
>  private_flags != 0
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>

Do we have igts which exercise this functionality? Having that is
kinda the point of enabling this first only for non-bootup modesets,
so that we can weed out the bugs. I think most (maybe even all) igts
we have do their modesets by explicitly shutting things down, and so
will never hit this. But we have lots of igts, so might have missed
some.

Anyway, patch imo should have a clear indication which igts we need to
watch out for this one here.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_display.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index c2980643a1a5..071954d255c6 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -12501,6 +12501,22 @@ static int calc_watermark_data(struct drm_atomic_state *state)
>         return 0;
>  }
>
> +static bool can_fastset(struct drm_i915_private *dev_priv,
> +                       struct intel_crtc_state *old_crtc_state,
> +                       struct intel_crtc_state *new_crtc_state)
> +{
> +       bool reset_mode =
> +               (old_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
> +               !(new_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
> +
> +       /* Without fastboot, we always want to modeset the initial mode. */
> +       if (reset_mode && !i915_modparams.fastboot)
> +               return false;
> +
> +       return intel_pipe_config_compare(dev_priv, old_crtc_state,
> +                                        new_crtc_state, true);
> +}
> +
>  /**
>   * intel_atomic_check - validate state object
>   * @dev: drm device
> @@ -12531,6 +12547,8 @@ static int intel_atomic_check(struct drm_device *dev,
>         for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, crtc_state, i) {
>                 struct intel_crtc_state *pipe_config =
>                         to_intel_crtc_state(crtc_state);
> +               struct intel_crtc_state *old_intel_crtc_state =
> +                       to_intel_crtc_state(old_crtc_state);
>
>                 if (!needs_modeset(crtc_state))
>                         continue;
> @@ -12547,10 +12565,7 @@ static int intel_atomic_check(struct drm_device *dev,
>                         return ret;
>                 }
>
> -               if (i915_modparams.fastboot &&
> -                   intel_pipe_config_compare(dev_priv,
> -                                       to_intel_crtc_state(old_crtc_state),
> -                                       pipe_config, true)) {
> +               if (can_fastset(dev_priv, old_intel_crtc_state, pipe_config)) {
>                         crtc_state->mode_changed = false;
>                         pipe_config->update_pipe = true;
>                 }
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Enable fastset by default, except on initial modeset

[Hans de Goede]

Hi,

On 17-12-18 15:29, Daniel Vetter wrote:
> On Mon, Dec 17, 2018 at 3:23 PM Hans de Goede <hdegoede@redhat.com> wrote:
>>
>> From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>
>> We may not be perfect at reading out the initial mode, but when the mode
>> is sanitized by our first modeset we know for sure the state is compatible,
>> so we can compare with intel_pipe_config_compare.
>>
>> Changes in v2 (Hans de Goede):
>> -When checking if we need to reset the mode (initial modeset), check
>>   I915_MODE_FLAG_INHERITED is set in private_flags instead of
>>   private_flags != 0
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> 
> Do we have igts which exercise this functionality?

I'm not sure, but last time Maarten submitted this patch it caused
a bunch of new dmesg warnings CI failures, which seems to indicate that
at least some tests are hitting the new code path where we do a fastset
independent of the fastboot=x parameter.

> Having that is
> kinda the point of enabling this first only for non-bootup modesets,
> so that we can weed out the bugs. I think most (maybe even all) igts
> we have do their modesets by explicitly shutting things down, and so
> will never hit this. But we have lots of igts, so might have missed
> some.
> 
> Anyway, patch imo should have a clear indication which igts we need to
> watch out for this one here.

Hmm, Maarten, can you provide a list of relevant igts to add to the
commit message ?

Regards,

Hans




>> ---
>>   drivers/gpu/drm/i915/intel_display.c | 23 +++++++++++++++++++----
>>   1 file changed, 19 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index c2980643a1a5..071954d255c6 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -12501,6 +12501,22 @@ static int calc_watermark_data(struct drm_atomic_state *state)
>>          return 0;
>>   }
>>
>> +static bool can_fastset(struct drm_i915_private *dev_priv,
>> +                       struct intel_crtc_state *old_crtc_state,
>> +                       struct intel_crtc_state *new_crtc_state)
>> +{
>> +       bool reset_mode =
>> +               (old_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED) &&
>> +               !(new_crtc_state->base.mode.private_flags & I915_MODE_FLAG_INHERITED);
>> +
>> +       /* Without fastboot, we always want to modeset the initial mode. */
>> +       if (reset_mode && !i915_modparams.fastboot)
>> +               return false;
>> +
>> +       return intel_pipe_config_compare(dev_priv, old_crtc_state,
>> +                                        new_crtc_state, true);
>> +}
>> +
>>   /**
>>    * intel_atomic_check - validate state object
>>    * @dev: drm device
>> @@ -12531,6 +12547,8 @@ static int intel_atomic_check(struct drm_device *dev,
>>          for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, crtc_state, i) {
>>                  struct intel_crtc_state *pipe_config =
>>                          to_intel_crtc_state(crtc_state);
>> +               struct intel_crtc_state *old_intel_crtc_state =
>> +                       to_intel_crtc_state(old_crtc_state);
>>
>>                  if (!needs_modeset(crtc_state))
>>                          continue;
>> @@ -12547,10 +12565,7 @@ static int intel_atomic_check(struct drm_device *dev,
>>                          return ret;
>>                  }
>>
>> -               if (i915_modparams.fastboot &&
>> -                   intel_pipe_config_compare(dev_priv,
>> -                                       to_intel_crtc_state(old_crtc_state),
>> -                                       pipe_config, true)) {
>> +               if (can_fastset(dev_priv, old_intel_crtc_state, pipe_config)) {
>>                          crtc_state->mode_changed = false;
>>                          pipe_config->update_pipe = true;
>>                  }
>> --
>> 2.20.1
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Ville Syrjälä]

On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
> Hi All,
> 
> As discussed a while ago, I would like to see us enable fastboot by
> default, starting with Skylake / GEN9 and newer hardware, so that we can
> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
> 
> During our previous discussion about this Maarten mentioned that a first
> step would be to get this patch from him upstream. So I'm hereby
> resubmitting it, with a small fix. Hopefully the CI will like it better
> this time (if not we will need to investigate) and once this passes CI
> I hope this can be reviewed quickly and we can get this upstream.
> 
> I will also be sending out a follow-up patch which actually makes fastboot
> the default on GEN9 and newer, I will mark that as RFC for now since based
> on our previous discussion this patch should be landed first.

The infoframe precompute/check stuff didn't land yet. I think we want
those in before we enable this thing.

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Hans de Goede]

Hi,

On 17-12-18 15:38, Ville Syrjälä wrote:
> On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
>> Hi All,
>>
>> As discussed a while ago, I would like to see us enable fastboot by
>> default, starting with Skylake / GEN9 and newer hardware, so that we can
>> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
>>
>> During our previous discussion about this Maarten mentioned that a first
>> step would be to get this patch from him upstream. So I'm hereby
>> resubmitting it, with a small fix. Hopefully the CI will like it better
>> this time (if not we will need to investigate) and once this passes CI
>> I hope this can be reviewed quickly and we can get this upstream.
>>
>> I will also be sending out a follow-up patch which actually makes fastboot
>> the default on GEN9 and newer, I will mark that as RFC for now since based
>> on our previous discussion this patch should be landed first.
> 
> The infoframe precompute/check stuff didn't land yet. I think we want
> those in before we enable this thing.

Hmm, what is the status of those changes? Unless those are almost ready
to go I'm not convinced that delaying this patch for those is a good idea,
I have the feeling there will always be one more thing to wait for if we
go that route.

Do you have a link to the latest version in patchwork?  Anything I can
do to help these move along ?

Regards,

Hans

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Enable fastset by default, except on initial modeset (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Enable fastset by default, except on initial modeset (rev2)
URL   : https://patchwork.freedesktop.org/series/43248/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5324 -> Patchwork_11106
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/43248/revisions/2/mbox/

Known issues
------------

  Here are the changes found in Patchwork_11106 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_cpu_reloc@basic:
    - fi-kbl-7560u:       PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_frontbuffer_tracking@basic:
    - fi-hsw-peppy:       PASS -> DMESG-FAIL [fdo#102614]

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     PASS -> FAIL [fdo#103191] / [fdo#107362]

  * igt@kms_pipe_crc_basic@read-crc-pipe-b:
    - fi-byt-clapper:     PASS -> FAIL [fdo#107362]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  
#### Possible fixes ####

  * igt@kms_flip@basic-flip-vs-dpms:
    - fi-skl-6700hq:      DMESG-WARN [fdo#105998] -> PASS

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
    - fi-byt-clapper:     FAIL [fdo#107362] -> PASS

  
  [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#105998]: https://bugs.freedesktop.org/show_bug.cgi?id=105998
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718


Participating hosts (49 -> 46)
------------------------------

  Additional (1): fi-cfl-8109u 
  Missing    (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


Build changes
-------------

    * Linux: CI_DRM_5324 -> Patchwork_11106

  CI_DRM_5324: 93009153b9bde1d65ca49bb1729cd1111591144b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4748: 90c76cb9bb47a5a3ebb34ad6b1a557bc02d39713 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_11106: 66faeac247d224bbd7b299b521b857994003c1dc @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

66faeac247d2 drm/i915: Enable fastset by default, except on initial modeset

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11106/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✗ Fi.CI.IGT: failure for drm/i915: Enable fastset by default, except on initial modeset (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915: Enable fastset by default, except on initial modeset (rev2)
URL   : https://patchwork.freedesktop.org/series/43248/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_5324_full -> Patchwork_11106_full
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_11106_full absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_11106_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_11106_full:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels:
    - shard-iclb:         PASS -> DMESG-WARN +1

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-skl:          PASS -> DMESG-WARN +1

  * {igt@runner@aborted}:
    - shard-kbl:          NOTRUN -> FAIL
    - shard-skl:          NOTRUN -> ( 2 FAIL )

  
#### Warnings ####

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
    - shard-snb:          SKIP -> PASS

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-kbl:          SKIP -> PASS
    - shard-snb:          PASS -> SKIP

  
Known issues
------------

  Here are the changes found in Patchwork_11106_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_schedule@pi-ringfull-vebox:
    - shard-skl:          NOTRUN -> FAIL [fdo#103158]

  * igt@kms_atomic_transition@1x-modeset-transitions-nonblocking:
    - shard-skl:          PASS -> FAIL [fdo#108228] / [fdo#108470]

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          PASS -> FAIL [fdo#106641]

  * igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
    - shard-skl:          NOTRUN -> DMESG-WARN [fdo#107956]

  * igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-b:
    - shard-glk:          PASS -> DMESG-WARN [fdo#107956]

  * igt@kms_color@pipe-a-legacy-gamma:
    - shard-apl:          PASS -> FAIL [fdo#104782] / [fdo#108145]

  * igt@kms_cursor_crc@cursor-128x42-onscreen:
    - shard-apl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-256x256-random:
    - shard-glk:          PASS -> FAIL [fdo#103232]

  * igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
    - shard-hsw:          PASS -> FAIL [fdo#105767]

  * igt@kms_draw_crc@draw-method-rgb565-mmap-wc-xtiled:
    - shard-apl:          PASS -> DMESG-WARN [fdo#103558] / [fdo#105602] +1

  * igt@kms_fbcon_fbt@psr:
    - shard-skl:          NOTRUN -> FAIL [fdo#107882]

  * igt@kms_flip@flip-vs-expired-vblank:
    - shard-skl:          PASS -> FAIL [fdo#105363]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
    - shard-apl:          NOTRUN -> FAIL [fdo#103167]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
    - shard-apl:          PASS -> FAIL [fdo#103167] +2

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-onoff:
    - shard-glk:          PASS -> FAIL [fdo#103167] +5

  * igt@kms_frontbuffer_tracking@fbc-rgb101010-draw-render:
    - shard-skl:          PASS -> FAIL [fdo#103167] / [fdo#105682]

  * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-mmap-cpu:
    - shard-skl:          PASS -> FAIL [fdo#105682]

  * igt@kms_frontbuffer_tracking@psr-1p-offscren-pri-indfb-draw-mmap-wc:
    - shard-skl:          PASS -> FAIL [fdo#103167] +1

  * igt@kms_frontbuffer_tracking@psr-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-iclb:         PASS -> FAIL [fdo#103167]

  * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence:
    - shard-skl:          PASS -> FAIL [fdo#103191] / [fdo#107362]

  * igt@kms_plane@pixel-format-pipe-b-planes-source-clamping:
    - shard-skl:          NOTRUN -> DMESG-WARN [fdo#106885]

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-skl:          NOTRUN -> FAIL [fdo#108145] +2

  * igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
    - shard-skl:          PASS -> FAIL [fdo#107815] / [fdo#108145]

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-yf:
    - shard-glk:          PASS -> FAIL [fdo#103166]

  * igt@kms_plane_scaling@pipe-b-scaler-with-pixel-format:
    - shard-iclb:         PASS -> DMESG-WARN [fdo#107724] +2

  * igt@kms_setmode@basic:
    - shard-apl:          PASS -> FAIL [fdo#99912]
    - shard-skl:          NOTRUN -> FAIL [fdo#99912]
    - shard-hsw:          PASS -> FAIL [fdo#99912]
    - shard-kbl:          PASS -> FAIL [fdo#99912]

  * igt@pm_rpm@debugfs-read:
    - shard-iclb:         PASS -> INCOMPLETE [fdo#108840]

  
#### Possible fixes ####

  * igt@gem_cpu_reloc@full:
    - shard-skl:          TIMEOUT [fdo#108248] -> PASS

  * igt@gem_eio@in-flight-suspend:
    - shard-skl:          INCOMPLETE [fdo#104108] / [fdo#107773] -> PASS

  * igt@kms_cursor_crc@cursor-128x42-onscreen:
    - shard-skl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-size-change:
    - shard-glk:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_draw_crc@draw-method-xrgb8888-mmap-cpu-untiled:
    - shard-skl:          FAIL [fdo#108472] -> PASS

  * igt@kms_flip@plain-flip-fb-recreate:
    - shard-apl:          INCOMPLETE [fdo#103927] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
    - shard-iclb:         FAIL [fdo#103167] -> PASS +6

  * igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-blt:
    - shard-glk:          FAIL [fdo#103167] -> PASS +3

  * igt@kms_frontbuffer_tracking@fbcpsr-stridechange:
    - shard-iclb:         FAIL [fdo#105683] -> PASS

  * igt@kms_pipe_crc_basic@read-crc-pipe-c:
    - shard-skl:          FAIL [fdo#107362] -> PASS

  * igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb:
    - shard-glk:          FAIL [fdo#108145] -> PASS

  * igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
    - shard-skl:          FAIL [fdo#107815] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-y:
    - shard-glk:          FAIL [fdo#103166] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-iclb:         FAIL [fdo#103166] -> PASS
    - shard-apl:          FAIL [fdo#103166] -> PASS

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-glk:          DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

  * igt@pm_rpm@basic-rte:
    - shard-iclb:         DMESG-WARN [fdo#108654] -> PASS

  * igt@pm_rpm@modeset-lpsp-stress:
    - shard-skl:          INCOMPLETE [fdo#107807] -> PASS
    - shard-iclb:         DMESG-WARN [fdo#107724] -> PASS +1

  
#### Warnings ####

  * igt@i915_suspend@shrink:
    - shard-snb:          DMESG-WARN [fdo#108784] -> INCOMPLETE [fdo#105411] / [fdo#106886]

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-kbl:          FAIL [fdo#106641] -> DMESG-FAIL [fdo#106641]

  * igt@kms_rotation_crc@multiplane-rotation-cropping-top:
    - shard-iclb:         DMESG-FAIL [fdo#107724] -> DMESG-WARN [fdo#107724]

  * {igt@runner@aborted}:
    - shard-iclb:         FAIL [fdo#108654] / [fdo#108756] -> ( 2 FAIL ) [fdo#108924]

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103158]: https://bugs.freedesktop.org/show_bug.cgi?id=103158
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103558]: https://bugs.freedesktop.org/show_bug.cgi?id=103558
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105602]: https://bugs.freedesktop.org/show_bug.cgi?id=105602
  [fdo#105682]: https://bugs.freedesktop.org/show_bug.cgi?id=105682
  [fdo#105683]: https://bugs.freedesktop.org/show_bug.cgi?id=105683
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#105767]: https://bugs.freedesktop.org/show_bug.cgi?id=105767
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#106885]: https://bugs.freedesktop.org/show_bug.cgi?id=106885
  [fdo#106886]: https://bugs.freedesktop.org/show_bug.cgi?id=106886
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
  [fdo#107773]: https://bugs.freedesktop.org/show_bug.cgi?id=107773
  [fdo#107807]: https://bugs.freedesktop.org/show_bug.cgi?id=107807
  [fdo#107815]: https://bugs.freedesktop.org/show_bug.cgi?id=107815
  [fdo#107882]: https://bugs.freedesktop.org/show_bug.cgi?id=107882
  [fdo#107956]: https://bugs.freedesktop.org/show_bug.cgi?id=107956
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108228]: https://bugs.freedesktop.org/show_bug.cgi?id=108228
  [fdo#108248]: https://bugs.freedesktop.org/show_bug.cgi?id=108248
  [fdo#108470]: https://bugs.freedesktop.org/show_bug.cgi?id=108470
  [fdo#108472]: https://bugs.freedesktop.org/show_bug.cgi?id=108472
  [fdo#108654]: https://bugs.freedesktop.org/show_bug.cgi?id=108654
  [fdo#108756]: https://bugs.freedesktop.org/show_bug.cgi?id=108756
  [fdo#108784]: https://bugs.freedesktop.org/show_bug.cgi?id=108784
  [fdo#108840]: https://bugs.freedesktop.org/show_bug.cgi?id=108840
  [fdo#108924]: https://bugs.freedesktop.org/show_bug.cgi?id=108924
  [fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912


Participating hosts (7 -> 7)
------------------------------

  No changes in participating hosts


Build changes
-------------

    * Linux: CI_DRM_5324 -> Patchwork_11106

  CI_DRM_5324: 93009153b9bde1d65ca49bb1729cd1111591144b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4748: 90c76cb9bb47a5a3ebb34ad6b1a557bc02d39713 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_11106: 66faeac247d224bbd7b299b521b857994003c1dc @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_11106/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Rodrigo Vivi]

On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
> Hi All,
> 
> As discussed a while ago, I would like to see us enable fastboot by
> default, starting with Skylake / GEN9 and newer hardware, so that we can
> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
> 
> During our previous discussion about this Maarten mentioned that a first
> step would be to get this patch from him upstream. So I'm hereby
> resubmitting it, with a small fix. Hopefully the CI will like it better
> this time (if not we will need to investigate) and once this passes CI
> I hope this can be reviewed quickly and we can get this upstream.

I honestly believe the first step is to make sure FBC, PSR, DRRS features
gets enabled somehow with fastboot. Maybe DSC as well?!
Right now as I can remember FBC, PSR, and DRRS will get disabled if fastboot
is used because we just enable those when enabling the pipe.

> 
> I will also be sending out a follow-up patch which actually makes fastboot
> the default on GEN9 and newer, I will mark that as RFC for now since based
> on our previous discussion this patch should be landed first.
> 
> Regards,
> 
> Hans
> 
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Hans de Goede]

Hi,

On 17-12-18 19:43, Rodrigo Vivi wrote:
> On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
>> Hi All,
>>
>> As discussed a while ago, I would like to see us enable fastboot by
>> default, starting with Skylake / GEN9 and newer hardware, so that we can
>> avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
>>
>> During our previous discussion about this Maarten mentioned that a first
>> step would be to get this patch from him upstream. So I'm hereby
>> resubmitting it, with a small fix. Hopefully the CI will like it better
>> this time (if not we will need to investigate) and once this passes CI
>> I hope this can be reviewed quickly and we can get this upstream.
> 
> I honestly believe the first step is to make sure FBC, PSR, DRRS features > gets enabled somehow with fastboot.

That is a good point, FBC will already be enabled on a fastboot as
intel_update_crtc does:

         if (new_plane_state)
                 intel_fbc_enable(intel_crtc, pipe_config, new_plane_state);

Independent of need_modeset() returning true.

PSR indeed stays off, even if i915.enable_psr=1 is passed on the kernel
commandline. I've just completed writing a patch-set (2 patches) fixing
this. I will submit these upstream soon.

DRRS seems to be the same as PSR (I don't have hw to test) I will also
submit 2 patches building on top of the previous 2 which should fix this,
we already allow runtime enabling/disabling through i915_drrs_ctl in
debugfs, so these 2 patches should be fine.


> Maybe DSC as well?!

DSC? :

[hans@shalem linux]$ grep -r dsc  drivers/gpu/drm/i915
[hans@shalem linux]$

> Right now as I can remember FBC, PSR, and DRRS will get disabled if fastboot
> is used because we just enable those when enabling the pipe.

You're right for PSR and DRRS, as Maarten just found out FBC has the
opposite problem, we don't turn it off on a fastset when it was enabled and we
decide it should no longer be enabled.

Regards,

Hans

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH 0/1] drm/i915: Enable fastset by default, except on initial modeset

[Rodrigo Vivi]

On Tue, Dec 18, 2018 at 05:07:34PM +0100, Hans de Goede wrote:
> Hi,
> 
> On 17-12-18 19:43, Rodrigo Vivi wrote:
> > On Mon, Dec 17, 2018 at 03:23:14PM +0100, Hans de Goede wrote:
> > > Hi All,
> > > 
> > > As discussed a while ago, I would like to see us enable fastboot by
> > > default, starting with Skylake / GEN9 and newer hardware, so that we can
> > > avoid an unnecessary modeset at boot and move to a truely flickerfree boot.
> > > 
> > > During our previous discussion about this Maarten mentioned that a first
> > > step would be to get this patch from him upstream. So I'm hereby
> > > resubmitting it, with a small fix. Hopefully the CI will like it better
> > > this time (if not we will need to investigate) and once this passes CI
> > > I hope this can be reviewed quickly and we can get this upstream.
> > 
> > I honestly believe the first step is to make sure FBC, PSR, DRRS features > gets enabled somehow with fastboot.
> 
> That is a good point, FBC will already be enabled on a fastboot as
> intel_update_crtc does:
> 
>         if (new_plane_state)
>                 intel_fbc_enable(intel_crtc, pipe_config, new_plane_state);

oh cool!

> 
> Independent of need_modeset() returning true.
> 
> PSR indeed stays off, even if i915.enable_psr=1 is passed on the kernel
> commandline. I've just completed writing a patch-set (2 patches) fixing
> this. I will submit these upstream soon.

cool, thanks!

> 
> DRRS seems to be the same as PSR (I don't have hw to test) I will also
> submit 2 patches building on top of the previous 2 which should fix this,
> we already allow runtime enabling/disabling through i915_drrs_ctl in
> debugfs, so these 2 patches should be fine.

yeap, I think so

> 
> 
> > Maybe DSC as well?!
> 
> DSC? :

VESA's Display Stream Compression

> 
> [hans@shalem linux]$ grep -r dsc  drivers/gpu/drm/i915
> [hans@shalem linux]$

*** intel_ddi.c:
intel_ddi_pre_enable_dp[3211]  intel_dsc_enable(encoder, crtc_state);

*** intel_vdsc.c:
intel_dsc_enable[1018]         void intel_dsc_enable(struct intel_encoder *encoder,

> 
> > Right now as I can remember FBC, PSR, and DRRS will get disabled if fastboot
> > is used because we just enable those when enabling the pipe.
> 
> You're right for PSR and DRRS, as Maarten just found out FBC has the
> opposite problem, we don't turn it off on a fastset when it was enabled and we
> decide it should no longer be enabled.
> 
> Regards,
> 
> Hans
> 

Thanks a lot for this work,
Rodrigo.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel