* [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-05 13:20 ` Michal Simek 0 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2018-12-05 13:20 UTC (permalink / raw) To: linux-kernel, monstr, michal.simek, Greg Kroah-Hartman, Shubhrajyoti Datta Cc: Jiri Slaby, linux-serial, linux-arm-kernel From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Initialise the device wakeup. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 379242b96790..0140644391df 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1624,6 +1624,7 @@ static int cdns_uart_probe(struct platform_device *pdev) pm_runtime_set_autosuspend_delay(&pdev->dev, UART_AUTOSUSPEND_TIMEOUT); pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); + device_init_wakeup(port->dev, true); #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE /* @@ -1702,6 +1703,7 @@ static int cdns_uart_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); + device_init_wakeup(&pdev->dev, false); #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE if (console_port == port) -- 1.9.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-05 13:20 ` Michal Simek 0 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2018-12-05 13:20 UTC (permalink / raw) To: linux-kernel, monstr, michal.simek, Greg Kroah-Hartman, Shubhrajyoti Datta Cc: linux-arm-kernel, linux-serial, Jiri Slaby From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Initialise the device wakeup. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index 379242b96790..0140644391df 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b/drivers/tty/serial/xilinx_uartps.c @@ -1624,6 +1624,7 @@ static int cdns_uart_probe(struct platform_device *pdev) pm_runtime_set_autosuspend_delay(&pdev->dev, UART_AUTOSUSPEND_TIMEOUT); pm_runtime_set_active(&pdev->dev); pm_runtime_enable(&pdev->dev); + device_init_wakeup(port->dev, true); #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE /* @@ -1702,6 +1703,7 @@ static int cdns_uart_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); pm_runtime_set_suspended(&pdev->dev); pm_runtime_dont_use_autosuspend(&pdev->dev); + device_init_wakeup(&pdev->dev, false); #ifdef CONFIG_SERIAL_XILINX_PS_UART_CONSOLE if (console_port == port) -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup 2018-12-05 13:20 ` Michal Simek @ 2018-12-17 15:15 ` Greg Kroah-Hartman -1 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2018-12-17 15:15 UTC (permalink / raw) To: Michal Simek Cc: linux-kernel, monstr, Shubhrajyoti Datta, Jiri Slaby, linux-serial, linux-arm-kernel On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > Initialise the device wakeup. Why? This says what happened, which you can see from the patch itself, but it does not say why this is needed at all. Also, you sent 4 patches, without any numbering, so I have no idea what order to apply them in. Please fix the changelog entries up and send this as a patch series so that I can correctly apply them. thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-17 15:15 ` Greg Kroah-Hartman 0 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2018-12-17 15:15 UTC (permalink / raw) To: Michal Simek Cc: monstr, Shubhrajyoti Datta, linux-kernel, linux-serial, Jiri Slaby, linux-arm-kernel On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: > From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > > Initialise the device wakeup. Why? This says what happened, which you can see from the patch itself, but it does not say why this is needed at all. Also, you sent 4 patches, without any numbering, so I have no idea what order to apply them in. Please fix the changelog entries up and send this as a patch series so that I can correctly apply them. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup 2018-12-17 15:15 ` Greg Kroah-Hartman (?) @ 2018-12-17 15:29 ` Michal Simek -1 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2018-12-17 15:29 UTC (permalink / raw) To: Greg Kroah-Hartman, Michal Simek Cc: monstr, Shubhrajyoti Datta, linux-kernel, linux-serial, Jiri Slaby, linux-arm-kernel On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: >> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> >> >> Initialise the device wakeup. > > Why? This says what happened, which you can see from the patch itself, > but it does not say why this is needed at all. We will fix this. > > Also, you sent 4 patches, without any numbering, so I have no idea what > order to apply them in. > > Please fix the changelog entries up and send this as a patch series so > that I can correctly apply them. They are all independent that's why I have sent them separately as single patches. Thanks, Michal ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-17 15:29 ` Michal Simek 0 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2018-12-17 15:29 UTC (permalink / raw) To: Greg Kroah-Hartman, Michal Simek Cc: linux-kernel, monstr, Shubhrajyoti Datta, Jiri Slaby, linux-serial, linux-arm-kernel On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: >> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> >> >> Initialise the device wakeup. > > Why? This says what happened, which you can see from the patch itself, > but it does not say why this is needed at all. We will fix this. > > Also, you sent 4 patches, without any numbering, so I have no idea what > order to apply them in. > > Please fix the changelog entries up and send this as a patch series so > that I can correctly apply them. They are all independent that's why I have sent them separately as single patches. Thanks, Michal ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-17 15:29 ` Michal Simek 0 siblings, 0 replies; 9+ messages in thread From: Michal Simek @ 2018-12-17 15:29 UTC (permalink / raw) To: Greg Kroah-Hartman, Michal Simek Cc: monstr, Shubhrajyoti Datta, linux-kernel, linux-serial, Jiri Slaby, linux-arm-kernel On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: >> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> >> >> Initialise the device wakeup. > > Why? This says what happened, which you can see from the patch itself, > but it does not say why this is needed at all. We will fix this. > > Also, you sent 4 patches, without any numbering, so I have no idea what > order to apply them in. > > Please fix the changelog entries up and send this as a patch series so > that I can correctly apply them. They are all independent that's why I have sent them separately as single patches. Thanks, Michal _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup 2018-12-17 15:29 ` Michal Simek @ 2018-12-17 15:44 ` Greg Kroah-Hartman -1 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2018-12-17 15:44 UTC (permalink / raw) To: Michal Simek Cc: linux-kernel, monstr, Shubhrajyoti Datta, Jiri Slaby, linux-serial, linux-arm-kernel On Mon, Dec 17, 2018 at 04:29:56PM +0100, Michal Simek wrote: > On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: > >> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > >> > >> Initialise the device wakeup. > > > > Why? This says what happened, which you can see from the patch itself, > > but it does not say why this is needed at all. > > We will fix this. > > > > > Also, you sent 4 patches, without any numbering, so I have no idea what > > order to apply them in. > > > > Please fix the changelog entries up and send this as a patch series so > > that I can correctly apply them. > > They are all independent that's why I have sent them separately as > single patches. But when you modify the same file, how am I supposed to know that? thanks, greg k-h ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] serial: uartps: Add the device_init_wakeup @ 2018-12-17 15:44 ` Greg Kroah-Hartman 0 siblings, 0 replies; 9+ messages in thread From: Greg Kroah-Hartman @ 2018-12-17 15:44 UTC (permalink / raw) To: Michal Simek Cc: monstr, Shubhrajyoti Datta, linux-kernel, linux-serial, Jiri Slaby, linux-arm-kernel On Mon, Dec 17, 2018 at 04:29:56PM +0100, Michal Simek wrote: > On 17. 12. 18 16:15, Greg Kroah-Hartman wrote: > > On Wed, Dec 05, 2018 at 02:20:11PM +0100, Michal Simek wrote: > >> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com> > >> > >> Initialise the device wakeup. > > > > Why? This says what happened, which you can see from the patch itself, > > but it does not say why this is needed at all. > > We will fix this. > > > > > Also, you sent 4 patches, without any numbering, so I have no idea what > > order to apply them in. > > > > Please fix the changelog entries up and send this as a patch series so > > that I can correctly apply them. > > They are all independent that's why I have sent them separately as > single patches. But when you modify the same file, how am I supposed to know that? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-12-17 15:45 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-12-05 13:20 [PATCH] serial: uartps: Add the device_init_wakeup Michal Simek 2018-12-05 13:20 ` Michal Simek 2018-12-17 15:15 ` Greg Kroah-Hartman 2018-12-17 15:15 ` Greg Kroah-Hartman 2018-12-17 15:29 ` Michal Simek 2018-12-17 15:29 ` Michal Simek 2018-12-17 15:29 ` Michal Simek 2018-12-17 15:44 ` Greg Kroah-Hartman 2018-12-17 15:44 ` Greg Kroah-Hartman
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.