All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/7] drm/ch7006: Stop using drm_crtc_force_disable
@ 2018-12-17 19:42 Daniel Vetter
  2018-12-17 19:42 ` [PATCH 2/7] drm/nouveau: " Daniel Vetter
                   ` (6 more replies)
  0 siblings, 7 replies; 25+ messages in thread
From: Daniel Vetter @ 2018-12-17 19:42 UTC (permalink / raw)
  To: DRI Development; +Cc: Alex Deucher, Daniel Vetter, Daniel Vetter

The correct way for legacy drivers to update properties that need to
do a full modeset, is to do a full modeset.

Note that we don't need to call the drm_mode_config_internal helper
because we're not changing any of the refcounted paramters.

v2: Fixup error handling (Ville). Since the old code didn't bother
I decided to just delete it instead of adding even more code for just
error handling.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com> (v1)
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/i2c/ch7006_drv.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c
index 544a8a2d3562..b91e48d2190d 100644
--- a/drivers/gpu/drm/i2c/ch7006_drv.c
+++ b/drivers/gpu/drm/i2c/ch7006_drv.c
@@ -359,10 +359,10 @@ static int ch7006_encoder_set_property(struct drm_encoder *encoder,
 	if (modes_changed) {
 		drm_helper_probe_single_connector_modes(connector, 0, 0);
 
-		/* Disable the crtc to ensure a full modeset is
-		 * performed whenever it's turned on again. */
 		if (crtc)
-			drm_crtc_force_disable(crtc);
+			drm_crtc_helper_set_mode(crtc, &crtc->mode,
+						 crtc->x, crtc->y,
+						 crtc->primary->fb);
 	}
 
 	return 0;
-- 
2.20.0.rc1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 25+ messages in thread

end of thread, other threads:[~2019-01-12 12:04 UTC | newest]

Thread overview: 25+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 19:42 [PATCH 1/7] drm/ch7006: Stop using drm_crtc_force_disable Daniel Vetter
2018-12-17 19:42 ` [PATCH 2/7] drm/nouveau: " Daniel Vetter
2018-12-17 19:42 ` [PATCH 3/7] drm: Unexport drm_crtc_force_disable Daniel Vetter
2018-12-17 19:43 ` [PATCH 5/7] drm/arc: Don't set the dpms hook Daniel Vetter
2019-01-11 15:41   ` Noralf Trønnes
2018-12-17 19:43 ` [PATCH 6/7] drm/tda998x: Don't set " Daniel Vetter
2019-01-11 15:41   ` Noralf Trønnes
2019-01-11 21:55     ` Daniel Vetter
2019-01-11 22:22       ` Russell King - ARM Linux
2019-01-12 12:03         ` Daniel Vetter
     [not found] ` <20181217194303.14397-1-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-12-17 19:43   ` [PATCH 4/7] drm: Move the legacy kms disable_all helper to crtc helpers Daniel Vetter
2018-12-17 19:43   ` [PATCH 7/7] drm: Split out drm_probe_helper.h Daniel Vetter
2018-12-17 19:43     ` Daniel Vetter
2018-12-17 20:47     ` [Intel-gfx] " Rodrigo Vivi
     [not found]     ` <20181217194303.14397-7-daniel.vetter-/w4YWyX8dFk@public.gmane.org>
2018-12-17 20:47       ` Rodrigo Vivi
2018-12-17 20:47         ` Rodrigo Vivi
2018-12-18  9:27         ` Benjamin Gaignard
2018-12-18  9:27         ` Benjamin Gaignard
2018-12-18  9:27           ` Benjamin Gaignard
     [not found]           ` <CA+M3ks7+gd6zSsoQ1861nEYddObwPXU9RmD_KGP=Si2KyV6LhA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2019-01-11 14:56             ` Daniel Vetter
2019-01-11 14:56               ` Daniel Vetter
2019-01-11 14:56           ` Daniel Vetter
2019-01-11 14:56           ` Daniel Vetter
2018-12-17 19:43 ` Daniel Vetter
2018-12-17 19:43 ` Daniel Vetter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.