From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: "Paul Mackerras" <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
"Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()
Date: Tue, 18 Dec 2018 04:05:38 +0100 [thread overview]
Message-ID: <20181218030538.GA24278@latitude> (raw)
In-Reply-To: <18ba3a7c-ebfa-66aa-e231-b56985d0e89a@c-s.fr>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
On Mon, Dec 17, 2018 at 10:29:18AM +0100, Christophe Leroy wrote:
> > With patches 1-3:
> > [ 0.000000] setbat(0, c0000000, 00000000, 01000000, 311)
> > [ 0.000000] setbat(2, c1000000, 01000000, 00800000, 311)
> > [ 0.000000] setbat(4, d0000000, 10000000, 02000000, 791)
>
> What we see is that BAT0 is not used in the origin. I have always wondered
> the reason, maybe there is something odd behind and BAT0 shall no ne used.
>
> Could you try and modify find_free_bat() so that it starts at b = 1 instead
> of b = 0 ?
In this case, setbat is called with index 2, 3, and 4, but the Wii still
doesn't boot.
> > According to arch/powerpc/include/asm/book3s/32/hash.h,
> > - 0x591 = _PAGE_RW | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_COHERENT | _PAGE_PRESENT
> > - 0x311 = _PAGE_EXEC | _PAGE_ACCESSED | _PAGE_COHERENT | _PAGE_PRESENT
> > - 0x791 = _PAGE_RW | _PAGE_EXEC | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_COHERENT | _PAGE_PRESENT
> >
>
> Yes, patch 1 added _PAGE_EXEC which explains this 0x200.
> Do you confirm it still works well with only patch 1 ?
Patch 1 alone boots to userspace.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linuxppc-dev@lists.ozlabs.org,
"Paul Mackerras" <paulus@samba.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram()
Date: Tue, 18 Dec 2018 04:05:38 +0100 [thread overview]
Message-ID: <20181218030538.GA24278@latitude> (raw)
In-Reply-To: <18ba3a7c-ebfa-66aa-e231-b56985d0e89a@c-s.fr>
[-- Attachment #1: Type: text/plain, Size: 1146 bytes --]
On Mon, Dec 17, 2018 at 10:29:18AM +0100, Christophe Leroy wrote:
> > With patches 1-3:
> > [ 0.000000] setbat(0, c0000000, 00000000, 01000000, 311)
> > [ 0.000000] setbat(2, c1000000, 01000000, 00800000, 311)
> > [ 0.000000] setbat(4, d0000000, 10000000, 02000000, 791)
>
> What we see is that BAT0 is not used in the origin. I have always wondered
> the reason, maybe there is something odd behind and BAT0 shall no ne used.
>
> Could you try and modify find_free_bat() so that it starts at b = 1 instead
> of b = 0 ?
In this case, setbat is called with index 2, 3, and 4, but the Wii still
doesn't boot.
> > According to arch/powerpc/include/asm/book3s/32/hash.h,
> > - 0x591 = _PAGE_RW | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_COHERENT | _PAGE_PRESENT
> > - 0x311 = _PAGE_EXEC | _PAGE_ACCESSED | _PAGE_COHERENT | _PAGE_PRESENT
> > - 0x791 = _PAGE_RW | _PAGE_EXEC | _PAGE_ACCESSED | _PAGE_DIRTY | _PAGE_COHERENT | _PAGE_PRESENT
> >
>
> Yes, patch 1 added _PAGE_EXEC which explains this 0x200.
> Do you confirm it still works well with only patch 1 ?
Patch 1 alone boots to userspace.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-18 3:13 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 19:00 [PATCH v1 00/13] powerpc/32s: Use BATs for STRICT_KERNEL_RWX Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 01/13] powerpc/mm: add exec protection on powerpc 603 Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 02/13] powerpc/mm/32: add base address to mmu_mapin_ram() Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 03/13] powerpc/mm/32s: rework mmu_mapin_ram() Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-12-03 21:55 ` Jonathan Neuschäfer
2018-12-03 21:55 ` Jonathan Neuschäfer
2018-12-13 12:16 ` Christophe Leroy
2018-12-13 12:16 ` Christophe Leroy
2018-12-13 14:51 ` Christophe Leroy
2018-12-13 14:51 ` Christophe Leroy
2018-12-17 1:28 ` Jonathan Neuschäfer
2018-12-17 1:28 ` Jonathan Neuschäfer
2018-12-17 9:29 ` Christophe Leroy
2018-12-17 9:29 ` Christophe Leroy
2018-12-18 3:05 ` Jonathan Neuschäfer [this message]
2018-12-18 3:05 ` Jonathan Neuschäfer
2018-12-18 9:18 ` Christophe Leroy
2018-12-18 9:18 ` Christophe Leroy
2018-12-18 14:07 ` Jonathan Neuschäfer
2018-12-18 14:07 ` Jonathan Neuschäfer
2018-12-18 14:15 ` Christophe Leroy
2018-12-18 14:15 ` Christophe Leroy
2018-12-18 14:55 ` Christophe Leroy
2018-12-18 14:55 ` Christophe Leroy
2018-12-18 15:04 ` Christophe Leroy
2018-12-18 15:04 ` Christophe Leroy
2018-12-18 17:04 ` Jonathan Neuschäfer
2018-12-18 17:04 ` Jonathan Neuschäfer
2018-12-18 18:13 ` Christophe Leroy
2018-12-18 18:13 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 04/13] powerpc/mm/32s: use generic mmu_mapin_ram() for all blocks Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 05/13] powerpc/wii: remove wii_mmu_mapin_mem2() Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 06/13] powerpc/mm/32s: use _PAGE_EXEC in setbat() Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 07/13] powerpc/mm/32s: add setibat() clearibat() and update_bats() Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 08/13] powerpc/32: add helper to write into segment registers Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 09/13] powerpc/mmu: add is_strict_kernel_rwx() helper Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 10/13] powerpc/kconfig: define PAGE_SHIFT inside Kconfig Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 11/13] powerpc/kconfig: define CONFIG_DATA_SHIFT and CONFIG_ETEXT_SHIFT Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 12/13] powerpc/mm/32s: Use BATs for STRICT_KERNEL_RWX Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
2018-11-29 19:00 ` [PATCH v1 13/13] powerpc/kconfig: make _etext and data areas alignment configurable on Book3s 32 Christophe Leroy
2018-11-29 19:00 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218030538.GA24278@latitude \
--to=j.neuschaefer@gmx.net \
--cc=christophe.leroy@c-s.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.