From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Nathan Chancellor <natechancellor@gmail.com>,
Philipp Reisner <philipp.reisner@linbit.com>,
drbd-dev@lists.linbit.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: Re: [PATCH v2] drbd: Avoid Clang warning about pointless switch statment
Date: Tue, 18 Dec 2018 10:22:02 +0100 [thread overview]
Message-ID: <20181218092202.GJ5026@soda.linbit> (raw)
In-Reply-To: <0110d874-7595-1786-77e3-e2b0daec2327@kernel.dk>
On Mon, Dec 17, 2018 at 10:29:38AM -0700, Jens Axboe wrote:
> > Hi Lars and Philipp,
> >
> > Could you please make sure that this patch and the other one I sent make
> > it into 4.21/5.0? I am not sure when you were planning on sending the
> > pull request to Jens that you mentioned in the other thread but I've
> > noticed most maintainers typically send their requests for the impending
> > merge window around -rc7 or so and I wanted to make sure it was on your
> > radar.
I'm sorry.
From my point of view, "fixing the pointless switch" is just "pointless",
so it (again) fell through. I get it that it is important to others,
and getting rid of Clang warnings is a good thing. So sorry again.
> It needs to get here now, but drbd hasn't really sent anything in for
> about a year,
Last actual fix was 2018-06-25 64dafbc9530c drbd: fix access after free
so almost six month, yes.
> so I'm starting to doubt how maintained it is at this
> point.
Oh, it is maintained. It is just happens to be "stable".
We don't add new features there,
and I'm currently not aware of any misbehavior.
I'll prepare a pull request containing this,
the other Clang warning patch from Nathan,
and possibly other small stuff that accumulated,
if I can find any, and send that out later today.
Thanks for the reminder,
Lars
WARNING: multiple messages have this Message-ID (diff)
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Philipp Reisner <philipp.reisner@linbit.com>,
linux-block@vger.kernel.org,
Nathan Chancellor <natechancellor@gmail.com>,
drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH v2] drbd: Avoid Clang warning about pointless switch statment
Date: Tue, 18 Dec 2018 10:22:02 +0100 [thread overview]
Message-ID: <20181218092202.GJ5026@soda.linbit> (raw)
In-Reply-To: <0110d874-7595-1786-77e3-e2b0daec2327@kernel.dk>
On Mon, Dec 17, 2018 at 10:29:38AM -0700, Jens Axboe wrote:
> > Hi Lars and Philipp,
> >
> > Could you please make sure that this patch and the other one I sent make
> > it into 4.21/5.0? I am not sure when you were planning on sending the
> > pull request to Jens that you mentioned in the other thread but I've
> > noticed most maintainers typically send their requests for the impending
> > merge window around -rc7 or so and I wanted to make sure it was on your
> > radar.
I'm sorry.
From my point of view, "fixing the pointless switch" is just "pointless",
so it (again) fell through. I get it that it is important to others,
and getting rid of Clang warnings is a good thing. So sorry again.
> It needs to get here now, but drbd hasn't really sent anything in for
> about a year,
Last actual fix was 2018-06-25 64dafbc9530c drbd: fix access after free
so almost six month, yes.
> so I'm starting to doubt how maintained it is at this
> point.
Oh, it is maintained. It is just happens to be "stable".
We don't add new features there,
and I'm currently not aware of any misbehavior.
I'll prepare a pull request containing this,
the other Clang warning patch from Nathan,
and possibly other small stuff that accumulated,
if I can find any, and send that out later today.
Thanks for the reminder,
Lars
next prev parent reply other threads:[~2018-12-18 9:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-02 17:14 [PATCH RESEND] drbd: avoid clang warning about pointless switch statement Nathan Chancellor
2018-10-02 17:14 ` [Drbd-dev] " Nathan Chancellor
2018-10-04 19:18 ` Lars Ellenberg
2018-10-04 19:18 ` [Drbd-dev] " Lars Ellenberg
2018-10-04 19:22 ` Nathan Chancellor
2018-10-04 19:22 ` [Drbd-dev] " Nathan Chancellor
2018-10-04 20:09 ` [PATCH v2] drbd: Avoid Clang warning about pointless switch statment Nathan Chancellor
2018-10-04 20:09 ` [Drbd-dev] " Nathan Chancellor
2018-12-17 17:24 ` Nathan Chancellor
2018-12-17 17:29 ` Jens Axboe
2018-12-17 17:29 ` [Drbd-dev] " Jens Axboe
2018-12-18 9:22 ` Lars Ellenberg [this message]
2018-12-18 9:22 ` Lars Ellenberg
2018-12-18 13:29 ` Jens Axboe
2018-12-18 13:29 ` [Drbd-dev] " Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218092202.GJ5026@soda.linbit \
--to=lars.ellenberg@linbit.com \
--cc=arnd@arndb.de \
--cc=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.