From: Borislav Petkov <bp@alien8.de>
To: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Petr Mladek <pmladek@suse.com>,
Steven Rostedt <rostedt@goodmis.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [RFC][PATCH] printk: increase devkmsg write() ratelimit
Date: Tue, 18 Dec 2018 12:47:09 +0100 [thread overview]
Message-ID: <20181218114709.GF7485@zn.tnic> (raw)
In-Reply-To: <20181218111701.GA32522@jagdpanzerIV>
On Tue, Dec 18, 2018 at 08:17:01PM +0900, Sergey Senozhatsky wrote:
> On (12/18/18 11:48), Peter Zijlstra wrote:
> > > I know that there is a "kernel.printk_devkmsg" interface; do we
> > > expect every systemd-enabled distro to find that out and to tweak
> > > kernel.printk_devkmsg or shall we change the default devkmsg
> > > ratelimit instead?
> >
> > How about we complain to systemd instead?
>
> We certainly can. As far as I understand, they log shutdown events
> (including errors and warnings): what they kill, what they stop,
> what they umount, etc. The more partitions, services are running
> (I guess), the more things they need to umount, kill, stop; hence,
> the more messages. I kinda can imagine what they will answer ;)
>
> The below (and a bunch of other) messages are getting ratelimited.
> I'm not sure what will happen should any of those steps fail and
> print warning-s. My guess would be that we probably can ratelimit
> those warnings:
>
> ...
> systemd[1]: Unmounting /home...
> systemd[1]: Unmounting Temporary Directory (/tmp)...
> systemd[1]: Unmounted Temporary Directory (/tmp).
> systemd[1]: Stopped target Swap.
> systemd[1]: Unmounted /boot.
> systemd[1]: Stopped File System Check on /dev/disk/by-uuid/a0737dff-e797-44f0-aea7-d0df1107ff63.
> systemd[1]: Stopped File System Check on /dev/disk/by-uuid/5d773b72-e200-4d11-a219-176d62a16d8d.
> systemd[1]: Unmounted /home.
> systemd[1]: Stopped File System Check on /dev/disk/by-uuid/35319ddc-9b92-4ab0-aaa4-9922db636a5e.
> systemd[1]: Unmounted /media/edev.
> systemd[1]: Stopped File System Check on /dev/disk/by-uuid/da00daaf-5601-4531-912e-bd69103b379d.
> systemd[1]: Unmounted /media/dump.
> systemd[1]: Reached target Unmount All Filesystems.
> systemd[1]: Stopped File System Check on /dev/disk/by-uuid/b52da2df-161b-4c33-b700-277d95b9672f.
> systemd[1]: Removed slice system-systemd\x2dfsck.slice.
> systemd[1]: Stopped target Local File Systems (Pre).
> systemd[1]: Stopped Create Static Device Nodes in /dev.
> systemd[1]: Stopped Create System Users.
> systemd[1]: Stopped Remount Root and Kernel File Systems.
> systemd[1]: Reached target Shutdown.
> systemd[1]: Reached target Final Step.
> systemd[1]: Starting Reboot...
And we wanna see all those "very useful" messages in dmesg because...?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-12-18 11:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 9:18 [RFC][PATCH] printk: increase devkmsg write() ratelimit Sergey Senozhatsky
2018-12-18 10:48 ` Peter Zijlstra
2018-12-18 11:17 ` Sergey Senozhatsky
2018-12-18 11:29 ` Peter Zijlstra
2018-12-18 13:09 ` Sergey Senozhatsky
2018-12-18 11:47 ` Borislav Petkov [this message]
2018-12-18 13:07 ` Sergey Senozhatsky
2018-12-18 14:26 ` Borislav Petkov
2018-12-18 14:55 ` Sergey Senozhatsky
2018-12-18 15:03 ` Borislav Petkov
2018-12-18 15:14 ` Sergey Senozhatsky
2018-12-18 15:24 ` Borislav Petkov
2018-12-18 16:52 ` Sergey Senozhatsky
2018-12-18 17:21 ` Peter Zijlstra
2018-12-18 17:37 ` Steven Rostedt
2018-12-19 8:50 ` Petr Mladek
2018-12-20 11:35 ` Sergey Senozhatsky
2018-12-20 13:58 ` Steven Rostedt
2018-12-21 7:32 ` Sergey Senozhatsky
2018-12-18 17:47 ` Borislav Petkov
2018-12-19 1:46 ` Sergey Senozhatsky
2018-12-18 14:02 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218114709.GF7485@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.