* [PATCH 4/7] drm: i915: Delete base.id prints
@ 2018-12-18 13:38 ` Shayenne Moura
0 siblings, 0 replies; 9+ messages in thread
From: Shayenne Moura @ 2018-12-18 13:38 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie
Cc: dri-devel, linux-kernel
This patch removes base.id prints from drm_display_mode
objects in i915 files. It removes dependency from drm_mode_object.
Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 7f455bca528e..61dd7bb3fa85 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
for (i = 0; i < tabs; i++)
seq_putc(m, '\t');
- seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
- mode->base.id, mode->name,
+ seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
+ mode->name,
mode->vrefresh, mode->clock,
mode->hdisplay, mode->hsync_start,
mode->hsync_end, mode->htotal,
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
2018-12-18 13:38 ` Shayenne Moura
@ 2018-12-19 13:09 ` Jani Nikula
-1 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2018-12-19 13:09 UTC (permalink / raw)
To: Shayenne Moura, Maarten Lankhorst, Maxime Ripard, Sean Paul,
David Airlie
Cc: linux-kernel, dri-devel
On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.
As said, this could expand on the *why*. With that fixed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
as well as acked for merging via drm-misc.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
@ 2018-12-19 13:09 ` Jani Nikula
0 siblings, 0 replies; 9+ messages in thread
From: Jani Nikula @ 2018-12-19 13:09 UTC (permalink / raw)
To: Shayenne Moura, Maarten Lankhorst, Maxime Ripard, Sean Paul,
David Airlie
Cc: linux-kernel, dri-devel
On Tue, 18 Dec 2018, Shayenne Moura <shayenneluzmoura@gmail.com> wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.
As said, this could expand on the *why*. With that fixed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
as well as acked for merging via drm-misc.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
2018-12-18 13:38 ` Shayenne Moura
@ 2018-12-19 13:12 ` Daniel Vetter
-1 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2018-12-19 13:12 UTC (permalink / raw)
To: Shayenne Moura
Cc: Maxime Ripard, linux-kernel, dri-devel, David Airlie, Sean Paul
On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
Again I think better to switch to DRM_MODE_FMT/ARG.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
@ 2018-12-19 13:12 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2018-12-19 13:12 UTC (permalink / raw)
To: Shayenne Moura
Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
linux-kernel, dri-devel
On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> This patch removes base.id prints from drm_display_mode
> objects in i915 files. It removes dependency from drm_mode_object.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
Again I think better to switch to DRM_MODE_FMT/ARG.
-Daniel
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 7f455bca528e..61dd7bb3fa85 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> for (i = 0; i < tabs; i++)
> seq_putc(m, '\t');
>
> - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> - mode->base.id, mode->name,
> + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> + mode->name,
> mode->vrefresh, mode->clock,
> mode->hdisplay, mode->hsync_start,
> mode->hsync_end, mode->htotal,
> --
> 2.17.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
2018-12-19 13:12 ` Daniel Vetter
(?)
@ 2018-12-19 17:29 ` Shayenne Moura
2018-12-19 18:27 ` Daniel Vetter
-1 siblings, 1 reply; 9+ messages in thread
From: Shayenne Moura @ 2018-12-19 17:29 UTC (permalink / raw)
To: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
linux-kernel, dri-devel
On 12/19, Daniel Vetter wrote:
> On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > This patch removes base.id prints from drm_display_mode
> > objects in i915 files. It removes dependency from drm_mode_object.
> >
> > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
>
> Again I think better to switch to DRM_MODE_FMT/ARG.
> -Daniel
>
This one has a different print style. Is it okay to change to DRM_MODE_FMT?
Best,
Shayenne
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 7f455bca528e..61dd7bb3fa85 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > for (i = 0; i < tabs; i++)
> > seq_putc(m, '\t');
> >
> > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > - mode->base.id, mode->name,
> > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > + mode->name,
> > mode->vrefresh, mode->clock,
> > mode->hdisplay, mode->hsync_start,
> > mode->hsync_end, mode->htotal,
> > --
> > 2.17.1
> >
> > _______________________________________________
> > dri-devel mailing list
> > dri-devel@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
2018-12-19 17:29 ` Shayenne Moura
@ 2018-12-19 18:27 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2018-12-19 18:27 UTC (permalink / raw)
To: Shayenne Moura
Cc: Maxime Ripard, Linux Kernel Mailing List, dri-devel, David Airlie,
Sean Paul
On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura
<shayenneluzmoura@gmail.com> wrote:
>
> On 12/19, Daniel Vetter wrote:
> > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > > This patch removes base.id prints from drm_display_mode
> > > objects in i915 files. It removes dependency from drm_mode_object.
> > >
> > > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> >
> > Again I think better to switch to DRM_MODE_FMT/ARG.
> > -Daniel
> >
>
> This one has a different print style. Is it okay to change to DRM_MODE_FMT?
Yeah, standardizing sounds good, just mention in the commit message if
something has changed. This is all debug information, so no issue if
we change the output format slightly.
-Daniel
>
> Best,
> Shayenne
> > > ---
> > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 7f455bca528e..61dd7bb3fa85 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > > for (i = 0; i < tabs; i++)
> > > seq_putc(m, '\t');
> > >
> > > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > - mode->base.id, mode->name,
> > > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > + mode->name,
> > > mode->vrefresh, mode->clock,
> > > mode->hdisplay, mode->hsync_start,
> > > mode->hsync_end, mode->htotal,
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 4/7] drm: i915: Delete base.id prints
@ 2018-12-19 18:27 ` Daniel Vetter
0 siblings, 0 replies; 9+ messages in thread
From: Daniel Vetter @ 2018-12-19 18:27 UTC (permalink / raw)
To: Shayenne Moura
Cc: Maarten Lankhorst, Maxime Ripard, Sean Paul, David Airlie,
Linux Kernel Mailing List, dri-devel
On Wed, Dec 19, 2018 at 6:29 PM Shayenne Moura
<shayenneluzmoura@gmail.com> wrote:
>
> On 12/19, Daniel Vetter wrote:
> > On Tue, Dec 18, 2018 at 11:38:21AM -0200, Shayenne Moura wrote:
> > > This patch removes base.id prints from drm_display_mode
> > > objects in i915 files. It removes dependency from drm_mode_object.
> > >
> > > Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>
> >
> > Again I think better to switch to DRM_MODE_FMT/ARG.
> > -Daniel
> >
>
> This one has a different print style. Is it okay to change to DRM_MODE_FMT?
Yeah, standardizing sounds good, just mention in the commit message if
something has changed. This is all debug information, so no issue if
we change the output format slightly.
-Daniel
>
> Best,
> Shayenne
> > > ---
> > > drivers/gpu/drm/i915/i915_debugfs.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > > index 7f455bca528e..61dd7bb3fa85 100644
> > > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > > @@ -2948,8 +2948,8 @@ static void intel_seq_print_mode(struct seq_file *m, int tabs,
> > > for (i = 0; i < tabs; i++)
> > > seq_putc(m, '\t');
> > >
> > > - seq_printf(m, "id %d:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > - mode->base.id, mode->name,
> > > + seq_printf(m, "name:\"%s\" freq %d clock %d hdisp %d hss %d hse %d htot %d vdisp %d vss %d vse %d vtot %d type 0x%x flags 0x%x\n",
> > > + mode->name,
> > > mode->vrefresh, mode->clock,
> > > mode->hdisplay, mode->hsync_start,
> > > mode->hsync_end, mode->htotal,
> > > --
> > > 2.17.1
> > >
> > > _______________________________________________
> > > dri-devel mailing list
> > > dri-devel@lists.freedesktop.org
> > > https://lists.freedesktop.org/mailman/listinfo/dri-devel
> >
> > --
> > Daniel Vetter
> > Software Engineer, Intel Corporation
> > http://blog.ffwll.ch
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread