From: Christoph Hellwig <hch@infradead.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: x86@kernel.org, npiggin@gmail.com, linux-mm@kvack.org,
paulus@samba.org, akpm@linux-foundation.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V4 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade
Date: Tue, 18 Dec 2018 09:22:36 -0800 [thread overview]
Message-ID: <20181218172236.GC22729@infradead.org> (raw)
In-Reply-To: <20181218094137.13732-6-aneesh.kumar@linux.ibm.com>
On Tue, Dec 18, 2018 at 03:11:37PM +0530, Aneesh Kumar K.V wrote:
> +EXPORT_SYMBOL(huge_ptep_modify_prot_start);
The only user of this function is the one you added in the last patch
in mm/hugetlb.c, so there is no need to export this function.
> +
> +void huge_ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned long addr,
> + pte_t *ptep, pte_t old_pte, pte_t pte)
> +{
> +
> + if (radix_enabled())
> + return radix__huge_ptep_modify_prot_commit(vma, addr, ptep,
> + old_pte, pte);
> + set_huge_pte_at(vma->vm_mm, addr, ptep, pte);
> +}
> +EXPORT_SYMBOL(huge_ptep_modify_prot_commit);
Same here.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
Cc: npiggin@gmail.com, benh@kernel.crashing.org, paulus@samba.org,
mpe@ellerman.id.au, akpm@linux-foundation.org, x86@kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org
Subject: Re: [PATCH V4 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade
Date: Tue, 18 Dec 2018 09:22:36 -0800 [thread overview]
Message-ID: <20181218172236.GC22729@infradead.org> (raw)
In-Reply-To: <20181218094137.13732-6-aneesh.kumar@linux.ibm.com>
On Tue, Dec 18, 2018 at 03:11:37PM +0530, Aneesh Kumar K.V wrote:
> +EXPORT_SYMBOL(huge_ptep_modify_prot_start);
The only user of this function is the one you added in the last patch
in mm/hugetlb.c, so there is no need to export this function.
> +
> +void huge_ptep_modify_prot_commit(struct vm_area_struct *vma, unsigned long addr,
> + pte_t *ptep, pte_t old_pte, pte_t pte)
> +{
> +
> + if (radix_enabled())
> + return radix__huge_ptep_modify_prot_commit(vma, addr, ptep,
> + old_pte, pte);
> + set_huge_pte_at(vma->vm_mm, addr, ptep, pte);
> +}
> +EXPORT_SYMBOL(huge_ptep_modify_prot_commit);
Same here.
next prev parent reply other threads:[~2018-12-18 17:26 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-18 9:41 [PATCH V4 0/5] NestMMU pte upgrade workaround for mprotect Aneesh Kumar K.V
2018-12-18 9:41 ` Aneesh Kumar K.V
2018-12-18 9:41 ` [PATCH V4 1/5] mm: Update ptep_modify_prot_start/commit to take vm_area_struct as arg Aneesh Kumar K.V
2018-12-18 9:41 ` [PATCH V4 2/5] mm: update ptep_modify_prot_commit to take old pte value " Aneesh Kumar K.V
2018-12-18 9:41 ` [PATCH V4 3/5] arch/powerpc/mm: Nest MMU workaround for mprotect RW upgrade Aneesh Kumar K.V
2018-12-18 9:41 ` Aneesh Kumar K.V
2018-12-18 9:41 ` [PATCH V4 4/5] mm/hugetlb: Add prot_modify_start/commit sequence for hugetlb update Aneesh Kumar K.V
2018-12-18 9:41 ` Aneesh Kumar K.V
2018-12-18 9:41 ` [PATCH V4 5/5] arch/powerpc/mm/hugetlb: NestMMU workaround for hugetlb mprotect RW upgrade Aneesh Kumar K.V
2018-12-18 9:41 ` Aneesh Kumar K.V
2018-12-18 17:22 ` Christoph Hellwig [this message]
2018-12-18 17:22 ` Christoph Hellwig
2018-12-19 3:20 ` Aneesh Kumar K.V
2018-12-19 3:20 ` Aneesh Kumar K.V
2018-12-19 6:31 ` Christoph Hellwig
2018-12-19 6:31 ` Christoph Hellwig
2018-12-20 0:30 ` Benjamin Herrenschmidt
2018-12-20 0:30 ` Benjamin Herrenschmidt
2018-12-20 7:11 ` Christoph Hellwig
2018-12-20 7:11 ` Christoph Hellwig
2018-12-18 17:17 ` [PATCH V4 0/5] NestMMU pte upgrade workaround for mprotect Christoph Hellwig
2018-12-18 17:17 ` Christoph Hellwig
2018-12-18 22:30 ` Benjamin Herrenschmidt
2018-12-18 22:30 ` Benjamin Herrenschmidt
2018-12-19 3:18 ` Aneesh Kumar K.V
2018-12-19 3:18 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218172236.GC22729@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=paulus@samba.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.