All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Sid Hayn <sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Matthias Brugger
	<matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Lorenzo Bianconi
	<lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-wireless
	<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Subject: Re: mt76x[02]u 802.11w support
Date: Wed, 19 Dec 2018 08:47:43 +0100	[thread overview]
Message-ID: <20181219074743.GA3538@redhat.com> (raw)
In-Reply-To: <CAM0KTbCWtwYE3DzmqeHSs3m7A7JojeFFs2_Mp1q5Kg=ySaN0Rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Tue, Dec 18, 2018 at 01:38:54PM -0500, Sid Hayn wrote:
> > > Regarding this case, there is no single commit that add 802.11w support
> > > we could request to add to -stable. It was added together with other
> > > features in:
> > >
> > > commit 0ae976a11b4fb5704b597e103b5189237641c1a1
> > > Author: Lorenzo Bianconi <lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> > > Date:   Thu Sep 6 11:18:41 2018 +0200
> > >
> > >     mt76x0: init hw capabilities
> > >
> > > which depend on switching mt76x0u to mt76-usb layer.
> > >
> > > So I'm not sure how this request should be satisfied.
> >
> > Can you check if adding
> >
> > ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
> In this case I inferred from cotext that it should be
> ieee80211_hw_set(hw, MFP_CAPABLE); hopefully that is correct.

Yeah it is. I copied the line from wrong driver :-) 

> > is sufficient to add support for 802.11w ?
> As a matter of fact it was sufficient.  I can now connect to my AP
> with 802.11w required and prior to this one line change I could not.
> Thanks for taking the time to suggest this, it seems to work well
> enough to connect.  I don't much have a means to test to see if deauth
> frames are properly handled, do you have any test cases you want to
> suggest or are you comfortable enough that it should work properly?

If you using wpa_supplicant, 'wpa_cli disconnect' should
trigger deauth exchange.

Are there errors in dmesg ? If there are many errors, I think
we will need to change EINVAL to EOPNOTSUPP as well.

Thanks
Stanislaw

WARNING: multiple messages have this Message-ID (diff)
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: Sid Hayn <sidhayn@gmail.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	linux-mediatek@lists.infradead.org,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Felix Fietkau <nbd@nbd.name>
Subject: Re: mt76x[02]u 802.11w support
Date: Wed, 19 Dec 2018 08:47:43 +0100	[thread overview]
Message-ID: <20181219074743.GA3538@redhat.com> (raw)
In-Reply-To: <CAM0KTbCWtwYE3DzmqeHSs3m7A7JojeFFs2_Mp1q5Kg=ySaN0Rw@mail.gmail.com>

On Tue, Dec 18, 2018 at 01:38:54PM -0500, Sid Hayn wrote:
> > > Regarding this case, there is no single commit that add 802.11w support
> > > we could request to add to -stable. It was added together with other
> > > features in:
> > >
> > > commit 0ae976a11b4fb5704b597e103b5189237641c1a1
> > > Author: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > > Date:   Thu Sep 6 11:18:41 2018 +0200
> > >
> > >     mt76x0: init hw capabilities
> > >
> > > which depend on switching mt76x0u to mt76-usb layer.
> > >
> > > So I'm not sure how this request should be satisfied.
> >
> > Can you check if adding
> >
> > ieee80211_hw_set(rt2x00dev->hw, MFP_CAPABLE);
> In this case I inferred from cotext that it should be
> ieee80211_hw_set(hw, MFP_CAPABLE); hopefully that is correct.

Yeah it is. I copied the line from wrong driver :-) 

> > is sufficient to add support for 802.11w ?
> As a matter of fact it was sufficient.  I can now connect to my AP
> with 802.11w required and prior to this one line change I could not.
> Thanks for taking the time to suggest this, it seems to work well
> enough to connect.  I don't much have a means to test to see if deauth
> frames are properly handled, do you have any test cases you want to
> suggest or are you comfortable enough that it should work properly?

If you using wpa_supplicant, 'wpa_cli disconnect' should
trigger deauth exchange.

Are there errors in dmesg ? If there are many errors, I think
we will need to change EINVAL to EOPNOTSUPP as well.

Thanks
Stanislaw

  parent reply	other threads:[~2018-12-19  7:47 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-13 14:26 mt76x[02]u 802.11w support Sid Hayn
2018-12-13 14:26 ` Sid Hayn
     [not found] ` <CAM0KTbBUXJsBfO0=hQgeTGVteym6iuObdyNynWumQnnGY0L3wg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-13 14:39   ` Lorenzo Bianconi
2018-12-13 14:39     ` Lorenzo Bianconi
     [not found]     ` <20181213143947.GA11947-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2018-12-15  3:43       ` Sid Hayn
2018-12-15  3:43         ` Sid Hayn
2018-12-16 10:39         ` Matthias Brugger
2018-12-16 10:39           ` Matthias Brugger
     [not found]           ` <dd275289-99d0-54a8-9ac5-cb137123950a-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-12-17 15:07             ` Sid Hayn
2018-12-17 15:07               ` Sid Hayn
     [not found]               ` <CAM0KTbBV_YZqt6kkrKeY5tRtKn10UOLQY3EyTKPY+zLzht7sgg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-17 15:46                 ` Stanislaw Gruszka
2018-12-17 15:46                   ` Stanislaw Gruszka
     [not found]                   ` <20181217154628.GA4773-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-18  8:09                     ` Stanislaw Gruszka
2018-12-18  8:09                       ` Stanislaw Gruszka
     [not found]                       ` <20181218080939.GA16795-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-18 18:38                         ` Sid Hayn
2018-12-18 18:38                           ` Sid Hayn
     [not found]                           ` <CAM0KTbCWtwYE3DzmqeHSs3m7A7JojeFFs2_Mp1q5Kg=ySaN0Rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-19  7:47                             ` Stanislaw Gruszka [this message]
2018-12-19  7:47                               ` Stanislaw Gruszka
     [not found]                               ` <20181219074743.GA3538-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-12-19 17:08                                 ` Sid Hayn
2018-12-19 17:08                                   ` Sid Hayn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219074743.GA3538@redhat.com \
    --to=sgruszka-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=lorenzo.bianconi-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=nbd-Vt+b4OUoWG0@public.gmane.org \
    --cc=sidhayn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.