All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
To: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
Cc: catalin.marinas-5wv7dgnIgG8@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH dma-mapping tree] arm64: default to the direct mapping in get_arch_dma_ops
Date: Wed, 19 Dec 2018 18:00:34 +0100	[thread overview]
Message-ID: <20181219170034.GA26129@lst.de> (raw)
In-Reply-To: <3a6c8eff-a5dd-6a17-71ed-f480df3801d8-5wv7dgnIgG8@public.gmane.org>

On Wed, Dec 19, 2018 at 04:59:03PM +0000, Robin Murphy wrote:
> On 14/12/2018 15:02, Christoph Hellwig wrote:
>> Otherwise the direct mapping won't work at all given that a NULL
>> dev->dma_ops causes a fallback.  Note that we already explicitly set
>> dev->dma_ops to dma_dummy_ops for dma-incapable devices, so this
>> fallback should not be needed anyway.
>
> Sorry, I'd somehow completely missed that you'd sent a proper patch for 
> this - indeed it looks like the right change to make.
>
> Reviewed-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>

Thanks.  I've added this given that I hadn't pushed out the tree yet.

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Robin Murphy <robin.murphy@arm.com>
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
	iommu@lists.linux-foundation.org, Christoph Hellwig <hch@lst.de>,
	linux-arm-kernel@lists.infradead.org, m.szyprowski@samsung.com
Subject: Re: [PATCH dma-mapping tree] arm64: default to the direct mapping in get_arch_dma_ops
Date: Wed, 19 Dec 2018 18:00:34 +0100	[thread overview]
Message-ID: <20181219170034.GA26129@lst.de> (raw)
In-Reply-To: <3a6c8eff-a5dd-6a17-71ed-f480df3801d8@arm.com>

On Wed, Dec 19, 2018 at 04:59:03PM +0000, Robin Murphy wrote:
> On 14/12/2018 15:02, Christoph Hellwig wrote:
>> Otherwise the direct mapping won't work at all given that a NULL
>> dev->dma_ops causes a fallback.  Note that we already explicitly set
>> dev->dma_ops to dma_dummy_ops for dma-incapable devices, so this
>> fallback should not be needed anyway.
>
> Sorry, I'd somehow completely missed that you'd sent a proper patch for 
> this - indeed it looks like the right change to make.
>
> Reviewed-by: Robin Murphy <robin.murphy@arm.com>

Thanks.  I've added this given that I hadn't pushed out the tree yet.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2018-12-19 17:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 15:02 [PATCH dma-mapping tree] arm64: default to the direct mapping in get_arch_dma_ops Christoph Hellwig
2018-12-14 15:02 ` Christoph Hellwig
     [not found] ` <20181214150240.26427-1-hch-jcswGhMUV9g@public.gmane.org>
2018-12-19 16:55   ` Christoph Hellwig
2018-12-19 16:55     ` Christoph Hellwig
2018-12-28 17:30     ` Liviu Dudau
2018-12-28 17:30       ` Liviu Dudau
     [not found]       ` <20181228173057.GA20342-hOhETlTuV5niMG9XS5x8Mg@public.gmane.org>
2018-12-28 17:59         ` Christoph Hellwig
2018-12-28 17:59           ` Christoph Hellwig
     [not found]           ` <20181228175900.GB16929-jcswGhMUV9g@public.gmane.org>
2018-12-28 22:05             ` Liviu Dudau
2018-12-28 22:05               ` Liviu Dudau
2018-12-19 16:59   ` Robin Murphy
2018-12-19 16:59     ` Robin Murphy
     [not found]     ` <3a6c8eff-a5dd-6a17-71ed-f480df3801d8-5wv7dgnIgG8@public.gmane.org>
2018-12-19 17:00       ` Christoph Hellwig [this message]
2018-12-19 17:00         ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181219170034.GA26129@lst.de \
    --to=hch-jcswghmuv9g@public.gmane.org \
    --cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
    --cc=iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=robin.murphy-5wv7dgnIgG8@public.gmane.org \
    --cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.