From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible
Date: Wed, 19 Dec 2018 11:15:53 -0600 [thread overview]
Message-ID: <20181219171553.GA4469@bogus> (raw)
In-Reply-To: <20181203101547.16835-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
On Mon, Dec 03, 2018 at 03:45:45PM +0530, Jagan Teki wrote:
> GT5663 is capacitive touch controller with customized smart wakeup gestures,
> the existing goodix driver will work by phandle vcc-supply regulator.
>
> So, document compatible and example node for the same.
>
> Signed-off-by: Jagan Teki <jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
> ---
> .../bindings/input/touchscreen/goodix.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 604766e347ce..1898d3dde8e1 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series touchscreen controller
> Required properties:
>
> - compatible : Should be "goodix,gt1151"
> + or "goodix,gt5663"
> or "goodix,gt911"
> or "goodix,gt9110"
> or "goodix,gt912"
> @@ -42,3 +43,15 @@ Example:
>
> /* ... */
> };
> +
> + touchscreen@5d {
> + compatible = "goodix,gt5663";
Just a new compatible doesn't warrant a new example.
> + reg = <0x5d>;
> + vcc-supply = <®_ldo_io0>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>;
> + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */
> + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */
> + touchscreen-inverted-x;
> + touchscreen-inverted-y;
> + };
> --
> 2.18.0.321.gffc6fa0e3
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: devicetree@vger.kernel.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
linux-sunxi@googlegroups.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-input@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible
Date: Wed, 19 Dec 2018 11:15:53 -0600 [thread overview]
Message-ID: <20181219171553.GA4469@bogus> (raw)
In-Reply-To: <20181203101547.16835-7-jagan@amarulasolutions.com>
On Mon, Dec 03, 2018 at 03:45:45PM +0530, Jagan Teki wrote:
> GT5663 is capacitive touch controller with customized smart wakeup gestures,
> the existing goodix driver will work by phandle vcc-supply regulator.
>
> So, document compatible and example node for the same.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> .../bindings/input/touchscreen/goodix.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 604766e347ce..1898d3dde8e1 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series touchscreen controller
> Required properties:
>
> - compatible : Should be "goodix,gt1151"
> + or "goodix,gt5663"
> or "goodix,gt911"
> or "goodix,gt9110"
> or "goodix,gt912"
> @@ -42,3 +43,15 @@ Example:
>
> /* ... */
> };
> +
> + touchscreen@5d {
> + compatible = "goodix,gt5663";
Just a new compatible doesn't warrant a new example.
> + reg = <0x5d>;
> + vcc-supply = <®_ldo_io0>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>;
> + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */
> + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */
> + touchscreen-inverted-x;
> + touchscreen-inverted-y;
> + };
> --
> 2.18.0.321.gffc6fa0e3
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible
Date: Wed, 19 Dec 2018 11:15:53 -0600 [thread overview]
Message-ID: <20181219171553.GA4469@bogus> (raw)
In-Reply-To: <20181203101547.16835-7-jagan@amarulasolutions.com>
On Mon, Dec 03, 2018 at 03:45:45PM +0530, Jagan Teki wrote:
> GT5663 is capacitive touch controller with customized smart wakeup gestures,
> the existing goodix driver will work by phandle vcc-supply regulator.
>
> So, document compatible and example node for the same.
>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> .../bindings/input/touchscreen/goodix.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> index 604766e347ce..1898d3dde8e1 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> +++ b/Documentation/devicetree/bindings/input/touchscreen/goodix.txt
> @@ -3,6 +3,7 @@ Device tree bindings for Goodix GT9xx series touchscreen controller
> Required properties:
>
> - compatible : Should be "goodix,gt1151"
> + or "goodix,gt5663"
> or "goodix,gt911"
> or "goodix,gt9110"
> or "goodix,gt912"
> @@ -42,3 +43,15 @@ Example:
>
> /* ... */
> };
> +
> + touchscreen@5d {
> + compatible = "goodix,gt5663";
Just a new compatible doesn't warrant a new example.
> + reg = <0x5d>;
> + vcc-supply = <®_ldo_io0>;
> + interrupt-parent = <&pio>;
> + interrupts = <7 4 IRQ_TYPE_EDGE_FALLING>;
> + irq-gpios = <&pio 7 4 GPIO_ACTIVE_HIGH>; /* CTP-INT: PH4 */
> + reset-gpios = <&pio 7 8 GPIO_ACTIVE_HIGH>; /* CTP-RST: PH8 */
> + touchscreen-inverted-x;
> + touchscreen-inverted-y;
> + };
> --
> 2.18.0.321.gffc6fa0e3
>
next prev parent reply other threads:[~2018-12-19 17:15 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:15 [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Jagan Teki
2018-12-03 10:15 ` Jagan Teki
[not found] ` <20181203101547.16835-1-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 10:15 ` [PATCH 2/9] mfd: axp20x: Add GPIO/pinctrl support for AXP803 Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` [PATCH 3/9] arm64: allwinner: dts: axp803: Add GPIO DT node Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` [PATCH 4/9] arm64: allwinner: dts: axp803: Set GPIO0/1 pinmux for LD0s Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` [PATCH 5/9] dt-bindings: input: touchscreen: goodix: Document vcc-supply property Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
[not found] ` <20181203101547.16835-5-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 10:41 ` Chen-Yu Tsai
2018-12-03 10:41 ` Chen-Yu Tsai
2018-12-03 10:41 ` Chen-Yu Tsai
2018-12-05 19:56 ` Jagan Teki
2018-12-05 19:56 ` Jagan Teki
[not found] ` <CAMty3ZAd9eZRkBM2Pitp_B+kVLsGjufL6ALMCJ=f7iUL=7SfsQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-12-06 3:01 ` Chen-Yu Tsai
2018-12-06 3:01 ` Chen-Yu Tsai
2018-12-06 3:01 ` Chen-Yu Tsai
2018-12-03 10:15 ` [PATCH 6/9] Input: goodix - Add vcc-supply regulator support Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
[not found] ` <20181203101547.16835-6-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-03 19:13 ` Dmitry Torokhov
2018-12-03 19:13 ` Dmitry Torokhov
2018-12-03 19:13 ` Dmitry Torokhov
2018-12-03 10:15 ` [PATCH 7/9] dt-bindings: input: touchscreen: goodix: Add GT5663 compatible Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
[not found] ` <20181203101547.16835-7-jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2018-12-19 17:15 ` Rob Herring [this message]
2018-12-19 17:15 ` Rob Herring
2018-12-19 17:15 ` Rob Herring
2018-12-03 10:15 ` [PATCH 8/9] Input: goodix - Add GT5663 CTP support Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` [PATCH 9/9] arm64: dts: allwinner: a64-amarula-relic: Add GT5663 CTP node Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:15 ` Jagan Teki
2018-12-03 10:32 ` [PATCH 1/9] dt-bindings: gpio-axp209: Add AXP803 GPIOs compatible (w/ AXP813 fallback) Chen-Yu Tsai
2018-12-03 10:32 ` Chen-Yu Tsai
2018-12-03 10:32 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219171553.GA4469@bogus \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jagan-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.