From: Sasha Levin <sashal@kernel.org>
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: gregkh@linuxfoundation.org, ast@kernel.org, nschichan@freebox.fr,
stable@vger.kernel.org, Russell King <rmk+kernel@armlinux.org.uk>
Subject: Re: [PATCH stable 4.14] bpf, arm: fix emit_ldx_r and emit_mov_i using TMP_REG_1
Date: Wed, 19 Dec 2018 20:57:08 -0500 [thread overview]
Message-ID: <20181220015708.GD86645@sasha-vm> (raw)
In-Reply-To: <4c897861da96ab890fdf9ccf2b78337748a0d4b3.1545255104.git.daniel@iogearbox.net>
On Wed, Dec 19, 2018 at 10:40:42PM +0100, Daniel Borkmann wrote:
>From: Nicolas Schichan <nschichan@freebox.fr>
>
>emit_ldx_r() and emit_a32_mov_i() were both using TMP_REG_1 and
>clashing with each other. Using TMP_REG_2 in emit_ldx_r() fixes
>the issue.
>
>Fixes: ec19e02b343 ("ARM: net: bpf: fix LDX instructions")
>Cc: Russell King <rmk+kernel@armlinux.org.uk>
>Signed-off-by: Nicolas Schichan <nschichan@freebox.fr>
>Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
>---
> [ Note, this has been implicitly fixed upstream by a6eccac507e
> ("ARM: net: bpf: 64-bit accessor functions for BPF registers"),
> so the fix here is a minimal stand-alone fix for 4.14. test_bpf
> suite runs without error after the fix. ]
Queued for 4.14, thank you.
--
Thanks,
Sasha
prev parent reply other threads:[~2018-12-20 1:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 21:40 [PATCH stable 4.14] bpf, arm: fix emit_ldx_r and emit_mov_i using TMP_REG_1 Daniel Borkmann
2018-12-20 1:57 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220015708.GD86645@sasha-vm \
--to=sashal@kernel.org \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=gregkh@linuxfoundation.org \
--cc=nschichan@freebox.fr \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.