From: Christoph Hellwig <hch@infradead.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: jgross@suse.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Oleksandr Andrushchenko <andr2000@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
daniel.vetter@intel.com, xen-devel@lists.xenproject.org,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent
Date: Thu, 20 Dec 2018 07:36:46 -0800 [thread overview]
Message-ID: <20181220153646.GA22997@infradead.org> (raw)
In-Reply-To: <17640791-5306-f7e4-8588-dd39c14e975b@tronnes.org>
On Tue, Dec 18, 2018 at 08:20:22PM +0100, Noralf Trønnes wrote:
> > + if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents,
> > + DMA_BIDIRECTIONAL)) {
>
>
> Are you using the DMA streaming API as a way to flush the caches?
This looks rather broken. Please send the whole patch series to
the iommu list for proper review.
> Does this mean that GFP_USER isn't making the buffer coherent?
How could GFP_USER make memory coherent in any way?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: Oleksandr Andrushchenko <andr2000@gmail.com>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, daniel.vetter@intel.com,
jgross@suse.com, boris.ostrovsky@oracle.com,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Subject: Re: [PATCH] drm/xen-front: Make shmem backed display buffer coherent
Date: Thu, 20 Dec 2018 07:36:46 -0800 [thread overview]
Message-ID: <20181220153646.GA22997@infradead.org> (raw)
In-Reply-To: <17640791-5306-f7e4-8588-dd39c14e975b@tronnes.org>
On Tue, Dec 18, 2018 at 08:20:22PM +0100, Noralf Trønnes wrote:
> > + if (!dma_map_sg(dev->dev, xen_obj->sgt->sgl, xen_obj->sgt->nents,
> > + DMA_BIDIRECTIONAL)) {
>
>
> Are you using the DMA streaming API as a way to flush the caches?
This looks rather broken. Please send the whole patch series to
the iommu list for proper review.
> Does this mean that GFP_USER isn't making the buffer coherent?
How could GFP_USER make memory coherent in any way?
next prev parent reply other threads:[~2018-12-20 15:36 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 10:32 [PATCH] drm/xen-front: Make shmem backed display buffer coherent Oleksandr Andrushchenko
2018-12-13 10:17 ` Oleksandr Andrushchenko
2018-12-13 15:48 ` Daniel Vetter
2018-12-13 15:48 ` Daniel Vetter
2018-12-14 7:09 ` Oleksandr Andrushchenko
2018-12-14 7:09 ` Oleksandr Andrushchenko
2018-12-14 8:35 ` Daniel Vetter
2018-12-17 8:03 ` Oleksandr Andrushchenko
2018-12-17 8:03 ` Oleksandr Andrushchenko
2018-12-14 8:35 ` Daniel Vetter
2018-12-14 7:09 ` Oleksandr Andrushchenko
2018-12-13 10:17 ` Oleksandr Andrushchenko
2018-12-18 19:20 ` Noralf Trønnes
2018-12-18 19:20 ` Noralf Trønnes
2018-12-18 19:20 ` Noralf Trønnes
2018-12-19 8:18 ` Oleksandr Andrushchenko
2018-12-19 8:18 ` Oleksandr Andrushchenko
2018-12-19 8:18 ` Oleksandr Andrushchenko
2018-12-19 13:14 ` Gerd Hoffmann
2018-12-19 13:14 ` Gerd Hoffmann
2018-12-19 13:21 ` Oleksandr Andrushchenko
2018-12-19 14:10 ` Gerd Hoffmann
2018-12-19 14:10 ` Gerd Hoffmann
2018-12-20 11:19 ` Oleksandr Andrushchenko
2018-12-20 11:19 ` Oleksandr Andrushchenko
2018-12-19 13:21 ` Oleksandr Andrushchenko
2018-12-20 15:37 ` Christoph Hellwig
2018-12-20 15:37 ` Christoph Hellwig
2018-12-20 15:37 ` Christoph Hellwig
2018-12-19 16:14 ` Noralf Trønnes
2018-12-19 16:14 ` Noralf Trønnes
2018-12-19 16:14 ` Noralf Trønnes
2018-12-20 11:24 ` Oleksandr Andrushchenko
2018-12-20 11:24 ` Oleksandr Andrushchenko
2018-12-20 11:24 ` Oleksandr Andrushchenko
2018-12-20 15:36 ` Christoph Hellwig [this message]
2018-12-20 15:36 ` Christoph Hellwig
2018-12-20 15:49 ` Oleksandr Andrushchenko
2018-12-20 15:49 ` Oleksandr Andrushchenko
2018-12-20 17:39 ` Christoph Hellwig
2018-12-20 17:39 ` Christoph Hellwig
2018-12-20 17:39 ` Christoph Hellwig
2018-12-20 18:29 ` Daniel Vetter
2018-12-20 18:33 ` Christoph Hellwig
2018-12-20 18:33 ` Christoph Hellwig
2018-12-20 18:35 ` Daniel Vetter
2018-12-20 18:38 ` Christoph Hellwig
2018-12-20 18:38 ` Christoph Hellwig
2018-12-21 9:16 ` Oleksandr Andrushchenko
2018-12-21 9:16 ` Oleksandr Andrushchenko
2018-12-20 18:35 ` Daniel Vetter
2018-12-20 18:29 ` Daniel Vetter
2018-12-20 15:36 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-11-27 10:32 Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220153646.GA22997@infradead.org \
--to=hch@infradead.org \
--cc=andr2000@gmail.com \
--cc=boris.ostrovsky@oracle.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=noralf@tronnes.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.