From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, liwei213@huawei.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
john.stultz@linaro.org, amit.kucheria@linaro.org,
guodong.xu@linaro.org
Subject: Re: [PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding
Date: Thu, 20 Dec 2018 11:12:44 -0600 [thread overview]
Message-ID: <20181220171244.GA22403@bogus> (raw)
In-Reply-To: <20181207175151.8969-2-manivannan.sadhasivam@linaro.org>
On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote:
> Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> similar to HI3660 SoC with almost same IPs. Only major difference interms
s/interms/in terms/
> of UFS is the PHY. HI3670 has 10nm PHY.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> index a48c44817367..a327c1e24365 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -6,7 +6,9 @@ Each UFS Host Controller should have its own node.
> Required properties:
> - compatible : compatible list, contains one of the following -
> "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> - host controller present on Hi36xx chipset.
> + host controller present on Hi3660 chipset.
> + "hisilicon,hi3670-ufs", "jedec,ufs-2.1" for hisi ufs
> + host controller present on Hi3670 chipset.
>From the description, sounds like having "hisilicon,hi3660-ufs" as a
fallback would be appropriate?
> - reg : should contain UFS register address space & UFS SYS CTRL register address,
> - interrupt-parent : interrupt device
Don't document interrupt-parent. It is implied.
> - interrupts : interrupt number
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: devicetree@vger.kernel.org, jejb@linux.vnet.ibm.com,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
guodong.xu@linaro.org, linux-kernel@vger.kernel.org,
amit.kucheria@linaro.org, john.stultz@linaro.org,
liwei213@huawei.com, vinholikatti@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding
Date: Thu, 20 Dec 2018 11:12:44 -0600 [thread overview]
Message-ID: <20181220171244.GA22403@bogus> (raw)
In-Reply-To: <20181207175151.8969-2-manivannan.sadhasivam@linaro.org>
On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote:
> Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> similar to HI3660 SoC with almost same IPs. Only major difference interms
s/interms/in terms/
> of UFS is the PHY. HI3670 has 10nm PHY.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> index a48c44817367..a327c1e24365 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -6,7 +6,9 @@ Each UFS Host Controller should have its own node.
> Required properties:
> - compatible : compatible list, contains one of the following -
> "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> - host controller present on Hi36xx chipset.
> + host controller present on Hi3660 chipset.
> + "hisilicon,hi3670-ufs", "jedec,ufs-2.1" for hisi ufs
> + host controller present on Hi3670 chipset.
From the description, sounds like having "hisilicon,hi3660-ufs" as a
fallback would be appropriate?
> - reg : should contain UFS register address space & UFS SYS CTRL register address,
> - interrupt-parent : interrupt device
Don't document interrupt-parent. It is implied.
> - interrupts : interrupt number
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: vinholikatti@gmail.com, jejb@linux.vnet.ibm.com,
martin.petersen@oracle.com, liwei213@huawei.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
john.stultz@linaro.org, amit.kucheria@linaro.org,
guodong.xu@linaro.org
Subject: Re: [PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding
Date: Thu, 20 Dec 2018 11:12:44 -0600 [thread overview]
Message-ID: <20181220171244.GA22403@bogus> (raw)
In-Reply-To: <20181207175151.8969-2-manivannan.sadhasivam@linaro.org>
On Fri, Dec 07, 2018 at 11:21:49PM +0530, Manivannan Sadhasivam wrote:
> Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very
> similar to HI3660 SoC with almost same IPs. Only major difference interms
s/interms/in terms/
> of UFS is the PHY. HI3670 has 10nm PHY.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> index a48c44817367..a327c1e24365 100644
> --- a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -6,7 +6,9 @@ Each UFS Host Controller should have its own node.
> Required properties:
> - compatible : compatible list, contains one of the following -
> "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> - host controller present on Hi36xx chipset.
> + host controller present on Hi3660 chipset.
> + "hisilicon,hi3670-ufs", "jedec,ufs-2.1" for hisi ufs
> + host controller present on Hi3670 chipset.
From the description, sounds like having "hisilicon,hi3660-ufs" as a
fallback would be appropriate?
> - reg : should contain UFS register address space & UFS SYS CTRL register address,
> - interrupt-parent : interrupt device
Don't document interrupt-parent. It is implied.
> - interrupts : interrupt number
> --
> 2.17.1
>
next prev parent reply other threads:[~2018-12-20 17:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 17:51 [PATCH 0/3] Add UFS controller support for HI3670 SoC Manivannan Sadhasivam
2018-12-07 17:51 ` Manivannan Sadhasivam
2018-12-07 17:51 ` [PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding Manivannan Sadhasivam
2018-12-07 17:51 ` Manivannan Sadhasivam
2018-12-20 17:12 ` Rob Herring [this message]
2018-12-20 17:12 ` Rob Herring
2018-12-20 17:12 ` Rob Herring
2018-12-21 2:24 ` Manivannan Sadhasivam
2018-12-21 2:24 ` Manivannan Sadhasivam
2018-12-07 17:51 ` [PATCH 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support Manivannan Sadhasivam
2018-12-07 17:51 ` Manivannan Sadhasivam
2018-12-07 17:51 ` [PATCH 3/3] scsi: ufs: Add HI3670 SoC UFS driver support Manivannan Sadhasivam
2018-12-07 17:51 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181220171244.GA22403@bogus \
--to=robh@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.